marcel/familienarchiv
1
0
Fork 0
Code Issues 118 Pull Requests 2 Actions 4 Packages Projects Releases Wiki Activity

test: share fakePdfjs fixture across viewer test files #542

New Issue
Open
opened 2026-05-12 09:39:45 +02:00 by marcel · 0 comments
marcel commented 2026-05-12 09:39:45 +02:00
Owner
Copy Link

Context

makeFakePdfjsLib() is currently defined independently in two test files:

  • frontend/src/lib/document/viewer/PdfViewer.svelte.spec.ts
  • frontend/src/lib/document/viewer/usePdfRenderer.svelte.test.ts

The two copies are structurally similar but not identical. As more components adopt the libLoader injection pattern (per ADR 012), this fake will be defined a third and fourth time, causing drift between implementations.

Acceptance criteria

  • Extract a shared frontend/src/lib/document/viewer/__testUtils__/fakePdfjs.ts (or equivalent path) exporting makeFakePdfjsLib() and makeFakeLibLoader()
  • Both existing test files import from the shared module — no local copy remains
  • All tests in both files still pass after the extraction

Raised by Felix Brandt in PR #536 round-4 review.

## Context `makeFakePdfjsLib()` is currently defined independently in two test files: - `frontend/src/lib/document/viewer/PdfViewer.svelte.spec.ts` - `frontend/src/lib/document/viewer/usePdfRenderer.svelte.test.ts` The two copies are structurally similar but not identical. As more components adopt the `libLoader` injection pattern (per ADR 012), this fake will be defined a third and fourth time, causing drift between implementations. ## Acceptance criteria - Extract a shared `frontend/src/lib/document/viewer/__testUtils__/fakePdfjs.ts` (or equivalent path) exporting `makeFakePdfjsLib()` and `makeFakeLibLoader()` - Both existing test files import from the shared module — no local copy remains - All tests in both files still pass after the extraction Raised by Felix Brandt in PR #536 round-4 review.
marcel added the P3-laterrefactortest labels 2026-05-12 09:40:08 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label P3-later refactor test
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?