marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs: ADR for client-side fetch exception in editor suggestion plugins #631

New Issue
Open
opened 2026-05-19 23:31:19 +02:00 by marcel · 0 comments
marcel commented 2026-05-19 23:31:19 +02:00
Owner
Copy Link

Context

PR #629 introduced a per-keystroke client-side fetch from PersonMentionEditor.svelte to /api/persons (driven by the Tiptap suggestion plugin's items() callback — now via the dropdown's debounced onSearch). This violates the frontend/CLAUDE.md rule "no client-side API fetch — data flows from +page.server.ts via props".

The inline comment at PersonMentionEditor.svelte:140-153 argues the exception is justified for Tiptap's suggestion plugin (browser-only by design, latency-sensitive, cookie-auth via Vite/Caddy proxy works identically) and references a follow-up ADR — but no ADR is on disk yet.

Decision needed

Write an ADR formalising:

  1. Why the exception is justified — Tiptap suggestion plugins live in the browser; routing through a SvelteKit form action would round-trip through SSR for a typeahead that needs to feel instant; a +server.ts proxy is identical in cost but adds a hop.
  2. The boundary — client-side fetch is allowed ONLY for editor suggestion plugins (Tiptap, similar future libraries). All other client-side fetches remain disallowed.
  3. Auth model — relies on cookie-based auth flowing through the dev proxy and prod Caddy unchanged.
  4. What this enables (future Tiptap features: hashtag mention, document linking, etc.).
  5. What this does NOT enable (no general "fetch on load" pattern; SSR-first remains the default).

Reviewer rationale: Markus on PR #629 comment #10919, re-flagged on comment #10959.

Acceptance

  • ADR file added at docs/adr/00XX-client-side-fetch-exception-for-suggestion-plugins.md following existing ADR template.
  • Referenced from frontend/CLAUDE.md (the "no client-side API fetch" rule should cite the exception).
  • Inline comment in PersonMentionEditor.svelte:140-153 updated to link the ADR file.
## Context PR #629 introduced a per-keystroke client-side fetch from `PersonMentionEditor.svelte` to `/api/persons` (driven by the Tiptap suggestion plugin's `items()` callback — now via the dropdown's debounced `onSearch`). This violates the `frontend/CLAUDE.md` rule "no client-side API fetch — data flows from +page.server.ts via props". The inline comment at `PersonMentionEditor.svelte:140-153` argues the exception is justified for Tiptap's suggestion plugin (browser-only by design, latency-sensitive, cookie-auth via Vite/Caddy proxy works identically) and references a follow-up ADR — but no ADR is on disk yet. ## Decision needed Write an ADR formalising: 1. **Why the exception is justified** — Tiptap suggestion plugins live in the browser; routing through a SvelteKit form action would round-trip through SSR for a typeahead that needs to feel instant; a `+server.ts` proxy is identical in cost but adds a hop. 2. **The boundary** — client-side fetch is allowed ONLY for editor suggestion plugins (Tiptap, similar future libraries). All other client-side fetches remain disallowed. 3. **Auth model** — relies on cookie-based auth flowing through the dev proxy and prod Caddy unchanged. 4. **What this enables** (future Tiptap features: hashtag mention, document linking, etc.). 5. **What this does NOT enable** (no general "fetch on load" pattern; SSR-first remains the default). Reviewer rationale: Markus on PR #629 comment #10919, re-flagged on comment #10959. ## Acceptance - [ ] ADR file added at `docs/adr/00XX-client-side-fetch-exception-for-suggestion-plugins.md` following existing ADR template. - [ ] Referenced from `frontend/CLAUDE.md` (the "no client-side API fetch" rule should cite the exception). - [ ] Inline comment in `PersonMentionEditor.svelte:140-153` updated to link the ADR file.
marcel added the P3-laterdocumentation labels 2026-05-19 23:31:26 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label P3-later documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?