marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat(a11y): wire aria-controls + aria-activedescendant on @mention editor #636

New Issue
Open
opened 2026-05-19 23:32:31 +02:00 by marcel · 0 comments
marcel commented 2026-05-19 23:32:31 +02:00
Owner
Copy Link

Context

PR #629's @mention dropdown is mounted to document.body (imperative mount); it's not a child of the editor's contenteditable in the DOM. Screen-reader users have no signal that the listbox exists while focus is in the editor.

Leonie FINDING-MENTION-003 on #10936.

Required

  • Editor's contenteditable declares aria-controls={listboxId} when the dropdown is open.
  • Editor's contenteditable declares aria-activedescendant={highlightedOptionId} so screen readers announce the highlighted option without focus shift.
  • Listbox id is stable for the lifetime of one suggestion session.
  • Each <div role="option"> has a stable id referenced by aria-activedescendant.
  • axe-core scan passes (validate with the E2E in issue 5 above).

Acceptance

  • Implemented in PersonMentionEditor + MentionDropdown.
  • Manual SR test with NVDA or VoiceOver shows the listbox and the current option are announced.

Reviewer rationale: Leonie on PR #629 comments #10936, #10972.

## Context PR #629's @mention dropdown is mounted to `document.body` (imperative `mount`); it's not a child of the editor's contenteditable in the DOM. Screen-reader users have no signal that the listbox exists while focus is in the editor. Leonie FINDING-MENTION-003 on #10936. ## Required - [ ] Editor's contenteditable declares `aria-controls={listboxId}` when the dropdown is open. - [ ] Editor's contenteditable declares `aria-activedescendant={highlightedOptionId}` so screen readers announce the highlighted option without focus shift. - [ ] Listbox `id` is stable for the lifetime of one suggestion session. - [ ] Each `<div role="option">` has a stable `id` referenced by `aria-activedescendant`. - [ ] axe-core scan passes (validate with the E2E in issue 5 above). ## Acceptance - [ ] Implemented in PersonMentionEditor + MentionDropdown. - [ ] Manual SR test with NVDA or VoiceOver shows the listbox and the current option are announced. Reviewer rationale: Leonie on PR #629 comments #10936, #10972.
marcel added the P3-laterfeatureui labels 2026-05-19 23:32:35 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label P3-later feature ui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#636
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?