fix(document): add trainingLabels to Document.full entity graph #642

New Issue

marcel · 2026-05-20T08:13:49+02:00

marcel commented

2026-05-20 08:13:49 +02:00

Problem

GET /api/documents/{id} returns HTTP 500 since trainingLabels was made LAZY in #467.

Root cause: Document.trainingLabels is @ElementCollection(fetch = FetchType.LAZY) but is not included in the Document.full entity graph:

@NamedEntityGraph(name = "Document.full", attributeNodes = {
        @NamedAttributeNode("sender"),
        @NamedAttributeNode("receivers"),
        @NamedAttributeNode("tags")
        // trainingLabels missing!
})

DocumentRepository.findById() uses @EntityGraph("Document.full"), which loads sender/receivers/tags eagerly. The transaction closes when getDocumentById() returns. When Jackson later serializes the Document, it accesses trainingLabels with no Hibernate session open → LazyInitializationException.

Error in staging logs:

org.hibernate.LazyInitializationException: Cannot lazily initialize collection of role
'org.raddatz.familienarchiv.document.Document.trainingLabels' with key
'52beeb09-ffd1-4cd3-b028-db55b4d280b1' (no session)
  through reference chain: ...Document["trainingLabels"]

Fix

Add trainingLabels to Document.full:

@NamedEntityGraph(name = "Document.full", attributeNodes = {
        @NamedAttributeNode("sender"),
        @NamedAttributeNode("receivers"),
        @NamedAttributeNode("tags"),
        @NamedAttributeNode("trainingLabels")
})

Acceptance criteria

GET /api/documents/{id} returns 200 with a document that has trainingLabels
Existing lazy-loading tests in DocumentLazyLoadingTest pass
No N+1 regression (entity graph JOIN already covers it)

## Problem `GET /api/documents/{id}` returns HTTP 500 since `trainingLabels` was made LAZY in #467. Root cause: `Document.trainingLabels` is `@ElementCollection(fetch = FetchType.LAZY)` but is **not** included in the `Document.full` entity graph: ```java @NamedEntityGraph(name = "Document.full", attributeNodes = { @NamedAttributeNode("sender"), @NamedAttributeNode("receivers"), @NamedAttributeNode("tags") // trainingLabels missing! }) ``` `DocumentRepository.findById()` uses `@EntityGraph("Document.full")`, which loads sender/receivers/tags eagerly. The transaction closes when `getDocumentById()` returns. When Jackson later serializes the `Document`, it accesses `trainingLabels` with no Hibernate session open → `LazyInitializationException`. Error in staging logs: ``` org.hibernate.LazyInitializationException: Cannot lazily initialize collection of role 'org.raddatz.familienarchiv.document.Document.trainingLabels' with key '52beeb09-ffd1-4cd3-b028-db55b4d280b1' (no session) through reference chain: ...Document["trainingLabels"] ``` ## Fix Add `trainingLabels` to `Document.full`: ```java @NamedEntityGraph(name = "Document.full", attributeNodes = { @NamedAttributeNode("sender"), @NamedAttributeNode("receivers"), @NamedAttributeNode("tags"), @NamedAttributeNode("trainingLabels") }) ``` ## Acceptance criteria - `GET /api/documents/{id}` returns 200 with a document that has `trainingLabels` - Existing lazy-loading tests in `DocumentLazyLoadingTest` pass - No N+1 regression (entity graph JOIN already covers it)

marcel added the P1-high bug labels 2026-05-20 08:13:54 +02:00

marcel referenced this issue from a commit

2026-05-20 08:16:45 +02:00

fix(document): add trainingLabels to Document.full entity graph (#642)

marcel referenced this issue

2026-05-20 08:17:00 +02:00

fix(deploy): wire SENTRY_DSN and enable ECS JSON logging for prod (#641) #643

marcel referenced a pull request that will close this issue

2026-05-20 08:17:08 +02:00

fix(document): add trainingLabels to Document.full entity graph (#642) #644

marcel referenced this issue

2026-05-20 09:17:05 +02:00