Extract a SearchFilters record for the document search signatures #683

New Issue

marcel · 2026-05-27T19:10:23+02:00

marcel commented

2026-05-27 19:10:23 +02:00

Context

Follow-up flagged in the review of PR #682 (Phase 6 undated documents, #668) — Felix (developer).

After threading the undated filter through search, DocumentService.searchDocuments(...) and findIdsForFilter(...) (and the controller that calls them) now take ~13 positional parameters. That's hard to read and easy to mis-call (positional args of the same type are a swap-bug risk).

Suggested approach

Introduce a SearchFilters record (q, from, to, tags, sender, receiver, status, scriptType, undated, sort, direction, page, size — whatever the real set is) in the document package.
Replace the long positional signatures on the service + the /search and /ids paths; the controller binds query params into the record.
Pure refactor — no behavior change; existing search/undated tests must stay green.

Out of scope / notes

Deliberately NOT done in #682 to keep that PR focused; Felix explicitly flagged it as a follow-up.
No API/behavior change intended.

## Context Follow-up flagged in the review of PR #682 (Phase 6 undated documents, #668) — Felix (developer). After threading the `undated` filter through search, `DocumentService.searchDocuments(...)` and `findIdsForFilter(...)` (and the controller that calls them) now take **~13 positional parameters**. That's hard to read and easy to mis-call (positional args of the same type are a swap-bug risk). ## Suggested approach - Introduce a `SearchFilters` record (q, from, to, tags, sender, receiver, status, scriptType, undated, sort, direction, page, size — whatever the real set is) in the `document` package. - Replace the long positional signatures on the service + the `/search` and `/ids` paths; the controller binds query params into the record. - Pure refactor — no behavior change; existing search/undated tests must stay green. ## Out of scope / notes - Deliberately NOT done in #682 to keep that PR focused; Felix explicitly flagged it as a follow-up. - No API/behavior change intended.

marcel added the P3-later refactor labels 2026-05-27 19:10:35 +02:00

marcel referenced this issue

2026-05-27 19:12:13 +02:00

feat(documents): honest handling of undated documents in browse & search (Phase 6, #668) #682

marcel referenced this issue

2026-05-27 19:12:28 +02:00

feat(documents): honest handling of undated documents in browse & search (Phase 6, #668) #682

marcel referenced this issue

2026-05-27 19:13:42 +02:00

feat(documents): honest handling of undated documents in browse & search (Phase 6, #668) #682

marcel referenced this issue

2026-05-27 19:47:18 +02:00