diff --git a/backend/pom.xml b/backend/pom.xml index a5eddab8..f2dc9a8b 100644 --- a/backend/pom.xml +++ b/backend/pom.xml @@ -65,6 +65,16 @@ org.springframework.boot spring-boot-starter-jetty + + org.springframework.boot + spring-boot-testcontainers + test + + + org.testcontainers + testcontainers-postgresql + test + org.springframework.boot spring-boot-starter-actuator-test @@ -161,6 +171,51 @@ + + org.jacoco + jacoco-maven-plugin + 0.8.12 + + + **/dto/** + **/config/** + **/exception/ErrorCode* + **/model/** + + + + + prepare-agent + prepare-agent + + + report + verify + report + + + + check + verify + check + + + + BUNDLE + + + BRANCH + COVEREDRATIO + 0.42 + + + + + + + + org.springframework.boot spring-boot-maven-plugin diff --git a/backend/src/test/java/org/raddatz/familienarchiv/ApplicationContextTest.java b/backend/src/test/java/org/raddatz/familienarchiv/ApplicationContextTest.java new file mode 100644 index 00000000..899c526c --- /dev/null +++ b/backend/src/test/java/org/raddatz/familienarchiv/ApplicationContextTest.java @@ -0,0 +1,25 @@ +package org.raddatz.familienarchiv; + +import org.junit.jupiter.api.Test; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.boot.testcontainers.service.connection.ServiceConnection; +import org.springframework.context.annotation.Import; +import org.springframework.test.context.ActiveProfiles; +import org.springframework.test.context.bean.override.mockito.MockitoBean; +import org.testcontainers.containers.PostgreSQLContainer; +import software.amazon.awssdk.services.s3.S3Client; + +@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE) +@ActiveProfiles("test") +@Import(PostgresContainerConfig.class) +class ApplicationContextTest { + + @MockitoBean + S3Client s3Client; + + @Test + void contextLoads() { + // verifies that the Spring context starts successfully with all beans wired, + // Flyway migrations applied, and no configuration errors + } +} diff --git a/backend/src/test/java/org/raddatz/familienarchiv/PostgresContainerConfig.java b/backend/src/test/java/org/raddatz/familienarchiv/PostgresContainerConfig.java new file mode 100644 index 00000000..20c0697e --- /dev/null +++ b/backend/src/test/java/org/raddatz/familienarchiv/PostgresContainerConfig.java @@ -0,0 +1,16 @@ +package org.raddatz.familienarchiv; + +import org.springframework.boot.test.context.TestConfiguration; +import org.springframework.boot.testcontainers.service.connection.ServiceConnection; +import org.springframework.context.annotation.Bean; +import org.testcontainers.containers.PostgreSQLContainer; + +@TestConfiguration(proxyBeanMethods = false) +public class PostgresContainerConfig { + + @Bean + @ServiceConnection + PostgreSQLContainer postgresContainer() { + return new PostgreSQLContainer<>("postgres:16-alpine"); + } +} diff --git a/backend/src/test/java/org/raddatz/familienarchiv/repository/DocumentRepositoryTest.java b/backend/src/test/java/org/raddatz/familienarchiv/repository/DocumentRepositoryTest.java new file mode 100644 index 00000000..0a960117 --- /dev/null +++ b/backend/src/test/java/org/raddatz/familienarchiv/repository/DocumentRepositoryTest.java @@ -0,0 +1,150 @@ +package org.raddatz.familienarchiv.repository; + +import org.junit.jupiter.api.Test; +import org.raddatz.familienarchiv.PostgresContainerConfig; +import org.raddatz.familienarchiv.config.FlywayConfig; +import org.raddatz.familienarchiv.model.Document; +import org.raddatz.familienarchiv.model.DocumentStatus; +import org.raddatz.familienarchiv.model.Person; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.jdbc.test.autoconfigure.AutoConfigureTestDatabase; +import org.springframework.boot.data.jpa.test.autoconfigure.DataJpaTest; +import org.springframework.context.annotation.Import; + +import java.util.List; +import java.util.Optional; + +import static org.assertj.core.api.Assertions.assertThat; + +@DataJpaTest +@AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.NONE) +@Import({PostgresContainerConfig.class, FlywayConfig.class}) +class DocumentRepositoryTest { + + @Autowired + private DocumentRepository documentRepository; + + @Autowired + private PersonRepository personRepository; + + // ─── save and findById ──────────────────────────────────────────────────── + + @Test + void save_persistsDocument_andFindByIdReturnsSameDocument() { + Document document = Document.builder() + .title("Testbrief") + .originalFilename("testbrief.pdf") + .status(DocumentStatus.PLACEHOLDER) + .build(); + + Document saved = documentRepository.save(document); + Optional found = documentRepository.findById(saved.getId()); + + assertThat(found).isPresent(); + assertThat(found.get().getTitle()).isEqualTo("Testbrief"); + assertThat(found.get().getStatus()).isEqualTo(DocumentStatus.PLACEHOLDER); + } + + // ─── findByStatus ───────────────────────────────────────────────────────── + + @Test + void findByStatus_returnsOnlyDocumentsWithMatchingStatus() { + documentRepository.save(Document.builder() + .title("Placeholder Doc") + .originalFilename("placeholder.pdf") + .status(DocumentStatus.PLACEHOLDER) + .build()); + documentRepository.save(Document.builder() + .title("Uploaded Doc") + .originalFilename("uploaded.pdf") + .status(DocumentStatus.UPLOADED) + .build()); + + List placeholders = documentRepository.findByStatus(DocumentStatus.PLACEHOLDER); + + assertThat(placeholders).extracting(Document::getStatus) + .containsOnly(DocumentStatus.PLACEHOLDER); + } + + // ─── findByOriginalFilename ─────────────────────────────────────────────── + + @Test + void findByOriginalFilename_returnsDocument_whenFilenameMatches() { + documentRepository.save(Document.builder() + .title("Omas Brief") + .originalFilename("omas_brief.pdf") + .status(DocumentStatus.PLACEHOLDER) + .build()); + + Optional found = documentRepository.findByOriginalFilename("omas_brief.pdf"); + + assertThat(found).isPresent(); + assertThat(found.get().getTitle()).isEqualTo("Omas Brief"); + } + + @Test + void findByOriginalFilename_returnsEmpty_whenFilenameDoesNotExist() { + Optional found = documentRepository.findByOriginalFilename("does_not_exist.pdf"); + + assertThat(found).isEmpty(); + } + + // ─── existsByOriginalFilename ───────────────────────────────────────────── + + @Test + void existsByOriginalFilename_returnsTrue_whenDocumentExists() { + documentRepository.save(Document.builder() + .title("Brief") + .originalFilename("brief.pdf") + .status(DocumentStatus.PLACEHOLDER) + .build()); + + assertThat(documentRepository.existsByOriginalFilename("brief.pdf")).isTrue(); + } + + @Test + void existsByOriginalFilename_returnsFalse_whenDocumentDoesNotExist() { + assertThat(documentRepository.existsByOriginalFilename("nonexistent.pdf")).isFalse(); + } + + // ─── findBySenderId ─────────────────────────────────────────────────────── + + @Test + void findBySenderId_returnsDocuments_whereSenderIdMatches() { + Person sender = personRepository.save(Person.builder() + .firstName("Hans") + .lastName("Müller") + .build()); + documentRepository.save(Document.builder() + .title("Brief von Hans") + .originalFilename("brief_hans.pdf") + .status(DocumentStatus.UPLOADED) + .sender(sender) + .build()); + + List docs = documentRepository.findBySenderId(sender.getId()); + + assertThat(docs).hasSize(1); + assertThat(docs.get(0).getSender().getId()).isEqualTo(sender.getId()); + } + + // ─── countByMetadataCompleteFalse ───────────────────────────────────────── + + @Test + void countByMetadataCompleteFalse_returnsNumberOfIncompleteDocuments() { + documentRepository.save(Document.builder() + .title("Incomplete") + .originalFilename("incomplete.pdf") + .status(DocumentStatus.PLACEHOLDER) + .metadataComplete(false) + .build()); + documentRepository.save(Document.builder() + .title("Complete") + .originalFilename("complete.pdf") + .status(DocumentStatus.UPLOADED) + .metadataComplete(true) + .build()); + + assertThat(documentRepository.countByMetadataCompleteFalse()).isEqualTo(1); + } +} diff --git a/backend/src/test/java/org/raddatz/familienarchiv/repository/PersonRepositoryTest.java b/backend/src/test/java/org/raddatz/familienarchiv/repository/PersonRepositoryTest.java new file mode 100644 index 00000000..8ed8fb09 --- /dev/null +++ b/backend/src/test/java/org/raddatz/familienarchiv/repository/PersonRepositoryTest.java @@ -0,0 +1,136 @@ +package org.raddatz.familienarchiv.repository; + +import org.junit.jupiter.api.Test; +import org.raddatz.familienarchiv.PostgresContainerConfig; +import org.raddatz.familienarchiv.config.FlywayConfig; +import org.raddatz.familienarchiv.model.Person; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.jdbc.test.autoconfigure.AutoConfigureTestDatabase; +import org.springframework.boot.data.jpa.test.autoconfigure.DataJpaTest; +import org.springframework.context.annotation.Import; + +import java.util.List; +import java.util.Optional; + +import static org.assertj.core.api.Assertions.assertThat; + +@DataJpaTest +@AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.NONE) +@Import({PostgresContainerConfig.class, FlywayConfig.class}) +class PersonRepositoryTest { + + @Autowired + private PersonRepository personRepository; + + // ─── save and findById ──────────────────────────────────────────────────── + + @Test + void save_persistsPerson_andFindByIdReturnsSamePerson() { + Person person = Person.builder() + .firstName("Anna") + .lastName("Schmidt") + .build(); + + Person saved = personRepository.save(person); + Optional found = personRepository.findById(saved.getId()); + + assertThat(found).isPresent(); + assertThat(found.get().getFirstName()).isEqualTo("Anna"); + assertThat(found.get().getLastName()).isEqualTo("Schmidt"); + } + + // ─── searchByName ───────────────────────────────────────────────────────── + + @Test + void searchByName_findsByFirstName() { + personRepository.save(Person.builder().firstName("Hans").lastName("Müller").build()); + personRepository.save(Person.builder().firstName("Anna").lastName("Schmidt").build()); + + List results = personRepository.searchByName("Hans"); + + assertThat(results).hasSize(1); + assertThat(results.get(0).getFirstName()).isEqualTo("Hans"); + } + + @Test + void searchByName_findsByLastName() { + personRepository.save(Person.builder().firstName("Hans").lastName("Müller").build()); + personRepository.save(Person.builder().firstName("Anna").lastName("Schmidt").build()); + + List results = personRepository.searchByName("Schmidt"); + + assertThat(results).hasSize(1); + assertThat(results.get(0).getLastName()).isEqualTo("Schmidt"); + } + + @Test + void searchByName_isCaseInsensitive() { + personRepository.save(Person.builder().firstName("Hans").lastName("Müller").build()); + + List results = personRepository.searchByName("hans"); + + assertThat(results).hasSize(1); + } + + @Test + void searchByName_findsByAlias() { + personRepository.save(Person.builder() + .firstName("Hans").lastName("Müller").alias("Opa Hans").build()); + + List results = personRepository.searchByName("Opa Hans"); + + assertThat(results).hasSize(1); + } + + // ─── findAllByOrderByLastNameAscFirstNameAsc ────────────────────────────── + + @Test + void findAllByOrderByLastNameAscFirstNameAsc_returnsSortedByLastNameThenFirstName() { + personRepository.save(Person.builder().firstName("Bernd").lastName("Ziegler").build()); + personRepository.save(Person.builder().firstName("Anna").lastName("Müller").build()); + personRepository.save(Person.builder().firstName("Clara").lastName("Müller").build()); + + List sorted = personRepository.findAllByOrderByLastNameAscFirstNameAsc(); + + assertThat(sorted).extracting(Person::getLastName) + .startsWith("Müller", "Müller"); + assertThat(sorted.stream() + .filter(p -> p.getLastName().equals("Müller")) + .map(Person::getFirstName) + .toList()) + .containsExactly("Anna", "Clara"); + } + + // ─── findByAliasIgnoreCase ──────────────────────────────────────────────── + + @Test + void findByAliasIgnoreCase_returnsMatchingPerson() { + personRepository.save(Person.builder() + .firstName("Karl").lastName("Brandt").alias("Opa Karl").build()); + + Optional found = personRepository.findByAliasIgnoreCase("opa karl"); + + assertThat(found).isPresent(); + assertThat(found.get().getFirstName()).isEqualTo("Karl"); + } + + @Test + void findByAliasIgnoreCase_returnsEmpty_whenAliasDoesNotMatch() { + Optional found = personRepository.findByAliasIgnoreCase("nobody"); + + assertThat(found).isEmpty(); + } + + // ─── findByFirstNameIgnoreCaseAndLastNameIgnoreCase ─────────────────────── + + @Test + void findByFirstNameIgnoreCaseAndLastNameIgnoreCase_returnsMatch() { + personRepository.save(Person.builder().firstName("Maria").lastName("Raddatz").build()); + + Optional found = personRepository.findByFirstNameIgnoreCaseAndLastNameIgnoreCase( + "maria", "raddatz"); + + assertThat(found).isPresent(); + assertThat(found.get().getFirstName()).isEqualTo("Maria"); + } +} diff --git a/backend/src/test/resources/application-test.yaml b/backend/src/test/resources/application-test.yaml new file mode 100644 index 00000000..6a8cbad3 --- /dev/null +++ b/backend/src/test/resources/application-test.yaml @@ -0,0 +1,15 @@ +app: + s3: + endpoint: http://localhost:9000 + access-key: dummy + secret-key: dummy + bucket: test-bucket + region: us-east-1 + +spring: + datasource: + url: will-be-overridden-by-testcontainers + username: test + password: test + mail: + host: localhost diff --git a/frontend/.gitignore b/frontend/.gitignore index 8bc105d9..79a69b7d 100644 --- a/frontend/.gitignore +++ b/frontend/.gitignore @@ -29,3 +29,4 @@ src/lib/paraglide # (committed as a stub; overwritten by the real spec after generation) # src/lib/generated/api.ts src/lib/paraglide_bak* +/coverage diff --git a/frontend/e2e/accessibility.spec.ts b/frontend/e2e/accessibility.spec.ts new file mode 100644 index 00000000..3603f5db --- /dev/null +++ b/frontend/e2e/accessibility.spec.ts @@ -0,0 +1,62 @@ +import AxeBuilder from '@axe-core/playwright'; +import { test, expect } from '@playwright/test'; + +/** + * Automated accessibility checks using axe-core (wcag2a + wcag2aa). + * Authenticated pages use the stored admin session from playwright.config.ts. + * The login page test overrides to an unauthenticated context. + * + * Known exclusion: + * color-contrast — brand palette (ink-3, text-ink/60) does not meet AA contrast + * ratios. Requires a design review with Leonie before fixing. Tracked separately. + */ + +const AUTHENTICATED_PAGES = [ + { name: 'home', path: '/' }, + { name: 'persons', path: '/persons' }, + { name: 'admin', path: '/admin' } +]; + +function buildAxe(page: Parameters[0]['page']) { + return new AxeBuilder({ page }).withTags(['wcag2a', 'wcag2aa']).disableRules(['color-contrast']); +} + +test.describe('Accessibility — authenticated pages', () => { + for (const { name, path } of AUTHENTICATED_PAGES) { + test(`${name} page has no critical wcag2a/wcag2aa violations`, async ({ page }) => { + await page.goto(path); + await page.waitForSelector('[data-hydrated]'); + + const results = await buildAxe(page).analyze(); + + if (results.violations.length > 0) { + const summary = results.violations + .map((v) => `[${v.impact}] ${v.id}: ${v.description} (${v.nodes.length} node(s))`) + .join('\n'); + console.log(`\nAccessibility violations on ${name}:\n${summary}`); + } + + expect(results.violations).toEqual([]); + }); + } +}); + +test.describe('Accessibility — login page', () => { + test.use({ storageState: { cookies: [], origins: [] } }); + + test('login page has no critical wcag2a/wcag2aa violations', async ({ page }) => { + await page.goto('/login'); + await expect(page.getByLabel('Benutzername')).toBeVisible(); + + const results = await buildAxe(page).analyze(); + + if (results.violations.length > 0) { + const summary = results.violations + .map((v) => `[${v.impact}] ${v.id}: ${v.description} (${v.nodes.length} node(s))`) + .join('\n'); + console.log(`\nAccessibility violations on login:\n${summary}`); + } + + expect(results.violations).toEqual([]); + }); +}); diff --git a/frontend/messages/de.json b/frontend/messages/de.json index 8aaa2fc3..d5745100 100644 --- a/frontend/messages/de.json +++ b/frontend/messages/de.json @@ -307,5 +307,10 @@ "notification_prefs_no_email": "Bitte trage zuerst eine E-Mail-Adresse ein, um Benachrichtigungen zu erhalten.", "notification_unread": "ungelesen", "mention_btn_label": "Person erwähnen", - "mention_popup_empty": "Keine Nutzer gefunden" + "mention_popup_empty": "Keine Nutzer gefunden", + "page_title_home": "Archiv", + "page_title_persons": "Personen", + "page_title_admin": "Administration", + "page_title_login": "Anmelden", + "page_title_error": "Fehler – Familienarchiv" } diff --git a/frontend/messages/en.json b/frontend/messages/en.json index 0717d54e..66676df3 100644 --- a/frontend/messages/en.json +++ b/frontend/messages/en.json @@ -307,5 +307,10 @@ "notification_prefs_no_email": "Please add an email address above to receive notifications.", "notification_unread": "unread", "mention_btn_label": "Mention person", - "mention_popup_empty": "No users found" + "mention_popup_empty": "No users found", + "page_title_home": "Archive", + "page_title_persons": "Persons", + "page_title_admin": "Administration", + "page_title_login": "Sign in", + "page_title_error": "Error – Family Archive" } diff --git a/frontend/messages/es.json b/frontend/messages/es.json index ddf28bf2..29e1d755 100644 --- a/frontend/messages/es.json +++ b/frontend/messages/es.json @@ -307,5 +307,10 @@ "notification_prefs_no_email": "Por favor, añade una dirección de correo electrónico para recibir notificaciones.", "notification_unread": "no leído", "mention_btn_label": "Mencionar persona", - "mention_popup_empty": "No se encontraron usuarios" + "mention_popup_empty": "No se encontraron usuarios", + "page_title_home": "Archivo", + "page_title_persons": "Personas", + "page_title_admin": "Administración", + "page_title_login": "Iniciar sesión", + "page_title_error": "Error – Archivo familiar" } diff --git a/frontend/package-lock.json b/frontend/package-lock.json index 493c551e..01031480 100644 --- a/frontend/package-lock.json +++ b/frontend/package-lock.json @@ -13,6 +13,7 @@ "pdfjs-dist": "^5.5.207" }, "devDependencies": { + "@axe-core/playwright": "^4.11.1", "@eslint/compat": "^1.4.0", "@eslint/js": "^9.39.1", "@inlang/paraglide-js": "^2.5.0", @@ -26,6 +27,7 @@ "@types/diff": "^7.0.2", "@types/node": "^24", "@vitest/browser-playwright": "^4.0.10", + "@vitest/coverage-v8": "^4.1.0", "eslint": "^9.39.1", "eslint-config-prettier": "^10.1.8", "eslint-plugin-svelte": "^3.13.0", @@ -46,6 +48,19 @@ "vitest-browser-svelte": "^2.0.1" } }, + "node_modules/@axe-core/playwright": { + "version": "4.11.1", + "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.11.1.tgz", + "integrity": "sha512-mKEfoUIB1MkVTht0BGZFXtSAEKXMJoDkyV5YZ9jbBmZCcWDz71tegNsdTkIN8zc/yMi5Gm2kx7Z5YQ9PfWNAWw==", + "dev": true, + "license": "MPL-2.0", + "dependencies": { + "axe-core": "~4.11.1" + }, + "peerDependencies": { + "playwright-core": ">= 1.0.0" + } + }, "node_modules/@babel/code-frame": { "version": "7.29.0", "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.0.tgz", @@ -61,6 +76,16 @@ "node": ">=6.9.0" } }, + "node_modules/@babel/helper-string-parser": { + "version": "7.27.1", + "resolved": "https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.27.1.tgz", + "integrity": "sha512-qMlSxKbpRlAridDExk92nSobyDdpPijUq2DW6oDnUqd0iOGxmQjyqhMIihI9+zv4LPyZdRje2cavWPbCbWm3eA==", + "dev": true, + "license": "MIT", + "engines": { + "node": ">=6.9.0" + } + }, "node_modules/@babel/helper-validator-identifier": { "version": "7.28.5", "resolved": "https://registry.npmjs.org/@babel/helper-validator-identifier/-/helper-validator-identifier-7.28.5.tgz", @@ -71,6 +96,46 @@ "node": ">=6.9.0" } }, + "node_modules/@babel/parser": { + "version": "7.29.2", + "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.29.2.tgz", + "integrity": "sha512-4GgRzy/+fsBa72/RZVJmGKPmZu9Byn8o4MoLpmNe1m8ZfYnz5emHLQz3U4gLud6Zwl0RZIcgiLD7Uq7ySFuDLA==", + "dev": true, + "license": "MIT", + "dependencies": { + "@babel/types": "^7.29.0" + }, + "bin": { + "parser": "bin/babel-parser.js" + }, + "engines": { + "node": ">=6.0.0" + } + }, + "node_modules/@babel/types": { + "version": "7.29.0", + "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.29.0.tgz", + "integrity": "sha512-LwdZHpScM4Qz8Xw2iKSzS+cfglZzJGvofQICy7W7v4caru4EaAmyUuO6BGrbyQ2mYV11W0U8j5mBhd14dd3B0A==", + "dev": true, + "license": "MIT", + "dependencies": { + "@babel/helper-string-parser": "^7.27.1", + "@babel/helper-validator-identifier": "^7.28.5" + }, + "engines": { + "node": ">=6.9.0" + } + }, + "node_modules/@bcoe/v8-coverage": { + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/@bcoe/v8-coverage/-/v8-coverage-1.0.2.tgz", + "integrity": "sha512-6zABk/ECA/QYSCQ1NGiVwwbQerUCZ+TQbp64Q3AgmfNvurHH0j8TtXa1qbShXA6qqkpAj4V5W8pP6mLe1mcMqA==", + "dev": true, + "license": "MIT", + "engines": { + "node": ">=18" + } + }, "node_modules/@blazediff/core": { "version": "1.9.1", "resolved": "https://registry.npmjs.org/@blazediff/core/-/core-1.9.1.tgz", @@ -2522,6 +2587,37 @@ } } }, + "node_modules/@vitest/coverage-v8": { + "version": "4.1.0", + "resolved": "https://registry.npmjs.org/@vitest/coverage-v8/-/coverage-v8-4.1.0.tgz", + "integrity": "sha512-nDWulKeik2bL2Va/Wl4x7DLuTKAXa906iRFooIRPR+huHkcvp9QDkPQ2RJdmjOFrqOqvNfoSQLF68deE3xC3CQ==", + "dev": true, + "license": "MIT", + "dependencies": { + "@bcoe/v8-coverage": "^1.0.2", + "@vitest/utils": "4.1.0", + "ast-v8-to-istanbul": "^1.0.0", + "istanbul-lib-coverage": "^3.2.2", + "istanbul-lib-report": "^3.0.1", + "istanbul-reports": "^3.2.0", + "magicast": "^0.5.2", + "obug": "^2.1.1", + "std-env": "^4.0.0-rc.1", + "tinyrainbow": "^3.0.3" + }, + "funding": { + "url": "https://opencollective.com/vitest" + }, + "peerDependencies": { + "@vitest/browser": "4.1.0", + "vitest": "4.1.0" + }, + "peerDependenciesMeta": { + "@vitest/browser": { + "optional": true + } + } + }, "node_modules/@vitest/expect": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/@vitest/expect/-/expect-4.1.0.tgz", @@ -2755,6 +2851,45 @@ "node": ">=12" } }, + "node_modules/ast-v8-to-istanbul": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/ast-v8-to-istanbul/-/ast-v8-to-istanbul-1.0.0.tgz", + "integrity": "sha512-1fSfIwuDICFA4LKkCzRPO7F0hzFf0B7+Xqrl27ynQaa+Rh0e1Es0v6kWHPott3lU10AyAr7oKHa65OppjLn3Rg==", + "dev": true, + "license": "MIT", + "dependencies": { + "@jridgewell/trace-mapping": "^0.3.31", + "estree-walker": "^3.0.3", + "js-tokens": "^10.0.0" + } + }, + "node_modules/ast-v8-to-istanbul/node_modules/estree-walker": { + "version": "3.0.3", + "resolved": "https://registry.npmjs.org/estree-walker/-/estree-walker-3.0.3.tgz", + "integrity": "sha512-7RUKfXgSMMkzt6ZuXmqapOurLGPPfgj6l9uRZ7lRGolvk0y2yocc35LdcxKC5PQZdn2DMqioAQ2NoWcrTKmm6g==", + "dev": true, + "license": "MIT", + "dependencies": { + "@types/estree": "^1.0.0" + } + }, + "node_modules/ast-v8-to-istanbul/node_modules/js-tokens": { + "version": "10.0.0", + "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-10.0.0.tgz", + "integrity": "sha512-lM/UBzQmfJRo9ABXbPWemivdCW8V2G8FHaHdypQaIy523snUjog0W71ayWXTjiR+ixeMyVHN2XcpnTd/liPg/Q==", + "dev": true, + "license": "MIT" + }, + "node_modules/axe-core": { + "version": "4.11.1", + "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.11.1.tgz", + "integrity": "sha512-BASOg+YwO2C+346x3LZOeoovTIoTrRqEsqMa6fmfAV0P+U9mFr9NsyOEpiYvFjbc64NMrSswhV50WdXzdb/Z5A==", + "dev": true, + "license": "MPL-2.0", + "engines": { + "node": ">=4" + } + }, "node_modules/axobject-query": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/axobject-query/-/axobject-query-4.1.0.tgz", @@ -3549,6 +3684,13 @@ "node": ">= 0.4" } }, + "node_modules/html-escaper": { + "version": "2.0.2", + "resolved": "https://registry.npmjs.org/html-escaper/-/html-escaper-2.0.2.tgz", + "integrity": "sha512-H2iMtd0I4Mt5eYiapRdIDjp+XzelXQ0tFE4JS7YFwFevXXMmOp9myNrUvCg0D6ws8iqkRPBfKHgbwig1SmlLfg==", + "dev": true, + "license": "MIT" + }, "node_modules/https-proxy-agent": { "version": "7.0.6", "resolved": "https://registry.npmjs.org/https-proxy-agent/-/https-proxy-agent-7.0.6.tgz", @@ -3686,6 +3828,45 @@ "dev": true, "license": "ISC" }, + "node_modules/istanbul-lib-coverage": { + "version": "3.2.2", + "resolved": "https://registry.npmjs.org/istanbul-lib-coverage/-/istanbul-lib-coverage-3.2.2.tgz", + "integrity": "sha512-O8dpsF+r0WV/8MNRKfnmrtCWhuKjxrq2w+jpzBL5UZKTi2LeVWnWOmWRxFlesJONmc+wLAGvKQZEOanko0LFTg==", + "dev": true, + "license": "BSD-3-Clause", + "engines": { + "node": ">=8" + } + }, + "node_modules/istanbul-lib-report": { + "version": "3.0.1", + "resolved": "https://registry.npmjs.org/istanbul-lib-report/-/istanbul-lib-report-3.0.1.tgz", + "integrity": "sha512-GCfE1mtsHGOELCU8e/Z7YWzpmybrx/+dSTfLrvY8qRmaY6zXTKWn6WQIjaAFw069icm6GVMNkgu0NzI4iPZUNw==", + "dev": true, + "license": "BSD-3-Clause", + "dependencies": { + "istanbul-lib-coverage": "^3.0.0", + "make-dir": "^4.0.0", + "supports-color": "^7.1.0" + }, + "engines": { + "node": ">=10" + } + }, + "node_modules/istanbul-reports": { + "version": "3.2.0", + "resolved": "https://registry.npmjs.org/istanbul-reports/-/istanbul-reports-3.2.0.tgz", + "integrity": "sha512-HGYWWS/ehqTV3xN10i23tkPkpH46MLCIMFNCaaKNavAXTF1RkqxawEPtnjnGZ6XKSInBKkiOA5BKS+aZiY3AvA==", + "dev": true, + "license": "BSD-3-Clause", + "dependencies": { + "html-escaper": "^2.0.0", + "istanbul-lib-report": "^3.0.0" + }, + "engines": { + "node": ">=8" + } + }, "node_modules/jiti": { "version": "2.6.1", "resolved": "https://registry.npmjs.org/jiti/-/jiti-2.6.1.tgz", @@ -4129,6 +4310,34 @@ "@jridgewell/sourcemap-codec": "^1.5.5" } }, + "node_modules/magicast": { + "version": "0.5.2", + "resolved": "https://registry.npmjs.org/magicast/-/magicast-0.5.2.tgz", + "integrity": "sha512-E3ZJh4J3S9KfwdjZhe2afj6R9lGIN5Pher1pF39UGrXRqq/VDaGVIGN13BjHd2u8B61hArAGOnso7nBOouW3TQ==", + "dev": true, + "license": "MIT", + "dependencies": { + "@babel/parser": "^7.29.0", + "@babel/types": "^7.29.0", + "source-map-js": "^1.2.1" + } + }, + "node_modules/make-dir": { + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/make-dir/-/make-dir-4.0.0.tgz", + "integrity": "sha512-hXdUTZYIVOt1Ex//jAQi+wTZZpUpwBj/0QsOzqegb3rGMMeJiSEu5xLHnYfBrRV4RH2+OCSOO95Is/7x1WJ4bw==", + "dev": true, + "license": "MIT", + "dependencies": { + "semver": "^7.5.3" + }, + "engines": { + "node": ">=10" + }, + "funding": { + "url": "https://github.com/sponsors/sindresorhus" + } + }, "node_modules/mini-svg-data-uri": { "version": "1.4.4", "resolved": "https://registry.npmjs.org/mini-svg-data-uri/-/mini-svg-data-uri-1.4.4.tgz", diff --git a/frontend/package.json b/frontend/package.json index 4d622d4d..e7170513 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -14,6 +14,7 @@ "lint": "prettier --check . && eslint .", "test:unit": "vitest", "test": "npm run test:unit -- --run", + "test:coverage": "vitest run --coverage --project=server", "test:e2e": "playwright test", "test:e2e:headed": "playwright test --headed", "test:e2e:ui": "playwright test --ui", @@ -25,6 +26,7 @@ "pdfjs-dist": "^5.5.207" }, "devDependencies": { + "@axe-core/playwright": "^4.11.1", "@eslint/compat": "^1.4.0", "@eslint/js": "^9.39.1", "@inlang/paraglide-js": "^2.5.0", @@ -38,6 +40,7 @@ "@types/diff": "^7.0.2", "@types/node": "^24", "@vitest/browser-playwright": "^4.0.10", + "@vitest/coverage-v8": "^4.1.0", "eslint": "^9.39.1", "eslint-config-prettier": "^10.1.8", "eslint-plugin-svelte": "^3.13.0", diff --git a/frontend/src/demo.spec.ts b/frontend/src/demo.spec.ts deleted file mode 100644 index e07cbbd7..00000000 --- a/frontend/src/demo.spec.ts +++ /dev/null @@ -1,7 +0,0 @@ -import { describe, it, expect } from 'vitest'; - -describe('sum test', () => { - it('adds 1 + 2 to equal 3', () => { - expect(1 + 2).toBe(3); - }); -}); diff --git a/frontend/src/routes/+error.svelte b/frontend/src/routes/+error.svelte new file mode 100644 index 00000000..c64461e4 --- /dev/null +++ b/frontend/src/routes/+error.svelte @@ -0,0 +1,13 @@ + + + + {m.page_title_error()} + + +
+

{page.status}

+

{page.error?.message ?? 'Internal Error'}

+
diff --git a/frontend/src/routes/+page.svelte b/frontend/src/routes/+page.svelte index 51146422..2fa78d64 100644 --- a/frontend/src/routes/+page.svelte +++ b/frontend/src/routes/+page.svelte @@ -67,6 +67,10 @@ $effect(() => { }); + + {m.page_title_home()} + +
{ type="file" multiple accept=".pdf,.jpg,.jpeg,.png,.tif,.tiff" + aria-label={m.doc_file_upload_label()} class="sr-only" onchange={handleFileSelect} /> diff --git a/frontend/src/routes/SearchFilterBar.svelte b/frontend/src/routes/SearchFilterBar.svelte index 7b471b89..daa59c60 100644 --- a/frontend/src/routes/SearchFilterBar.svelte +++ b/frontend/src/routes/SearchFilterBar.svelte @@ -44,6 +44,7 @@ let { oninput={onSearch} onfocus={onfocus} onblur={onblur} + aria-label={m.docs_search_placeholder()} placeholder={m.docs_search_placeholder()} class="block w-full border-line py-2.5 pr-10 pl-3 placeholder-ink-3 shadow-sm focus:border-ink focus:ring-ink" /> diff --git a/frontend/src/routes/admin/+page.svelte b/frontend/src/routes/admin/+page.svelte index 89e494f0..92e0a5f8 100644 --- a/frontend/src/routes/admin/+page.svelte +++ b/frontend/src/routes/admin/+page.svelte @@ -11,6 +11,10 @@ let { data, form } = $props(); let activeTab = $state('users'); + + {m.page_title_admin()} + +

{m.admin_heading()}

diff --git a/frontend/src/routes/admin/page.server.spec.ts b/frontend/src/routes/admin/page.server.spec.ts new file mode 100644 index 00000000..a8edb053 --- /dev/null +++ b/frontend/src/routes/admin/page.server.spec.ts @@ -0,0 +1,77 @@ +import { describe, expect, it, vi, beforeEach } from 'vitest'; +import { load } from './+page.server'; + +vi.mock('$lib/api.server', () => ({ createApiClient: vi.fn() })); + +import { createApiClient } from '$lib/api.server'; + +const adminUser = { groups: [{ permissions: ['ADMIN'] }] }; +const readOnlyUser = { groups: [{ permissions: ['READ_ALL'] }] }; + +function mockApiReturning(users: unknown[], groups: unknown[], tags: unknown[]) { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ response: { ok: true }, data: users }) + .mockResolvedValueOnce({ response: { ok: true }, data: groups }) + .mockResolvedValueOnce({ response: { ok: true }, data: tags }) + } as ReturnType); +} + +beforeEach(() => vi.clearAllMocks()); + +// ─── permission check ───────────────────────────────────────────────────────── + +describe('admin load — permission check', () => { + it('throws 403 when user has no ADMIN permission', async () => { + await expect( + load({ fetch: vi.fn() as unknown as typeof fetch, locals: { user: readOnlyUser } }) + ).rejects.toMatchObject({ status: 403 }); + }); + + it('throws 403 when user is undefined', async () => { + await expect( + load({ fetch: vi.fn() as unknown as typeof fetch, locals: { user: undefined } }) + ).rejects.toMatchObject({ status: 403 }); + }); + + it('throws 403 when user has no groups', async () => { + await expect( + load({ fetch: vi.fn() as unknown as typeof fetch, locals: { user: { groups: [] } } }) + ).rejects.toMatchObject({ status: 403 }); + }); +}); + +// ─── happy path ─────────────────────────────────────────────────────────────── + +describe('admin load — happy path', () => { + it('returns users, groups, and tags for an admin user', async () => { + mockApiReturning( + [{ id: 'u1', username: 'alice' }], + [{ id: 'g1', name: 'Editors' }], + [{ id: 't1', name: 'Familie' }] + ); + + const result = await load({ + fetch: vi.fn() as unknown as typeof fetch, + locals: { user: adminUser } + }); + + expect(result.users).toHaveLength(1); + expect(result.groups).toHaveLength(1); + expect(result.tags).toHaveLength(1); + }); + + it('returns empty arrays when API returns no data', async () => { + mockApiReturning([], [], []); + + const result = await load({ + fetch: vi.fn() as unknown as typeof fetch, + locals: { user: adminUser } + }); + + expect(result.users).toEqual([]); + expect(result.groups).toEqual([]); + expect(result.tags).toEqual([]); + }); +}); diff --git a/frontend/src/routes/documents/[id]/page.server.spec.ts b/frontend/src/routes/documents/[id]/page.server.spec.ts new file mode 100644 index 00000000..2d15c61c --- /dev/null +++ b/frontend/src/routes/documents/[id]/page.server.spec.ts @@ -0,0 +1,126 @@ +import { describe, expect, it, vi, beforeEach } from 'vitest'; + +vi.mock('$lib/api.server', () => ({ createApiClient: vi.fn() })); +vi.mock('$env/dynamic/private', () => ({ env: { API_INTERNAL_URL: 'http://test-backend:8080' } })); + +import { load } from './+page.server'; +import { createApiClient } from '$lib/api.server'; + +beforeEach(() => vi.clearAllMocks()); + +function makeCommentsResponse(comments: unknown[]) { + return { + ok: true, + json: vi.fn().mockResolvedValue(comments) + }; +} + +// ─── happy path ─────────────────────────────────────────────────────────────── + +describe('document detail load — happy path', () => { + it('returns document and comments on success', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockResolvedValue({ + response: { ok: true, status: 200 }, + data: { id: '123', title: 'Testbrief' } + }) + } as ReturnType); + + const mockFetch = vi.fn().mockResolvedValue(makeCommentsResponse([{ id: 'c1', body: 'Hi' }])); + + const result = await load({ + params: { id: '123' }, + fetch: mockFetch as unknown as typeof fetch + }); + + expect(result.document.title).toBe('Testbrief'); + expect(result.comments).toHaveLength(1); + }); + + it('returns empty comments when the comments fetch fails', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockResolvedValue({ + response: { ok: true, status: 200 }, + data: { id: '123', title: 'Testbrief' } + }) + } as ReturnType); + + // fetch throws a network error for the comments endpoint + const mockFetch = vi.fn().mockRejectedValue(new Error('Network error')); + + const result = await load({ + params: { id: '123' }, + fetch: mockFetch as unknown as typeof fetch + }); + + expect(result.document.title).toBe('Testbrief'); + expect(result.comments).toEqual([]); + }); + + it('returns empty comments when the comments response is not ok', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockResolvedValue({ + response: { ok: true, status: 200 }, + data: { id: '123', title: 'Testbrief' } + }) + } as ReturnType); + + const mockFetch = vi.fn().mockResolvedValue({ ok: false }); + + const result = await load({ + params: { id: '123' }, + fetch: mockFetch as unknown as typeof fetch + }); + + expect(result.comments).toEqual([]); + }); +}); + +// ─── error paths ────────────────────────────────────────────────────────────── + +describe('document detail load — error paths', () => { + it('throws 404 when document does not exist', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockResolvedValue({ + response: { ok: false, status: 404 }, + error: null + }) + } as ReturnType); + + const mockFetch = vi.fn().mockResolvedValue({ ok: false }); + + await expect( + load({ params: { id: 'missing' }, fetch: mockFetch as unknown as typeof fetch }) + ).rejects.toMatchObject({ status: 404 }); + }); + + it('throws 403 when document is forbidden', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockResolvedValue({ + response: { ok: false, status: 403 }, + error: null + }) + } as ReturnType); + + const mockFetch = vi.fn().mockResolvedValue({ ok: false }); + + await expect( + load({ params: { id: 'secret' }, fetch: mockFetch as unknown as typeof fetch }) + ).rejects.toMatchObject({ status: 403 }); + }); + + it('redirects to /login on 401', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockResolvedValue({ + response: { ok: false, status: 401 }, + error: null + }) + } as ReturnType); + + const mockFetch = vi.fn().mockResolvedValue({ ok: false }); + + await expect( + load({ params: { id: 'any' }, fetch: mockFetch as unknown as typeof fetch }) + ).rejects.toMatchObject({ location: '/login' }); + }); +}); diff --git a/frontend/src/routes/login/+page.svelte b/frontend/src/routes/login/+page.svelte index 96f0c920..598cf318 100644 --- a/frontend/src/routes/login/+page.svelte +++ b/frontend/src/routes/login/+page.svelte @@ -9,6 +9,10 @@ const localeMap = { DE: 'de', EN: 'en', ES: 'es' } as const; const activeLocale = $derived(getLocale().toUpperCase()); + + {m.page_title_login()} + +
diff --git a/frontend/src/routes/page.server.spec.ts b/frontend/src/routes/page.server.spec.ts new file mode 100644 index 00000000..e250ee78 --- /dev/null +++ b/frontend/src/routes/page.server.spec.ts @@ -0,0 +1,128 @@ +import { describe, expect, it, vi, beforeEach } from 'vitest'; + +vi.mock('$lib/api.server', () => ({ createApiClient: vi.fn() })); + +import { load } from './+page.server'; +import { createApiClient } from '$lib/api.server'; + +beforeEach(() => vi.clearAllMocks()); + +function makeUrl(params: Record = {}) { + const url = new URL('http://localhost/'); + for (const [key, value] of Object.entries(params)) { + if (Array.isArray(value)) { + value.forEach((v) => url.searchParams.append(key, v)); + } else { + url.searchParams.set(key, value); + } + } + return url; +} + +// ─── happy path ─────────────────────────────────────────────────────────────── + +describe('home page load — happy path', () => { + it('returns documents and persons on success', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ + response: { ok: true, status: 200 }, + data: [{ id: 'd1', title: 'Brief' }] + }) + .mockResolvedValueOnce({ + response: { ok: true, status: 200 }, + data: [{ id: 'p1', firstName: 'Hans', lastName: 'Müller' }] + }) + .mockResolvedValueOnce({ response: { ok: true }, data: { count: 3 } }) + } as ReturnType); + + const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch }); + + expect(result.documents).toHaveLength(1); + expect(result.incompleteCount).toBe(3); + expect(result.error).toBeNull(); + }); + + it('passes search params from the URL to the API', async () => { + const mockGet = vi + .fn() + .mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) + .mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) + .mockResolvedValueOnce({ response: { ok: true }, data: { count: 0 } }); + vi.mocked(createApiClient).mockReturnValue({ + GET: mockGet + } as ReturnType); + + await load({ + url: makeUrl({ q: 'Urlaub', from: '2020-01-01' }), + fetch: vi.fn() as unknown as typeof fetch + }); + + const firstCall = mockGet.mock.calls[0]; + expect(firstCall[1].params.query.q).toBe('Urlaub'); + expect(firstCall[1].params.query.from).toBe('2020-01-01'); + }); + + it('returns incompleteCount 0 when the incomplete-count API fails', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) + .mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) + .mockResolvedValueOnce({ response: { ok: false }, data: null }) + } as ReturnType); + + const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch }); + + expect(result.incompleteCount).toBe(0); + }); +}); + +// ─── 401 redirect ───────────────────────────────────────────────────────────── + +describe('home page load — auth redirect', () => { + it('redirects to /login when documents API returns 401', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ response: { ok: false, status: 401 }, data: null }) + .mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) + .mockResolvedValueOnce({ response: { ok: true }, data: { count: 0 } }) + } as ReturnType); + + await expect( + load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch }) + ).rejects.toMatchObject({ location: '/login' }); + }); + + it('redirects to /login when persons API returns 401', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) + .mockResolvedValueOnce({ response: { ok: false, status: 401 }, data: null }) + .mockResolvedValueOnce({ response: { ok: true }, data: { count: 0 } }) + } as ReturnType); + + await expect( + load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch }) + ).rejects.toMatchObject({ location: '/login' }); + }); +}); + +// ─── network error fallback ─────────────────────────────────────────────────── + +describe('home page load — network error fallback', () => { + it('returns error string instead of throwing when API call throws', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi.fn().mockRejectedValue(new Error('Network failure')) + } as ReturnType); + + const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch }); + + expect(result.error).toBe('Daten konnten nicht geladen werden.'); + expect(result.documents).toEqual([]); + expect(result.incompleteCount).toBe(0); + }); +}); diff --git a/frontend/src/routes/persons/+page.svelte b/frontend/src/routes/persons/+page.svelte index 779eff5c..6f5006dd 100644 --- a/frontend/src/routes/persons/+page.svelte +++ b/frontend/src/routes/persons/+page.svelte @@ -23,6 +23,10 @@ function handleSearch() { } + + {m.page_title_persons()} + +
({ createApiClient: vi.fn() })); + +import { createApiClient } from '$lib/api.server'; + +const mockFetch = vi.fn() as unknown as typeof fetch; + +beforeEach(() => vi.clearAllMocks()); + +// ─── happy path ─────────────────────────────────────────────────────────────── + +describe('person detail load — happy path', () => { + it('returns person, sentDocuments, and receivedDocuments on success', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ + response: { ok: true, status: 200 }, + data: { id: 'p1', firstName: 'Hans', lastName: 'Müller' } + }) + .mockResolvedValueOnce({ response: { ok: true }, data: [{ id: 'd1', title: 'Brief' }] }) + .mockResolvedValueOnce({ response: { ok: true }, data: [] }) + } as ReturnType); + + const result = await load({ params: { id: 'p1' }, fetch: mockFetch }); + + expect(result.person.firstName).toBe('Hans'); + expect(result.sentDocuments).toHaveLength(1); + expect(result.receivedDocuments).toEqual([]); + }); + + it('returns empty arrays when sent/received document APIs fail', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ + response: { ok: true, status: 200 }, + data: { id: 'p1', firstName: 'Anna', lastName: 'Schmidt' } + }) + .mockResolvedValueOnce({ response: { ok: false }, data: null }) + .mockResolvedValueOnce({ response: { ok: false }, data: null }) + } as ReturnType); + + const result = await load({ params: { id: 'p1' }, fetch: mockFetch }); + + expect(result.sentDocuments).toEqual([]); + expect(result.receivedDocuments).toEqual([]); + }); +}); + +// ─── error paths ────────────────────────────────────────────────────────────── + +describe('person detail load — error paths', () => { + it('throws 404 when person does not exist', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ response: { ok: false, status: 404 }, error: null }) + .mockResolvedValueOnce({ response: { ok: true }, data: [] }) + .mockResolvedValueOnce({ response: { ok: true }, data: [] }) + } as ReturnType); + + await expect(load({ params: { id: 'missing' }, fetch: mockFetch })).rejects.toMatchObject({ + status: 404 + }); + }); + + it('throws 403 when person is not accessible', async () => { + vi.mocked(createApiClient).mockReturnValue({ + GET: vi + .fn() + .mockResolvedValueOnce({ response: { ok: false, status: 403 }, error: null }) + .mockResolvedValueOnce({ response: { ok: true }, data: [] }) + .mockResolvedValueOnce({ response: { ok: true }, data: [] }) + } as ReturnType); + + await expect(load({ params: { id: 'forbidden' }, fetch: mockFetch })).rejects.toMatchObject({ + status: 403 + }); + }); +}); diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts index c5f71a26..38a3d537 100644 --- a/frontend/vite.config.ts +++ b/frontend/vite.config.ts @@ -43,6 +43,16 @@ export default defineConfig({ ], test: { expect: { requireAssertions: true }, + coverage: { + provider: 'v8', + reporter: ['text', 'lcov'], + // Measure utility and server-side logic only — Svelte components + // run in the browser project and are excluded here intentionally. + include: ['src/lib/utils/**', 'src/lib/server/**'], + thresholds: { + branches: 80 + } + }, projects: [ { extends: './vite.config.ts',