marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(fileloader): prevent infinite reload loop via untrack #243

Merged
marcel merged 1 commits from fix/file-loader-reactive-loop into main 2026-04-16 09:09:41 +02:00
Conversation 6 Commits 1 Files Changed 1 +7 -1
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/lib/hooks/useFileLoader.svelte.ts
View File

@@ -1,3 +1,5 @@
import { untrack } from 'svelte';
export function createFileLoader() { export function createFileLoader() {
let fileUrl = $state(''); let fileUrl = $state('');
let isLoading = $state(false); let isLoading = $state(false);
@@ -6,7 +8,11 @@ export function createFileLoader() {
async function loadFile(url: string): Promise<void> { async function loadFile(url: string): Promise<void> {
isLoading = true; isLoading = true;
fileError = ''; fileError = '';
if (fileUrl) URL.revokeObjectURL(fileUrl); // untrack prevents callers ($effect) from accidentally subscribing to fileUrl.
// Without it, the calling effect would re-run every time fileUrl changes (i.e.
// on every successful load), creating an infinite load loop.
const prev = untrack(() => fileUrl);
if (prev) URL.revokeObjectURL(prev);
fileUrl = ''; fileUrl = '';
try { try {