bug: notification deep-link does not scroll to comment on document detail page #299
@@ -291,6 +291,11 @@ $effect(() => {
|
|||||||
|
|
||||||
let navHeight = $state(0);
|
let navHeight = $state(0);
|
||||||
|
|
||||||
|
async function waitForPanelRender(): Promise<void> {
|
||||||
|
await tick();
|
||||||
|
await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
|
||||||
|
}
|
||||||
|
|
||||||
onMount(() => {
|
onMount(() => {
|
||||||
navHeight = document.querySelector('header')?.getBoundingClientRect().height ?? 0;
|
navHeight = document.querySelector('header')?.getBoundingClientRect().height ?? 0;
|
||||||
|
|
||||||
@@ -311,13 +316,10 @@ onMount(() => {
|
|||||||
setTimeout(() => (flashAnnotationId = null), prefersReducedMotion ? 2000 : 1500);
|
setTimeout(() => (flashAnnotationId = null), prefersReducedMotion ? 2000 : 1500);
|
||||||
},
|
},
|
||||||
prefersReducedMotion,
|
prefersReducedMotion,
|
||||||
afterTick: async () => {
|
afterTick: waitForPanelRender,
|
||||||
await tick();
|
|
||||||
await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
|
|
||||||
},
|
|
||||||
getElement: (id) => document.getElementById(id),
|
getElement: (id) => document.getElementById(id),
|
||||||
onStripUrl: () => replaceState(page.url.pathname, page.state)
|
onStripUrl: () => replaceState(page.url.pathname, page.state ?? {})
|
||||||
});
|
}).catch((e) => console.error('deep-link scroll failed', e));
|
||||||
|
|
||||||
function onKeyDown(e: KeyboardEvent) {
|
function onKeyDown(e: KeyboardEvent) {
|
||||||
if (e.key === 'Escape' && transcribeMode) {
|
if (e.key === 'Escape' && transcribeMode) {
|
||||||
|
|||||||
Reference in New Issue
Block a user