marcel/familienarchiv
1
0
Fork 0
Code Issues 102 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(transcription): person @mention sidecar + rename propagation (PR-A backend, #362) #366

Merged
marcel merged 40 commits from feat/person-mentions-issue-362-backend into main 2026-04-28 23:54:40 +02:00
Conversation 32 Commits 40 Files Changed 25 +17 -1
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5ebe1f1a5a - Show all commits

2
backend/src/main/java/org/raddatz/familienarchiv/controller/PersonController.java
View File

@@ -34,11 +34,13 @@ public class PersonController {
private final DocumentService documentService; private final DocumentService documentService;
@GetMapping @GetMapping
@RequirePermission(Permission.READ_ALL)
public ResponseEntity<List<PersonSummaryDTO>> getPersons(@RequestParam(required = false) String q) { public ResponseEntity<List<PersonSummaryDTO>> getPersons(@RequestParam(required = false) String q) {
return ResponseEntity.ok(personService.findAll(q)); return ResponseEntity.ok(personService.findAll(q));
} }
@GetMapping("/{id}") @GetMapping("/{id}")
@RequirePermission(Permission.READ_ALL)
public Person getPerson(@PathVariable UUID id) { public Person getPerson(@PathVariable UUID id) {
return personService.getById(id); return personService.getById(id);
} }

16
backend/src/test/java/org/raddatz/familienarchiv/controller/PersonControllerTest.java
View File

@@ -57,6 +57,13 @@ class PersonControllerTest {
@Test @Test
@WithMockUser @WithMockUser
void getPersons_returns403_whenMissingReadAllPermission() throws Exception {
mockMvc.perform(get("/api/persons"))
.andExpect(status().isForbidden());
}
@Test
@WithMockUser(authorities = "READ_ALL")
void getPersons_returns200_withEmptyList() throws Exception { void getPersons_returns200_withEmptyList() throws Exception {
when(personService.findAll(null)).thenReturn(Collections.emptyList()); when(personService.findAll(null)).thenReturn(Collections.emptyList());
mockMvc.perform(get("/api/persons")) mockMvc.perform(get("/api/persons"))
@@ -64,7 +71,7 @@ class PersonControllerTest {
} }
@Test @Test
@WithMockUser @WithMockUser(authorities = "READ_ALL")
void getPersons_delegatesQueryParam_toService() throws Exception { void getPersons_delegatesQueryParam_toService() throws Exception {
PersonSummaryDTO dto = mockPersonSummary("Hans", "Müller"); PersonSummaryDTO dto = mockPersonSummary("Hans", "Müller");
when(personService.findAll("Hans")).thenReturn(List.of(dto)); when(personService.findAll("Hans")).thenReturn(List.of(dto));
@@ -100,6 +107,13 @@ class PersonControllerTest {
@Test @Test
@WithMockUser @WithMockUser
void getPerson_returns403_whenMissingReadAllPermission() throws Exception {
mockMvc.perform(get("/api/persons/{id}", UUID.randomUUID()))
.andExpect(status().isForbidden());
}
@Test
@WithMockUser(authorities = "READ_ALL")
void getPerson_returns200_whenFound() throws Exception { void getPerson_returns200_whenFound() throws Exception {
UUID id = UUID.randomUUID(); UUID id = UUID.randomUUID();
Person person = Person.builder().id(id).firstName("Anna").lastName("Schmidt").build(); Person person = Person.builder().id(id).firstName("Anna").lastName("Schmidt").build();