marcel/familienarchiv
1
0
Fork 0
Code Issues 103 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat: person @mentions edit-mode infrastructure (PR-B1, #362) #369

Merged
marcel merged 26 commits from feat/person-mentions-issue-362-frontend-b1 into main 2026-04-29 08:05:49 +02:00
Conversation 15 Commits 26 Files Changed 24 +11 -2
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d9c7abf2ab - Show all commits

13
frontend/src/lib/hooks/__tests__/useBlockAutoSave.svelte.test.ts
View File

@@ -72,8 +72,11 @@ describe('createBlockAutoSave', () => {
}); });
it('preserves the in-flight text + mentionedPersons across a save failure (B12)', async () => { it('preserves the in-flight text + mentionedPersons across a save failure (B12)', async () => {
// Hold the second saveFn so we can observe the saving→saved transition
// (Tester #5506 §5).
let resolveSecond!: () => void;
mockSaveFn.mockRejectedValueOnce(new Error('boom')); mockSaveFn.mockRejectedValueOnce(new Error('boom'));
mockSaveFn.mockResolvedValueOnce(undefined); mockSaveFn.mockReturnValueOnce(new Promise<void>((r) => (resolveSecond = r)));
const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' }); const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' });
const mentions: PersonMention[] = [{ personId: 'p-aug', displayName: 'Auguste Raddatz' }]; const mentions: PersonMention[] = [{ personId: 'p-aug', displayName: 'Auguste Raddatz' }];
@@ -82,8 +85,14 @@ describe('createBlockAutoSave', () => {
expect(as.getSaveState('block-1')).toBe('error'); expect(as.getSaveState('block-1')).toBe('error');
// Retry without re-passing the data — the hook resends the preserved payload. // Retry without re-passing the data — the hook resends the preserved payload.
await as.handleRetry('block-1', 'should-not-be-used', []); const retryPromise = as.handleRetry('block-1', 'should-not-be-used', []);
// Yield once so executeSave runs synchronously up to the saveFn await.
await Promise.resolve();
expect(as.getSaveState('block-1')).toBe('saving');
expect(mockSaveFn).toHaveBeenLastCalledWith('block-1', '@Auguste Raddatz hi', mentions); expect(mockSaveFn).toHaveBeenLastCalledWith('block-1', '@Auguste Raddatz hi', mentions);
resolveSecond();
await retryPromise;
expect(as.getSaveState('block-1')).toBe('saved'); expect(as.getSaveState('block-1')).toBe('saved');
}); });