marcel/familienarchiv
1
0
Fork 0
Code Issues 102 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(db): add PRIMARY KEY to group_permissions and promote tbmp UNIQUE to PK (#469) #492

Merged
marcel merged 3 commits from fix/issue-469-group-permissions-pk into main 2026-05-09 15:44:35 +02:00
Conversation 8 Commits 3 Files Changed 6 +18 -3
2 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit eb54a98ea2 - Show all commits

7
backend/src/main/java/org/raddatz/familienarchiv/user/UserService.java
View File

@@ -271,9 +271,10 @@ public class UserService {
@Transactional @Transactional
public UserGroup createGroup(GroupDTO dto) { public UserGroup createGroup(GroupDTO dto) {
UserGroup group = new UserGroup(); UserGroup group = UserGroup.builder()
group.setName(dto.getName()); .name(dto.getName())
group.setPermissions(dto.getPermissions()); .permissions(dto.getPermissions() != null ? dto.getPermissions() : new HashSet<>())
.build();
return groupRepository.save(group); return groupRepository.save(group);
} }

14
backend/src/test/java/org/raddatz/familienarchiv/user/UserServiceTest.java
View File

@@ -902,4 +902,18 @@ class UserServiceTest {
assertThat(result.getName()).isEqualTo("Familie"); assertThat(result.getName()).isEqualTo("Familie");
assertThat(result.getPermissions()).containsExactlyInAnyOrder("READ_ALL", "WRITE_ALL"); assertThat(result.getPermissions()).containsExactlyInAnyOrder("READ_ALL", "WRITE_ALL");
} }
@Test
void createGroup_withNullPermissions_savesGroupWithEmptyPermissionSet() {
org.raddatz.familienarchiv.user.GroupDTO dto = new org.raddatz.familienarchiv.user.GroupDTO();
dto.setName("Leser");
dto.setPermissions(null);
UserGroup saved = UserGroup.builder().id(UUID.randomUUID()).name("Leser").build();
when(groupRepository.save(any())).thenReturn(saved);
userService.createGroup(dto);
verify(groupRepository).save(argThat(g -> g.getPermissions() != null && g.getPermissions().isEmpty()));
}
} }