marcel/familienarchiv
1
0
Fork 0
Code Issues 109 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(#535): eliminate vi.mock(pdfjs-dist) birpc teardown race via libLoader injection #536

Merged
marcel merged 18 commits from feat/issue-535-birpc-teardown-race into main 2026-05-12 09:57:30 +02:00
Conversation 46 Commits 18 Files Changed 6 +14
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b56607ed93 - Show all commits

13
frontend/src/lib/document/viewer/usePdfRenderer.svelte.test.ts
View File

@@ -193,4 +193,17 @@ describe('createPdfRenderer', () => {
await expect(r.init()).rejects.toThrow('load failed'); await expect(r.init()).rejects.toThrow('load failed');
expect(r.pdfjsReady).toBe(false); expect(r.pdfjsReady).toBe(false);
}); });
it('init() is idempotent — libLoader called only once on repeated calls', async () => {
const fakePdfjs = {
GlobalWorkerOptions: { workerSrc: '' },
getDocument: vi.fn(),
TextLayer: class {}
} as unknown as typeof import('pdfjs-dist');
const fakeLoader = vi.fn().mockResolvedValue([fakePdfjs, { default: '' }] as const);
const r = createPdfRenderer(fakeLoader);
await r.init();
await r.init();
expect(fakeLoader).toHaveBeenCalledOnce();
});
}); });

1
frontend/src/lib/document/viewer/usePdfRenderer.svelte.ts
View File

@@ -23,6 +23,7 @@ export function createPdfRenderer(libLoader: LibLoader = defaultLibLoader) {
let pdfjsLib: typeof import('pdfjs-dist') | null = null; let pdfjsLib: typeof import('pdfjs-dist') | null = null;
async function init(): Promise<void> { async function init(): Promise<void> {
if (pdfjsReady) return;
const [lib, { default: workerUrl }] = await libLoader(); const [lib, { default: workerUrl }] = await libLoader();
lib.GlobalWorkerOptions.workerSrc = workerUrl; lib.GlobalWorkerOptions.workerSrc = workerUrl;
pdfjsLib = lib; pdfjsLib = lib;