marcel/familienarchiv
1
0
Fork 0
Code Issues 109 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(notification): replace view-all anchor with button to prevent iframe navigation #552

Merged
marcel merged 5 commits from feat/issue-545-notification-dropdown-iframe-fix into main 2026-05-12 18:56:14 +02:00
Conversation 16 Commits 5 Files Changed 3 +5 -6
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 89860403f6 - Show all commits

1
frontend/src/lib/notification/NotificationDropdown.svelte
View File

@@ -135,7 +135,6 @@ function handleViewAll() {
<div class="border-t border-line px-4 py-2"> <div class="border-t border-line px-4 py-2">
<button <button
type="button" type="button"
role="link"
onclick={handleViewAll} onclick={handleViewAll}
class="min-h-[44px] px-1 text-xs font-medium text-ink-2 transition-colors hover:text-ink" class="min-h-[44px] px-1 text-xs font-medium text-ink-2 transition-colors hover:text-ink"
> >

10
frontend/src/lib/notification/NotificationDropdown.svelte.test.ts
View File

@@ -159,7 +159,7 @@ describe('NotificationDropdown', () => {
expect(onMarkAllRead).toHaveBeenCalledOnce(); expect(onMarkAllRead).toHaveBeenCalledOnce();
}); });
it('calls onClose when the view-all link is clicked', async () => { it('calls onClose when the view-all button is clicked', async () => {
const onClose = vi.fn(); const onClose = vi.fn();
render(NotificationDropdown, { render(NotificationDropdown, {
props: { props: {
@@ -170,12 +170,12 @@ describe('NotificationDropdown', () => {
} }
}); });
await page.getByRole('link', { name: /alle aktivitäten|view all/i }).click(); await page.getByRole('button', { name: /alle aktivitäten|view all/i }).click();
expect(onClose).toHaveBeenCalledOnce(); expect(onClose).toHaveBeenCalledOnce();
}); });
it('navigates to /aktivitaeten when the view-all link is clicked', async () => { it('navigates to /aktivitaeten when the view-all button is clicked', async () => {
render(NotificationDropdown, { render(NotificationDropdown, {
props: { props: {
notifications: [], notifications: [],
@@ -185,7 +185,7 @@ describe('NotificationDropdown', () => {
} }
}); });
await page.getByRole('link', { name: /alle aktivitäten|view all/i }).click(); await page.getByRole('button', { name: /alle aktivitäten|view all/i }).click();
expect(goto).toHaveBeenCalledWith('/aktivitaeten'); expect(goto).toHaveBeenCalledWith('/aktivitaeten');
}); });
@@ -203,7 +203,7 @@ describe('NotificationDropdown', () => {
} }
}); });
await page.getByRole('link', { name: /alle aktivitäten|view all/i }).click(); await page.getByRole('button', { name: /alle aktivitäten|view all/i }).click();
expect(callOrder).toEqual(['close', 'goto']); expect(callOrder).toEqual(['close', 'goto']);
}); });