From fa9577052d73d6a79f44aef05282cdbceec8d8d6 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Fri, 27 Mar 2026 10:04:21 +0100
Subject: [PATCH] =?UTF-8?q?fix(e2e):=20fix=204=20failing=20e2e=20tests=20?=
 =?UTF-8?q?=E2=80=94=20strict=20mode=20locator=20and=20nested=20form?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

documents.spec.ts: replace getByText with getByRole('heading') to avoid
Svelte's #svelte-announcer matching the same text (strict mode violation).

SaveBar.svelte: move <form id="mark-for-review-form"> out of the component
and into +page.svelte as a sibling of delete-form. The form was previously
nested inside <form id="update-form">, which is invalid HTML. The browser
auto-repaired it, causing a Svelte hydration mismatch that broke the edit
form's use:enhance, preventing version snapshots from being recorded —
leaving history tests with 0 versions instead of the expected 2.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 frontend/e2e/documents.spec.ts                         | 2 +-
 frontend/src/routes/documents/[id]/edit/+page.svelte   | 1 +
 frontend/src/routes/documents/[id]/edit/SaveBar.svelte | 3 ---
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/frontend/e2e/documents.spec.ts b/frontend/e2e/documents.spec.ts
index 3f122c29..5fc7fa17 100644
--- a/frontend/e2e/documents.spec.ts
+++ b/frontend/e2e/documents.spec.ts
@@ -167,7 +167,7 @@ test.describe('Document editing', () => {
 		await page.getByRole('button', { name: 'Speichern', exact: true }).click();
 
 		await expect(page).toHaveURL(/\/documents\/[^/]+$/);
-		await expect(page.getByText('E2E Testbrief (überarbeitet)')).toBeVisible();
+		await expect(page.getByRole('heading', { name: 'E2E Testbrief (überarbeitet)' })).toBeVisible();
 		await page.screenshot({ path: 'test-results/e2e/document-edit-save.png' });
 	});
 });
diff --git a/frontend/src/routes/documents/[id]/edit/+page.svelte b/frontend/src/routes/documents/[id]/edit/+page.svelte
index 0adb8955..a8df93d8 100644
--- a/frontend/src/routes/documents/[id]/edit/+page.svelte
+++ b/frontend/src/routes/documents/[id]/edit/+page.svelte
@@ -68,5 +68,6 @@ let selectedReceivers = $state(doc.receivers ?? []);
 		<SaveBar docId={doc.id} />
 	</form>
 
+	<form id="mark-for-review-form" method="POST" action="?/markForReview" use:enhance></form>
 	<form id="delete-form" method="POST" action="?/delete" use:enhance></form>
 </div>
diff --git a/frontend/src/routes/documents/[id]/edit/SaveBar.svelte b/frontend/src/routes/documents/[id]/edit/SaveBar.svelte
index 4520eb76..8550207e 100644
--- a/frontend/src/routes/documents/[id]/edit/SaveBar.svelte
+++ b/frontend/src/routes/documents/[id]/edit/SaveBar.svelte
@@ -1,6 +1,5 @@
 <script lang="ts">
 import { m } from '$lib/paraglide/messages.js';
-import { enhance } from '$app/forms';
 
 let { docId }: { docId: string } = $props();
 
@@ -78,5 +77,3 @@ let confirmDelete = $state(false);
 		</button>
 	</div>
 </div>
-
-<form id="mark-for-review-form" method="POST" action="?/markForReview" use:enhance></form>
-- 
2.49.1