marcel/familienarchiv
1
0
Fork 0
Code Issues 109 Pull Requests Actions Packages Projects Releases Wiki Activity
Files
8558567688d51cabcb9d718c62bb41ce64552128
familienarchiv/docs/architecture/db/db-orm.puml
marcel 8558567688
All checks were successful
CI / Unit & Component Tests (push) Successful in 5m10s
Details
CI / OCR Service Tests (push) Successful in 24s
Details
CI / Backend Unit Tests (push) Successful in 5m14s
Details
CI / fail2ban Regex (push) Successful in 50s
Details
CI / Semgrep Security Scan (push) Successful in 27s
Details
CI / Compose Bucket Idempotency (push) Successful in 1m5s
Details
feat(relationship): editable relationships with LocalDate+DatePrecision dates and notes (#841) 
Closes #837

Makes `PersonRelationship` fully editable (type, related person, dates, notes), migrates its dates from `Integer fromYear/toYear` to `LocalDate + DatePrecision` (mirroring the #773 person pattern, ADR-039 / V76), activates the previously-dead `notes` column, and gives the Zeitstrahl's derived **Heirat** events full date precision for free.

Both Open Decisions confirmed as adopted: **no `@Version`** (last-write-wins, single-writer archive) and **`DELETE` ownership-mismatch aligned 403 → 404** (anti-enumeration, matching the new `PUT`).

## What's in it
- **V78** migrates `person_relationships.from_year/to_year` → `from_date`/`to_date` + NOT-NULL `*_date_precision` (default `UNKNOWN`); pre-check abort on corrupt years, `YYYY-01-01`/`YEAR` backfill, 5 named CHECK constraints, year columns dropped.
- **`PUT /api/persons/{id}/relationships/{relId}`** (`@RequirePermission(WRITE_ALL)`) re-runs every create invariant (self / coherence / order / reverse-PARENT_OF / duplicate) and re-flags family membership; orientation preserved per viewpoint.
- New `ErrorCode.INVALID_RELATIONSHIP_DATES` registered in all four sites (§3.6).
- `TimelineEventService` sources the derived marriage date from `SPOUSE_OF.fromDate` + precision.
- Frontend: `RelationshipDateField` (DAY/MONTH/YEAR), upsert-capable `AddRelationshipForm` (pre-fill + notes + in-flight submit lock), `RelationshipChip` Edit affordance, `updateRelationship` server action, read-view date range + notes, `formatRelationshipDateRange` helper. `api.ts` regenerated.
- Docs: ADR-044, db-orm/db-relationships diagrams, DEPLOYMENT §5 deploy note, RTM REQ-001…REQ-019.

## Requirements
All 19 EARS requirements implemented red/green and marked `Done` in `.specify/rtm.md`.

## Test plan
- **Backend** (targeted, green): `RelationshipMigrationTest` (Testcontainers pg16, 8), `RelationshipServiceTest` (22), `RelationshipControllerTest` (15), `RelationshipServiceIntegrationTest` (real DB, 10), `DerivedEventsAssemblyTest` (17), `ArchitectureTest` (14); `clean package` builds.
- **Frontend** (green): `relationshipDates.spec.ts`, `AddRelationshipForm.svelte.spec.ts`, `RelationshipChip.svelte.spec.ts`, `PersonRelationshipsCard.svelte.test.ts`, `page.server.spec.ts`, `messages.spec.ts`. `npm run check` = 798 (below the ~834 baseline); `npm run lint` clean.

## Notes for reviewers
- **Spec deviation:** the edit form was built by making `AddRelationshipForm` upsert-capable rather than a duplicate `EditRelationshipForm` (DRY); RTM rows reference `AddRelationshipForm.svelte.spec.ts`.
- `api.ts` regenerated from the live spec; only relationship-relevant hunks remain (one springdoc `PageableObject` field-reorder pruned).
- **Deploy:** V78 is one-way and not rolling-deploy-safe — stop old JAR → start new JAR (Flyway runs first); targeted `pg_restore -t person_relationships` for rollback. No maintenance window.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Marcel <marcel@familienarchiv>
Reviewed-on: #841
2026-06-14 21:17:36 +02:00

13 KiB
Raw Blame History

AuthDocumentsPersonsTagsTranscriptionOCRSupportingTimelineapp_usersid : UUID «PK»email : VARCHAR(255) NOT NULL UNIQUEpassword : VARCHAR(255) NOT NULLfirst_name : VARCHAR(100)last_name : VARCHAR(100)birth_date : DATEcontact : TEXTenabled : BOOLEAN NOT NULLcolor : VARCHAR(20) NOT NULLnotify_on_reply : BOOLEAN NOT NULLnotify_on_mention : BOOLEAN NOT NULLcreated_at : TIMESTAMPuser_groupsid : UUID «PK»name : VARCHAR(255) NOT NULL UNIQUEapp_users_groupsapp_user_id : UUID «FK»group_id : UUID «FK»group_permissionsgroup_id : UUID «FK»permission : VARCHAR(255)password_reset_tokensid : UUID «PK»app_user_id : UUID «FK»token : VARCHAR(64) NOT NULL UNIQUEexpires_at : TIMESTAMP NOT NULLused : BOOLEAN NOT NULLcreated_at : TIMESTAMP NOT NULLinvite_tokensid : UUID «PK»code : VARCHAR(10) NOT NULL UNIQUElabel : VARCHAR(255)max_uses : INTEGERuse_count : INTEGER NOT NULLprefill_first_name : VARCHAR(255)prefill_last_name : VARCHAR(255)prefill_email : VARCHAR(255)expires_at : TIMESTAMPcreated_by : UUID «FK»created_at : TIMESTAMP NOT NULLrevoked : BOOLEAN NOT NULLinvite_token_group_idsinvite_token_id : UUID «FK»group_id : UUID «FK»documentsid : UUID «PK»title : VARCHAR(255) NOT NULLoriginal_filename : VARCHAR(255) NOT NULLstatus : VARCHAR(255) NOT NULLfile_path : VARCHAR(255)file_hash : VARCHAR(64)summary : TEXTtranscription : TEXTmeta_date : DATEmeta_date_precision : VARCHAR(16) NOT NULLmeta_date_end : DATEmeta_date_raw : TEXTsender_text : TEXTreceiver_text : TEXTmeta_location : VARCHAR(255)meta_document_location : VARCHAR(255)archive_box : VARCHAR(255)archive_folder : VARCHAR(255)sender_id : UUID «FK»metadata_complete : BOOLEAN NOT NULLscript_type : VARCHAR(30) NOT NULLthumbnail_key : VARCHAR(255)thumbnail_generated_at : TIMESTAMPthumbnail_aspect : VARCHAR(16)page_count : INTEGERsearch_vector : tsvector «computed»created_at : TIMESTAMPupdated_at : TIMESTAMPdocument_receiversdocument_id : UUID «FK»person_id : UUID «FK»document_tagsdocument_id : UUID «FK»tag_id : UUID «FK»document_versionsid : UUID «PK»document_id : UUID «FK»editor_id : UUID «FK»editor_name : VARCHAR(200) NOT NULLsaved_at : TIMESTAMP NOT NULLsnapshot : JSONB NOT NULLchanged_fields : JSONB NOT NULLdocument_annotationsid : UUID «PK»document_id : UUID «FK»page_number : INTEGER NOT NULLx : DOUBLE PRECISION NOT NULLy : DOUBLE PRECISION NOT NULLwidth : DOUBLE PRECISION NOT NULLheight : DOUBLE PRECISION NOT NULLcolor : VARCHAR(20) NOT NULLpolygon : JSONBfile_hash : VARCHAR(64)created_by : UUID «FK»created_at : TIMESTAMP NOT NULLdocument_commentsid : UUID «PK»document_id : UUID «FK»annotation_id : UUID «FK»block_id : UUID «FK»parent_id : UUID «FK»author_id : UUID «FK»author_name : VARCHAR(200) NOT NULLcontent : TEXT NOT NULLcreated_at : TIMESTAMP NOT NULLupdated_at : TIMESTAMP NOT NULLdocument_training_labelsdocument_id : UUID «FK»label : VARCHAR(50) NOT NULLcomment_mentionscomment_id : UUID «FK»app_user_id : UUID «FK»personsid : UUID «PK»first_name : VARCHAR(255)last_name : VARCHAR(255) NOT NULLalias : VARCHAR(255)title : VARCHAR(50)person_type : VARCHAR(20) NOT NULLnotes : TEXTbirth_date : DATEbirth_date_precision : VARCHAR(16) NOT NULLdeath_date : DATEdeath_date_precision : VARCHAR(16) NOT NULLgeneration : SMALLINTfamily_member : BOOLEAN NOT NULLsource_ref : VARCHAR(255) UNIQUEprovisional : BOOLEAN NOT NULLperson_name_aliasesid : UUID «PK»person_id : UUID «FK»last_name : VARCHAR(255) NOT NULLfirst_name : VARCHAR(255)type : VARCHAR(50) NOT NULLsort_order : INTEGER NOT NULLcreated_at : TIMESTAMPTZperson_relationshipsid : UUID «PK»person_id : UUID «FK»related_person_id : UUID «FK»relation_type : VARCHAR(30) NOT NULLfrom_date : DATEfrom_date_precision : VARCHAR(16) NOT NULL DEFAULT 'UNKNOWN'to_date : DATEto_date_precision : VARCHAR(16) NOT NULL DEFAULT 'UNKNOWN'notes : VARCHAR(2000)created_at : TIMESTAMPTZ NOT NULLtagid : UUID «PK»name : VARCHAR(255) NOT NULL UNIQUEparent_id : UUID «FK»color : VARCHAR(20)source_ref : VARCHAR(255) UNIQUEtranscription_blocksid : UUID «PK»annotation_id : UUID «FK»document_id : UUID «FK»text : TEXTlabel : VARCHAR(200)sort_order : INTEGER NOT NULLversion : INTEGER NOT NULLsource : VARCHAR(10) NOT NULLreviewed : BOOLEAN NOT NULLcreated_by : UUID «FK»updated_by : UUID «FK»created_at : TIMESTAMP NOT NULLupdated_at : TIMESTAMP NOT NULLtranscription_block_versionsid : UUID «PK»block_id : UUID «FK»text : TEXT NOT NULLchanged_by : UUID «FK»changed_at : TIMESTAMP NOT NULLtranscription_block_mentioned_personsblock_id : UUID «FK»person_id : UUID NOT NULL «FK»display_name : VARCHAR(200) NOT NULLocr_jobsid : UUID «PK»status : VARCHAR(20) NOT NULLtotal_documents : INT NOT NULLprocessed_documents : INT NOT NULLerror_count : INT NOT NULLskipped_count : INT NOT NULLcreated_by : UUIDprogress_message : TEXTcreated_at : TIMESTAMPTZ NOT NULLupdated_at : TIMESTAMPTZ NOT NULLocr_job_documentsid : UUID «PK»job_id : UUID «FK»document_id : UUID «FK»status : VARCHAR(20) NOT NULLerror_message : TEXTcurrent_page : INTtotal_pages : INTcreated_at : TIMESTAMPTZ NOT NULLupdated_at : TIMESTAMPTZ NOT NULLocr_training_runsid : UUID «PK»status : VARCHAR(20) NOT NULLblock_count : INT NOT NULLdocument_count : INT NOT NULLmodel_name : VARCHAR(100) NOT NULLerror_message : TEXTtriggered_by : UUID «FK»person_id : UUID «FK»cer : DOUBLE PRECISIONloss : DOUBLE PRECISIONaccuracy : DOUBLE PRECISIONepochs : INTcreated_at : TIMESTAMPTZ NOT NULLcompleted_at : TIMESTAMPTZsender_modelsid : UUID «PK»person_id : UUID «FK» UNIQUEmodel_path : TEXT NOT NULLaccuracy : DOUBLE PRECISIONcer : DOUBLE PRECISIONcorrected_lines_at_training : INT NOT NULLcreated_at : TIMESTAMPTZ NOT NULLupdated_at : TIMESTAMPTZ NOT NULLnotificationsid : UUID «PK»recipient_id : UUID «FK»type : VARCHAR(32) NOT NULLdocument_id : UUIDreference_id : UUIDannotation_id : UUIDactor_name : VARCHAR(255)read : BOOLEAN NOT NULLcreated_at : TIMESTAMP NOT NULLaudit_logid : UUID «PK»happened_at : TIMESTAMPTZ NOT NULLactor_id : UUID «FK»kind : VARCHAR(50) NOT NULLdocument_id : UUID «FK»payload : JSONBgeschichtenid : UUID «PK»title : VARCHAR(255) NOT NULLbody : TEXT CHECK (JOURNEY: length <= 4000)status : VARCHAR(32) NOT NULLtype : VARCHAR(32) NOT NULLauthor_id : UUID «FK»created_at : TIMESTAMP NOT NULLupdated_at : TIMESTAMP NOT NULLpublished_at : TIMESTAMPgeschichten_personsgeschichte_id : UUID «FK»person_id : UUID «FK»journey_itemsid : UUID «PK»geschichte_id : UUID «FK»document_id : UUID «FK»position : INTEGER NOT NULL CHECK (position > 0)note : TEXT CHECK (length <= 2000)UNIQUE (geschichte_id, position) DEFERRABLE INITIALLY DEFERREDUNIQUE (geschichte_id, document_id) WHERE document_id IS NOT NULLtimeline_eventsid : UUID «PK»title : VARCHAR(255) NOT NULLtype : VARCHAR(16) NOT NULLevent_date : DATE NOT NULLdate_precision : VARCHAR(16) NOT NULL DEFAULT 'YEAR'event_date_end : DATEdescription : TEXTcreated_by : UUID NOT NULLcreated_at : TIMESTAMPupdated_by : UUID NOT NULLupdated_at : TIMESTAMPversion : BIGINTCHECK ((date_precision = 'RANGE') = (event_date_end IS NOT NULL))CHECK (date_precision <> 'UNKNOWN')timeline_event_personstimeline_event_id : UUID «FK»person_id : UUID «FK»timeline_event_documentstimeline_event_id : UUID «FK»document_id : UUID «FK»app_user_idgroup_idgroup_idapp_user_idcreated_byinvite_token_idgroup_idsender_id (ON DELETE SET NULL)document_idperson_id (ON DELETE CASCADE)document_idtag_iddocument_ideditor_iddocument_idcreated_bydocument_idannotation_idblock_idauthor_idparent_iddocument_idcomment_idapp_user_idperson_idperson_idrelated_person_idparent_idannotation_iddocument_idcreated_byupdated_byblock_idchanged_byblock_idperson_id (ON DELETE CASCADE)job_iddocument_idtriggered_byperson_idperson_idrecipient_idactor_iddocument_idauthor_idgeschichte_idperson_idgeschichte_id (ON DELETE CASCADE)document_id (ON DELETE SET NULL)timeline_event_id (ON DELETE CASCADE)person_id (ON DELETE CASCADE)timeline_event_id (ON DELETE CASCADE)document_id (ON DELETE CASCADE)
Reference in New Issue View Git Blame Copy Permalink