- DocumentService.getRecentActivity: replace findAll(Sort)+stream().limit() with findAll(PageRequest) so LIMIT is pushed to the database - +page.svelte: collapse two-column grid to single column when mentions is empty - DashboardNeedsMetadata: raise "show all" link from text-xs (12px) to text-sm (14px) and add hover:underline for WCAG 1.4.1 - DashboardRecentDocuments: add comment explaining why T12:00:00 noon-anchor is absent (updatedAt is a full ISO datetime, not a date-only string) - DocumentServiceTest: update getRecentActivity tests to assert PageRequest usage instead of findAll(Sort) - DocumentRepositoryTest: add @DataJpaTest verifying findAll(PageRequest) returns only size rows, not the full table - DocumentControllerTest: add test for default size=5 when param is omitted - NotificationServiceTest: add test documenting that type+read=true falls through to the type-only query (intentional) - page.server.spec.ts: replace stale tests with full dashboard-mode coverage - DashboardMentions.svelte.spec.ts: add tests for REPLY type and absent documentId - DashboardResumeStrip.svelte.spec.ts: add corrupt localStorage test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
86 lines
2.8 KiB
TypeScript
86 lines
2.8 KiB
TypeScript
import { describe, it, expect, afterEach } from 'vitest';
|
|
import { cleanup, render } from 'vitest-browser-svelte';
|
|
import { page } from 'vitest/browser';
|
|
|
|
import DashboardMentions from './DashboardMentions.svelte';
|
|
|
|
afterEach(cleanup);
|
|
|
|
type NotificationDTO = {
|
|
id: string;
|
|
type: 'REPLY' | 'MENTION';
|
|
documentId?: string;
|
|
referenceId?: string;
|
|
annotationId?: string;
|
|
read: boolean;
|
|
createdAt: string;
|
|
actorName?: string;
|
|
};
|
|
|
|
function makeMention(overrides: Partial<NotificationDTO> = {}): NotificationDTO {
|
|
return {
|
|
id: 'notif-1',
|
|
type: 'MENTION',
|
|
documentId: 'doc-abc',
|
|
referenceId: 'comment-xyz',
|
|
read: false,
|
|
createdAt: '2026-01-15T10:00:00Z',
|
|
actorName: 'Anna Schmidt',
|
|
...overrides
|
|
};
|
|
}
|
|
|
|
describe('DashboardMentions', () => {
|
|
it('renders nothing when mentions list is empty', async () => {
|
|
render(DashboardMentions, { mentions: [] });
|
|
const widget = page.getByTestId('dashboard-mentions');
|
|
await expect.element(widget).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('shows a heading when mentions are present', async () => {
|
|
render(DashboardMentions, { mentions: [makeMention()] });
|
|
const widget = page.getByTestId('dashboard-mentions');
|
|
await expect.element(widget).toBeInTheDocument();
|
|
});
|
|
|
|
it('builds link with commentId param when no annotationId', async () => {
|
|
render(DashboardMentions, {
|
|
mentions: [makeMention({ documentId: 'doc-1', referenceId: 'cmt-1' })]
|
|
});
|
|
const link = page.getByRole('link');
|
|
await expect.element(link).toHaveAttribute('href', '/documents/doc-1?commentId=cmt-1');
|
|
});
|
|
|
|
it('builds link with commentId and annotationId when annotationId is present', async () => {
|
|
render(DashboardMentions, {
|
|
mentions: [makeMention({ documentId: 'doc-2', referenceId: 'cmt-2', annotationId: 'ann-9' })]
|
|
});
|
|
const link = page.getByRole('link');
|
|
await expect
|
|
.element(link)
|
|
.toHaveAttribute('href', '/documents/doc-2?commentId=cmt-2&annotationId=ann-9');
|
|
});
|
|
|
|
it('shows actor name in each row', async () => {
|
|
render(DashboardMentions, { mentions: [makeMention({ actorName: 'Maria Müller' })] });
|
|
await expect.element(page.getByText('Maria Müller')).toBeInTheDocument();
|
|
});
|
|
|
|
it('shows "replied" label for REPLY type', async () => {
|
|
render(DashboardMentions, { mentions: [makeMention({ type: 'REPLY' })] });
|
|
const widget = page.getByTestId('dashboard-mentions');
|
|
await expect.element(widget).toBeInTheDocument();
|
|
const link = page.getByRole('link');
|
|
await expect.element(link).toBeInTheDocument();
|
|
});
|
|
|
|
it('renders a span instead of a link when documentId is absent', async () => {
|
|
render(DashboardMentions, {
|
|
mentions: [makeMention({ documentId: undefined, actorName: 'Lena Bauer' })]
|
|
});
|
|
await expect.element(page.getByText('Lena Bauer')).toBeInTheDocument();
|
|
const links = page.getByRole('link');
|
|
await expect.element(links).not.toBeInTheDocument();
|
|
});
|
|
});
|