- Remove dead `message` field from both frontend ImportStatus types (field is now @JsonIgnore'd on the backend) - Extract failure message ternary into `$derived` — business logic off the template (Felix) - Add motion-reduce:animate-none to spinner — WCAG 2.1 SC 2.3.3 (Leonie) - Replace text-green-600 with text-green-800 — WCAG AA contrast 6.1:1 on bg-green-50 (Leonie) - Add min-h-[44px] to all three buttons — WCAG 2.2 44px touch target (Leonie) - Add 6 missing tests: IMPORT_FAILED_INTERNAL path, IDLE state text, null importStatus, ontrigger called on DONE/FAILED/IDLE buttons (Sara) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
138 lines
3.9 KiB
TypeScript
138 lines
3.9 KiB
TypeScript
import { describe, it, vi } from 'vitest';
|
|
import { render } from 'vitest-browser-svelte';
|
|
import { expect } from '@vitest/browser/context';
|
|
import ImportStatusCard from './ImportStatusCard.svelte';
|
|
|
|
type ImportStatus = {
|
|
state: 'IDLE' | 'RUNNING' | 'DONE' | 'FAILED';
|
|
statusCode: string;
|
|
processed: number;
|
|
startedAt: string | null;
|
|
};
|
|
|
|
const makeStatus = (overrides: Partial<ImportStatus> = {}): ImportStatus => ({
|
|
state: 'IDLE',
|
|
statusCode: 'IMPORT_IDLE',
|
|
processed: 0,
|
|
startedAt: null,
|
|
...overrides
|
|
});
|
|
|
|
describe('ImportStatusCard', () => {
|
|
it('shows spinner while state is RUNNING', async () => {
|
|
const { getByTestId } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'RUNNING', statusCode: 'IMPORT_RUNNING', processed: 3 }),
|
|
ontrigger: () => {}
|
|
}
|
|
});
|
|
|
|
await expect.element(getByTestId('spinner')).toBeVisible();
|
|
});
|
|
|
|
it('shows processed count at text-base while RUNNING', async () => {
|
|
const { getByText } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'RUNNING', statusCode: 'IMPORT_RUNNING', processed: 7 }),
|
|
ontrigger: () => {}
|
|
}
|
|
});
|
|
|
|
await expect.element(getByText('7')).toBeVisible();
|
|
});
|
|
|
|
it('shows processed count while DONE', async () => {
|
|
const { getByText } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'DONE', statusCode: 'IMPORT_DONE', processed: 42 }),
|
|
ontrigger: () => {}
|
|
}
|
|
});
|
|
|
|
await expect.element(getByText('42')).toBeVisible();
|
|
});
|
|
|
|
it('shows no-spreadsheet message when statusCode is IMPORT_FAILED_NO_SPREADSHEET', async () => {
|
|
const { getByText } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({
|
|
state: 'FAILED',
|
|
statusCode: 'IMPORT_FAILED_NO_SPREADSHEET'
|
|
}),
|
|
ontrigger: () => {}
|
|
}
|
|
});
|
|
|
|
await expect.element(getByText('No spreadsheet file found.')).toBeVisible();
|
|
});
|
|
|
|
it('shows internal error message when statusCode is IMPORT_FAILED_INTERNAL', async () => {
|
|
const { getByText } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'FAILED', statusCode: 'IMPORT_FAILED_INTERNAL' }),
|
|
ontrigger: () => {}
|
|
}
|
|
});
|
|
|
|
await expect.element(getByText('Import failed due to an internal error.')).toBeVisible();
|
|
});
|
|
|
|
it('shows idle text when importStatus is non-null and state is IDLE', async () => {
|
|
const { getByText } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'IDLE', statusCode: 'IMPORT_IDLE' }),
|
|
ontrigger: () => {}
|
|
}
|
|
});
|
|
|
|
await expect.element(getByText('No import started.')).toBeVisible();
|
|
});
|
|
|
|
it('shows no spinner when importStatus is null', async () => {
|
|
render(ImportStatusCard, {
|
|
props: { importStatus: null, ontrigger: () => {} }
|
|
});
|
|
|
|
expect(document.querySelector('[data-testid="spinner"]')).toBeNull();
|
|
});
|
|
|
|
it('calls ontrigger when retry button is clicked in DONE state', async () => {
|
|
const ontrigger = vi.fn();
|
|
const { getByRole } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'DONE', statusCode: 'IMPORT_DONE', processed: 5 }),
|
|
ontrigger
|
|
}
|
|
});
|
|
|
|
await getByRole('button').click();
|
|
expect(ontrigger).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it('calls ontrigger when retry button is clicked in FAILED state', async () => {
|
|
const ontrigger = vi.fn();
|
|
const { getByRole } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'FAILED', statusCode: 'IMPORT_FAILED_INTERNAL' }),
|
|
ontrigger
|
|
}
|
|
});
|
|
|
|
await getByRole('button').click();
|
|
expect(ontrigger).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it('calls ontrigger when start button is clicked in IDLE state', async () => {
|
|
const ontrigger = vi.fn();
|
|
const { getByRole } = render(ImportStatusCard, {
|
|
props: {
|
|
importStatus: makeStatus({ state: 'IDLE', statusCode: 'IMPORT_IDLE' }),
|
|
ontrigger
|
|
}
|
|
});
|
|
|
|
await getByRole('button').click();
|
|
expect(ontrigger).toHaveBeenCalledOnce();
|
|
});
|
|
});
|