Adds a no-restricted-syntax rule scoped to *.spec.ts / *.test.ts that flags any vi.mock call whose first argument starts with 'pdfjs-dist'. Turns the ~2-min CI wait into an immediate lint error on save. Updates ADR 012 Enforcement section to document the rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
172 lines
6.0 KiB
JavaScript
172 lines
6.0 KiB
JavaScript
import prettier from 'eslint-config-prettier';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { includeIgnoreFile } from '@eslint/compat';
|
|
import js from '@eslint/js';
|
|
import svelte from 'eslint-plugin-svelte';
|
|
import boundaries from 'eslint-plugin-boundaries';
|
|
import { defineConfig } from 'eslint/config';
|
|
import globals from 'globals';
|
|
import ts from 'typescript-eslint';
|
|
import svelteConfig from './svelte.config.js';
|
|
|
|
const gitignorePath = fileURLToPath(new URL('./.gitignore', import.meta.url));
|
|
|
|
export default defineConfig(
|
|
includeIgnoreFile(gitignorePath),
|
|
{
|
|
ignores: [
|
|
'src/paraglide/**',
|
|
'.svelte-kit.old/**',
|
|
// Fixture files are intentionally invalid imports used to demonstrate
|
|
// that the boundaries/dependencies rule fires. Exclude them from the
|
|
// regular lint pass so `npm run lint` stays green.
|
|
'src/lib/**/__fixtures__/**'
|
|
]
|
|
},
|
|
js.configs.recommended,
|
|
...ts.configs.recommended,
|
|
...svelte.configs.recommended,
|
|
prettier,
|
|
...svelte.configs.prettier,
|
|
{
|
|
languageOptions: {
|
|
globals: { ...globals.browser, ...globals.node }
|
|
},
|
|
rules: {
|
|
// typescript-eslint strongly recommend that you do not use the no-undef lint rule on TypeScript projects.
|
|
// see: https://typescript-eslint.io/troubleshooting/faqs/eslint/#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
|
|
'no-undef': 'off',
|
|
// This rule is designed for Svelte 5's own routing system using resolve().
|
|
// In SvelteKit, <a href> and goto() from $app/navigation are the correct patterns — resolve() is not needed.
|
|
'svelte/no-navigation-without-resolve': 'off'
|
|
}
|
|
},
|
|
{
|
|
files: ['**/*.svelte', '**/*.svelte.ts', '**/*.svelte.js'],
|
|
languageOptions: {
|
|
parserOptions: {
|
|
projectService: true,
|
|
extraFileExtensions: ['.svelte'],
|
|
parser: ts.parser,
|
|
svelteConfig
|
|
}
|
|
},
|
|
rules: {
|
|
// text-accent resolves to #a1dcd8 in light mode (1.52:1 on white — WCAG fail).
|
|
// layout.css documents it as decorative-only (borders, icon tints, bg fills).
|
|
// For any text label use text-primary or text-ink instead. This rule catches
|
|
// the pattern where text-accent appears inside a JavaScript string literal
|
|
// (e.g. conditional ternary class expressions in Svelte templates).
|
|
'no-restricted-syntax': [
|
|
'error',
|
|
{
|
|
selector: 'Literal[value=/\\btext-accent\\b/]',
|
|
message:
|
|
'text-accent is decorative-only (#a1dcd8 in light mode = 1.52:1 contrast — WCAG fail). Use text-primary or text-ink-2 for text labels.'
|
|
},
|
|
{
|
|
selector: 'TemplateLiteral > TemplateElement[value.raw=/\\btext-accent\\b/]',
|
|
message:
|
|
'text-accent is decorative-only (#a1dcd8 in light mode = 1.52:1 contrast — WCAG fail). Use text-primary or text-ink-2 for text labels.'
|
|
}
|
|
]
|
|
}
|
|
},
|
|
{
|
|
files: ['**/*.spec.ts', '**/*.test.ts'],
|
|
rules: {
|
|
'no-restricted-syntax': [
|
|
'error',
|
|
{
|
|
selector:
|
|
"CallExpression[callee.object.name='vi'][callee.property.name='mock'] > Literal[value=/^pdfjs-dist/]",
|
|
message:
|
|
"Banned: vi.mock('pdfjs-dist', factory) causes a birpc teardown race in browser-mode specs — see ADR 012. Use the libLoader prop injection pattern instead."
|
|
}
|
|
]
|
|
}
|
|
},
|
|
{
|
|
plugins: { boundaries },
|
|
settings: {
|
|
'import/resolver': { typescript: { project: './tsconfig.json' } },
|
|
// $lib/paraglide and $lib/generated are intentionally omitted from the elements list —
|
|
// they are treated as external (third-party-like) by the rule and may be imported
|
|
// from any domain without restriction.
|
|
'boundaries/elements': [
|
|
{ type: 'document', pattern: 'src/lib/document/**' },
|
|
{ type: 'person', pattern: 'src/lib/person/**' },
|
|
{ type: 'tag', pattern: 'src/lib/tag/**' },
|
|
{ type: 'user', pattern: 'src/lib/user/**' },
|
|
{ type: 'geschichte', pattern: 'src/lib/geschichte/**' },
|
|
{ type: 'notification', pattern: 'src/lib/notification/**' },
|
|
{ type: 'ocr', pattern: 'src/lib/ocr/**' },
|
|
{ type: 'activity', pattern: 'src/lib/activity/**' },
|
|
{ type: 'conversation', pattern: 'src/lib/conversation/**' },
|
|
{ type: 'shared', pattern: 'src/lib/shared/**' },
|
|
{ type: 'routes', pattern: 'src/routes/**' }
|
|
]
|
|
},
|
|
rules: {
|
|
'boundaries/dependencies': [
|
|
'error',
|
|
{
|
|
default: 'disallow',
|
|
message:
|
|
"Cross-domain import blocked. Move shared code to $lib/shared/, or expose it via the domain's index.ts.",
|
|
rules: [
|
|
// Document composes person components (D-FE-1) and tag components (D-FE-2),
|
|
// and hosts the OCR trigger in the transcription editor.
|
|
{
|
|
from: { type: 'document' },
|
|
allow: {
|
|
to: { type: ['shared', 'conversation', 'activity', 'person', 'tag', 'ocr'] }
|
|
}
|
|
},
|
|
// Geschichte editor selects persons and documents by design.
|
|
{
|
|
from: { type: 'geschichte' },
|
|
allow: { to: { type: ['shared', 'person', 'document'] } }
|
|
},
|
|
// OCR trigger embeds the document script-type selector.
|
|
{
|
|
from: { type: 'ocr' },
|
|
allow: { to: { type: ['shared', 'document'] } }
|
|
},
|
|
// Activity feed (Chronik) reads notification items for its inbox panel.
|
|
{
|
|
from: { type: 'activity' },
|
|
allow: { to: { type: ['shared', 'notification'] } }
|
|
},
|
|
{ from: { type: 'person' }, allow: { to: { type: ['shared'] } } },
|
|
{ from: { type: 'tag' }, allow: { to: { type: ['shared'] } } },
|
|
{ from: { type: 'user' }, allow: { to: { type: ['shared'] } } },
|
|
{ from: { type: 'notification' }, allow: { to: { type: ['shared'] } } },
|
|
{ from: { type: 'conversation' }, allow: { to: { type: ['shared'] } } },
|
|
{ from: { type: 'shared' }, allow: { to: { type: ['shared'] } } },
|
|
{
|
|
from: { type: 'routes' },
|
|
allow: {
|
|
to: {
|
|
type: [
|
|
'document',
|
|
'person',
|
|
'tag',
|
|
'user',
|
|
'geschichte',
|
|
'notification',
|
|
'ocr',
|
|
'activity',
|
|
'conversation',
|
|
'shared'
|
|
]
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}
|
|
]
|
|
}
|
|
}
|
|
);
|