Files
familienarchiv/frontend/src/lib/person
Marcel 6150fc7be5
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 4m17s
CI / OCR Service Tests (pull_request) Successful in 24s
CI / Backend Unit Tests (pull_request) Successful in 5m23s
CI / fail2ban Regex (pull_request) Successful in 47s
CI / Semgrep Security Scan (pull_request) Successful in 26s
CI / Compose Bucket Idempotency (pull_request) Successful in 1m8s
SDD Gate / RTM Check (pull_request) Successful in 16s
SDD Gate / Contract Validate (pull_request) Successful in 25s
SDD Gate / Constitution Impact (pull_request) Successful in 17s
fix(timeline): track form dirtiness via change callbacks, not an $effect
The round-2 dirty-guard used an $effect that both read and wrote its `dirtyArmed`
$state, so the self-write re-triggered the effect and `dirty` flipped true on
mount — the beforeNavigate confirm then fired on every navigation away from an
untouched form (caught by the round-3 clean-agent review + the Svelte autofixer,
which flags assigning state inside $effect).

Replace it with the component's existing idiomatic pattern: DatePrecisionField,
PersonMultiSelect, and DocumentMultiSelect each gain an optional `onchange`
callback fired on a real user edit, and EventForm passes `markDirty` to all
three. Now date/precision/end-date and picker add/remove mark the form dirty
exactly like title/type/description already did — no effect, no mount-timing
trap. The new props are optional, so the other consumers (WhoWhenSection, the
document forms) are unaffected. Svelte autofixer: clean.

Addresses PR #832 review (round-3 clean-agent concern).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 00:55:34 +02:00
..

person (frontend)

UI for historical family members: typeahead selection, chip display, hover cards, genealogy graph, relationship management.

What this domain owns

Components: PersonTypeahead.svelte, PersonMultiSelect.svelte, PersonChip.svelte, PersonChipRow.svelte, PersonHoverCard.svelte, PersonTypeBadge.svelte, PersonTypeSelector.svelte. Utilities: personFormat.ts (full-name formatting), personLifeDates.ts (birth/death display), person-validation.ts (form validation), personHoverCard.ts (hover-card controller). Sub-folders: genealogy/ (Stammbaum view components), relationship/ (relationship graph components).

What this domain does NOT own

  • Document content — displayed in document/
  • AppUser accounts — managed in user/

Key components

Component Used in Notes
PersonTypeahead.svelte document edit, geschichte, search filters Single-person selector with debounced typeahead. Exported for use by other domains.
PersonMultiSelect.svelte document edit (receivers) Chip-based multi-person selector
PersonChip.svelte document rows, conversation view Compact display chip with link and hover card
PersonHoverCard.svelte person chips Floating card with person summary on hover

Cross-domain imports

  • shared/primitives/ — generic UI primitives
  • shared/hooks/useTypeahead.svelte.ts — typeahead keyboard/focus logic

Accessibility notes

  • PersonChip focus ring: focus-visible:ring-2 focus-visible:ring-brand-navy
  • PersonTypeahead dropdown navigable via keyboard (↑↓ Enter Escape)

Backend counterpart

backend/src/main/java/org/raddatz/familienarchiv/person/README.md