marcel/mealprep
1
0
Fork 0
Code Issues 22 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(planner): show yellow neutral badge for scoreDelta = 0 in RecipePicker

Browse Source 
Neutral suggestions (no variety impact) now show "= 0.0 Punkte" in yellow
instead of no badge, making the three states explicit: green (improves),
yellow (neutral), red (worsens).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel Raddatz
2026-04-09 12:54:31 +02:00
committed by marcel
parent bf18f2bd84
commit 055ae11fa3
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/lib/planner/RecipePicker.svelte
View File

@@ -120,6 +120,14 @@
> >
↓ {(suggestion.scoreDelta ?? 0).toFixed(1)} Punkte ↓ {(suggestion.scoreDelta ?? 0).toFixed(1)} Punkte
</span> </span>
{:else}
<span
data-testid="badge-{suggestion.recipe.id}"
data-type="neutral"
style="display: inline-block; margin-top: 3px; font-size: 9px; font-weight: 500; padding: 1px 5px; border-radius: 3px; background: var(--yellow-tint); color: var(--yellow-text);"
>
= {(suggestion.scoreDelta ?? 0).toFixed(1)} Punkte
</span>
{/if} {/if}
</div> </div>
<button <button

6
frontend/src/lib/planner/RecipePicker.test.ts
View File

@@ -99,12 +99,14 @@ describe('RecipePicker', () => {
expect(screen.getByText(/Keine Treffer/i)).toBeTruthy(); expect(screen.getByText(/Keine Treffer/i)).toBeTruthy();
}); });
it('shows no badge when scoreDelta is zero (neutral, no improvement)', () => { it('shows yellow neutral badge when scoreDelta is zero', () => {
const neutralSuggestions = [ const neutralSuggestions = [
{ recipe: { id: 'sn', name: 'Neutrales Rezept', effort: 'easy', cookTimeMin: 20 }, scoreDelta: 0.0, hasConflict: false } { recipe: { id: 'sn', name: 'Neutrales Rezept', effort: 'easy', cookTimeMin: 20 }, scoreDelta: 0.0, hasConflict: false }
]; ];
render(RecipePicker, { props: { ...baseProps, suggestions: neutralSuggestions } }); render(RecipePicker, { props: { ...baseProps, suggestions: neutralSuggestions } });
expect(screen.queryByTestId('badge-sn')).toBeNull(); const badge = screen.getByTestId('badge-sn');
expect(badge.getAttribute('data-type')).toBe('neutral');
expect(badge.textContent).toContain('0.0');
}); });
it('shows loading skeleton instead of Empfohlen section when isLoading is true', () => { it('shows loading skeleton instead of Empfohlen section when isLoading is true', () => {