marcel/mealprep
1
0
Fork 0
Code Issues 22 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(staples): forward backend error status code instead of always 500

Browse Source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel Raddatz
2026-04-03 09:25:06 +02:00
parent 21b873b85b
commit 3581af2bf9
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/routes/household/staples/+server.ts
View File

@@ -21,7 +21,8 @@ export const PATCH: RequestHandler = async ({ request, fetch }) => {
}); });
if (error) { if (error) {
return json({ error: 'Failed to update ingredient' }, { status: 500 }); const status = (error as { status?: number }).status ?? 500;
return json({ error: 'Failed to update ingredient' }, { status });
} }
return new Response(null, { status: 204 }); return new Response(null, { status: 204 });

10
frontend/src/routes/household/staples/server.test.ts
View File

@@ -46,7 +46,7 @@ describe('household staples PATCH handler', () => {
expect(response.status).toBe(204); expect(response.status).toBe(204);
}); });
it('returns 500 when backend returns an error', async () => { it('returns 500 when backend returns a 500 error', async () => {
mockPatch.mockResolvedValue({ data: undefined, error: { status: 500, message: 'error' } }); mockPatch.mockResolvedValue({ data: undefined, error: { status: 500, message: 'error' } });
const response = await PATCH(createRequest({ id: 'ing-1', isStaple: false })); const response = await PATCH(createRequest({ id: 'ing-1', isStaple: false }));
@@ -54,6 +54,14 @@ describe('household staples PATCH handler', () => {
expect(response.status).toBe(500); expect(response.status).toBe(500);
}); });
it('forwards backend 404 status when ingredient not found', async () => {
mockPatch.mockResolvedValue({ data: undefined, error: { status: 404 } });
const response = await PATCH(createRequest({ id: 'ing-1', isStaple: false }));
expect(response.status).toBe(404);
});
it('returns 400 when id is missing', async () => { it('returns 400 when id is missing', async () => {
const response = await PATCH(createRequest({ isStaple: true })); const response = await PATCH(createRequest({ isStaple: true }));