From e5614ccf30a64a7f102b8c0d1e2626d209fd38b4 Mon Sep 17 00:00:00 2001
From: Marcel Raddatz <marcel@raddatz.cloud>
Date: Thu, 2 Apr 2026 19:28:46 +0200
Subject: [PATCH] refactor(onboarding): remove aria-hidden workaround from
 progress sidebar

Replace getByText with getByRole(heading) in page test to disambiguate
the duplicate "Haushalt benennen" text between sidebar and form.
Revert defaultIgnore change in test-setup.ts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 frontend/src/routes/household/setup/+page.svelte | 1 -
 frontend/src/routes/household/setup/page.test.ts | 2 +-
 frontend/src/test-setup.ts                       | 6 ------
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/frontend/src/routes/household/setup/+page.svelte b/frontend/src/routes/household/setup/+page.svelte
index 8e24d8b..8048d8c 100644
--- a/frontend/src/routes/household/setup/+page.svelte
+++ b/frontend/src/routes/household/setup/+page.svelte
@@ -18,7 +18,6 @@
 	<!-- Desktop progress sidebar — hidden on mobile -->
 	<aside
 		class="hidden md:flex w-[300px] flex-shrink-0 flex-col bg-[var(--color-surface)] border-r border-[var(--color-border)] p-[40px_28px]"
-		aria-hidden="true"
 	>
 		<ProgressSidebar currentStep={1} />
 	</aside>
diff --git a/frontend/src/routes/household/setup/page.test.ts b/frontend/src/routes/household/setup/page.test.ts
index ef01078..ff818b1 100644
--- a/frontend/src/routes/household/setup/page.test.ts
+++ b/frontend/src/routes/household/setup/page.test.ts
@@ -9,7 +9,7 @@ vi.mock('$app/forms', () => ({
 describe('household setup page', () => {
 	it('renders the form heading', () => {
 		render(Page);
-		expect(screen.getByText('Haushalt benennen')).toBeInTheDocument();
+		expect(screen.getByRole('heading', { name: 'Haushalt benennen' })).toBeInTheDocument();
 	});
 
 	it('renders the household name input', () => {
diff --git a/frontend/src/test-setup.ts b/frontend/src/test-setup.ts
index 41b13c7..bb02c60 100644
--- a/frontend/src/test-setup.ts
+++ b/frontend/src/test-setup.ts
@@ -1,7 +1 @@
 import '@testing-library/jest-dom/vitest';
-import { configure } from '@testing-library/dom';
-
-// Exclude elements inside aria-hidden containers from text queries,
-// so that visually-hidden sidebars (e.g. ProgressSidebar in onboarding pages)
-// don't create duplicate text matches when the same text appears in the main content.
-configure({ defaultIgnore: 'script, style, [aria-hidden="true"] *' });