backend/src/main/java/com/recipeapp/planning/PlanningService.java

@@ -26,6 +26,8 @@ import java.util.stream.Collectors;
 @Service
 public class PlanningService {
 
+    private static final double MAX_VARIETY_SCORE = 10.0;
+
     private final WeekPlanRepository weekPlanRepository;
     private final WeekPlanSlotRepository weekPlanSlotRepository;
     private final CookingLogRepository cookingLogRepository;
@@ -138,7 +140,7 @@ public class PlanningService {
         List<SimulatedSlot> currentSlots = plan.getSlots().stream()
                 .map(s -> new SimulatedSlot(s.getRecipe(), s.getSlotDate()))
                 .toList();
-        double currentScore = currentSlots.isEmpty() ? 10.0
+        double currentScore = currentSlots.isEmpty() ? MAX_VARIETY_SCORE
                 : scoreFromSimulatedSlots(currentSlots, config, recentlyCookedIds);
 
         List<Recipe> allRecipes = recipeRepository.findByHouseholdIdAndDeletedAtIsNull(householdId);
@@ -202,7 +204,7 @@ public class PlanningService {
         List<SimulatedSlot> currentSlots = plan.getSlots().stream()
                 .map(s -> new SimulatedSlot(s.getRecipe(), s.getSlotDate()))
                 .toList();
-        double currentScore = currentSlots.isEmpty() ? 10.0
+        double currentScore = currentSlots.isEmpty() ? MAX_VARIETY_SCORE
                 : scoreFromSimulatedSlots(currentSlots, config, recentlyCookedIds);
         double projectedScore = simulateVarietyScore(plan, candidate, date, config, recentlyCookedIds);
 
@@ -255,12 +257,12 @@ public class PlanningService {
                 .mapToLong(c -> c - 1)
                 .sum();
 
-        double score = 10.0;
+        double score = MAX_VARIETY_SCORE;
         score -= tagRepeatCount * wTagRepeat;
         score -= ingredientOverlapCount * wIngredientOverlap;
         score -= recentRepeatCount * wRecentRepeat;
         score -= duplicatePenaltyCount * wPlanDuplicate;
-        return Math.max(0, Math.min(10, score));
+        return Math.max(0, Math.min(MAX_VARIETY_SCORE, score));
     }
 
     @Transactional(readOnly = true)
@@ -349,12 +351,12 @@ public class PlanningService {
         }
 
         // Calculate score
-        double score = 10.0;
+        double score = MAX_VARIETY_SCORE;
         score -= tagRepeats.size() * wTagRepeat;
         score -= overlaps.size() * wIngredientOverlap;
         score -= recentRepeats.size() * wRecentRepeat;
         score -= duplicatePenaltyCount * wPlanDuplicate;
-        score = Math.max(0, Math.min(10, score));
+        score = Math.max(0, Math.min(MAX_VARIETY_SCORE, score));
 
         return new VarietyScoreResponse(score, tagRepeats, overlaps, recentRepeats, duplicatesInPlan);
     }