Marcel Raddatz
6505cb4251
- Add try-catch around JSON.parse with fail(400) for malformed input - Validate effort against allowed values ['Easy','Medium','Hard'] - Fix NaN risk: Number(serves)||undefined instead of Number(serves) - Add action tests for create/update: validation, JSON.parse crash, success, API error Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
71 lines
2.4 KiB
TypeScript
71 lines
2.4 KiB
TypeScript
import { redirect, fail } from '@sveltejs/kit';
|
|
import type { PageServerLoad, Actions } from './$types';
|
|
import { apiClient } from '$lib/server/api';
|
|
|
|
const VALID_EFFORTS = ['Easy', 'Medium', 'Hard'];
|
|
|
|
export const load: PageServerLoad = async ({ fetch }) => {
|
|
const api = apiClient(fetch);
|
|
const { data, error } = await api.GET('/v1/tags', {});
|
|
|
|
const allTags = error || !data ? [] : data;
|
|
const categories = allTags
|
|
.filter((t) => t.tagType === 'category')
|
|
.map((t) => ({ id: t.id!, name: t.name!, tagType: t.tagType }));
|
|
|
|
return { recipe: null, categories };
|
|
};
|
|
|
|
export const actions: Actions = {
|
|
create: async ({ request, fetch }) => {
|
|
const formData = await request.formData();
|
|
const name = formData.get('name') as string;
|
|
const serves = formData.get('serves');
|
|
const cookTimeMin = formData.get('cookTimeMin');
|
|
const effort = formData.get('effort') as string;
|
|
const ingredientsJson = formData.get('ingredientsJson') as string;
|
|
const stepsJson = formData.get('stepsJson') as string;
|
|
const tagIds = formData.getAll('tagIds') as string[];
|
|
|
|
if (!name?.trim()) return fail(422, { error: 'Name ist erforderlich' });
|
|
if (!effort || !VALID_EFFORTS.includes(effort))
|
|
return fail(422, { error: 'Ungültiger Schwierigkeitsgrad' });
|
|
if (!tagIds.length) return fail(422, { error: 'Mindestens eine Kategorie ist erforderlich' });
|
|
|
|
let parsedIngredients: unknown[];
|
|
let parsedSteps: unknown[];
|
|
try {
|
|
parsedIngredients = JSON.parse(ingredientsJson || '[]');
|
|
parsedSteps = JSON.parse(stepsJson || '[]');
|
|
} catch {
|
|
return fail(400, { error: 'Ungültige Formulardaten' });
|
|
}
|
|
|
|
const api = apiClient(fetch);
|
|
const { error: apiError } = await api.POST('/v1/recipes', {
|
|
body: {
|
|
name: name.trim(),
|
|
serves: serves ? Number(serves) || undefined : undefined,
|
|
cookTimeMin: cookTimeMin ? Number(cookTimeMin) || undefined : undefined,
|
|
effort,
|
|
ingredients: (parsedIngredients as { name: string; quantity: string; unit: string }[])
|
|
.filter((ing) => ing.name?.trim())
|
|
.map((ing, i) => ({
|
|
newIngredientName: ing.name.trim(),
|
|
quantity: Number(ing.quantity) || 0,
|
|
unit: ing.unit || '',
|
|
sortOrder: i
|
|
})),
|
|
steps: (parsedSteps as string[])
|
|
.filter((s) => s?.trim())
|
|
.map((s, i) => ({ stepNumber: i + 1, instruction: s.trim() })),
|
|
tagIds
|
|
}
|
|
});
|
|
|
|
if (apiError) return fail(500, { error: 'Fehler beim Speichern' });
|
|
|
|
redirect(303, '/recipes');
|
|
}
|
|
};
|