marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel opened issue marcel/familienarchiv#387 2026-05-04 16:01:18 +02:00
epic(legibility): audit — assess current state of every subsystem
marcel deleted branch feat/issue-370-at-mention-placeholder-hint from marcel/familienarchiv 2026-05-04 15:35:11 +02:00
marcel closed issue marcel/familienarchiv#370 2026-05-04 15:35:10 +02:00
feat(person-mention): discoverability hint for the @ trigger in the editor
marcel pushed to main at marcel/familienarchiv 2026-05-04 15:35:09 +02:00
d4f666e981 test(person-mention): move i18n test to its own describe block
678d9dab38 refactor(training): extract kurrentLabels helper + clarify query comments
42cf078bb6 feat(person-mention): update transcription placeholder with @mention discoverability hint
Compare 3 commits »
marcel merged pull request marcel/familienarchiv#379 2026-05-04 15:35:09 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder
d4f666e981 test(person-mention): move i18n test to its own describe block
678d9dab38 refactor(training): extract kurrentLabels helper + clarify query comments
42cf078bb6 feat(person-mention): update transcription placeholder with @mention discoverability hint
32e4e30e40 test(training): strengthen TrainingBlockQueryTest assertions
dd9c4d57ee fix(training): use KURRENT_RECOGNITION label for sender-based block queries
Compare 35 commits »
marcel deleted branch fix/sender-training-use-kurrent-label from marcel/familienarchiv 2026-05-04 15:26:09 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-04 15:26:06 +02:00
32e4e30e40 test(training): strengthen TrainingBlockQueryTest assertions
dd9c4d57ee fix(training): use KURRENT_RECOGNITION label for sender-based block queries
Compare 2 commits »
marcel merged pull request marcel/familienarchiv#378 2026-05-04 15:26:06 +02:00
fix(training): use KURRENT_RECOGNITION label for sender-based block queries
8c7f3b2e4e test(person-mention): move i18n test to its own describe block
52178c2f5b refactor(training): extract kurrentLabels helper + clarify query comments
Compare 2 commits »
marcel pushed to fix/sender-training-use-kurrent-label at marcel/familienarchiv 2026-05-04 15:13:21 +02:00
6399321d0e test(training): strengthen TrainingBlockQueryTest assertions
marcel commented on pull request marcel/familienarchiv#379 2026-05-04 15:07:28 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

Copy quality

The new placeholder text is excellent from a UX perspective:

  • DE: `Text eingeben…
marcel commented on pull request marcel/familienarchiv#379 2026-05-04 15:07:17 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder

📋 Elicit — Requirements Engineer

Verdict: ⚠️ Approved with concerns

Requirements traceability

The PR closes #370. The stated requirement: teach users that @Name triggers…

marcel commented on pull request marcel/familienarchiv#379 2026-05-04 15:07:11 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

No infrastructure files changed. No Docker Compose modifications. No CI workflow changes. No…

marcel commented on pull request marcel/familienarchiv#379 2026-05-04 15:07:05 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

Frontend Test (new)

it('transcription_block_placeholder contains @ mention…
marcel commented on pull request marcel/familienarchiv#379 2026-05-04 15:06:42 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I checked

Frontend i18n change: No security surface. Updating placeholder text introduces…

marcel commented on pull request marcel/familienarchiv#378 2026-05-04 15:06:40 +02:00
fix(training): use KURRENT_RECOGNITION label for sender-based block queries

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

The PR description accurately describes both the root cause and the fix. The requirements alignment is solid.

What I…

marcel commented on pull request marcel/familienarchiv#378 2026-05-04 15:06:33 +02:00
fix(training): use KURRENT_RECOGNITION label for sender-based block queries

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ✅ Approved

This PR is a backend repository fix with no frontend, UI, or UX changes. No design review concerns.

What I checked

  • No…
marcel commented on pull request marcel/familienarchiv#379 2026-05-04 15:06:32 +02:00
feat(person-mention): add @mention discoverability hint to transcription block placeholder

🏗️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

Overview

Two completely unrelated changes are bundled in one PR:

  1. A frontend i18n copy change…
marcel commented on pull request marcel/familienarchiv#378 2026-05-04 15:06:28 +02:00
fix(training): use KURRENT_RECOGNITION label for sender-based block queries

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure or CI changes in this PR. This is a backend Java fix with test coverage — nothing for me to flag…