• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#174 2026-04-01 22:13:11 +02:00
feat(topbar): responsive DocumentTopBar — issue #173

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

What I checked

TDD evidence, naming, function size, Svelte 5 rules (keyed {#each}, $derived vs…

marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:24:14 +02:00
e94f43264c fix(topbar): add overflow-hidden to flex row so long titles truncate instead of pushing kebab off-screen
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:22:43 +02:00
da7f94de84 feat(topbar): hide sender→receiver chip row below md to make room for buttons
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:17:17 +02:00
3f0b686963 feat(topbar): always show annotate-stop button — primary action, not hidden in kebab
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:16:07 +02:00
1e9ef63191 refactor(topbar): extract annotate/download actions as Svelte snippets, render in desktop + kebab
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:12:27 +02:00
51348ad26a feat(topbar): add mobile kebab menu for annotate/download actions hidden below md
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:05:36 +02:00
dba1e2a8eb fix(topbar): use Long-Arrow-Right icon for sender→receiver separator
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 10:00:19 +02:00
654b1283c1 fix(topbar): replace → text char with degruyter arrow icon for reliable centering
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:47:18 +02:00
c5b98af69b fix(topbar): center arrow glyph vertically with inline-flex items-center
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:38:20 +02:00
03e2382c8a feat(topbar): increase arrow to 30px and fix vertical alignment with leading-none
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:36:11 +02:00
528e1e05ea feat(topbar): increase sender→receiver arrow size for visibility
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:30:56 +02:00
c64abccf63 feat(i18n): add doc_panel_annotate_hint message key in de/en/es, use in AnnotateHintStrip
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:24:07 +02:00
47960b5028 feat(topbar): scale action button text and icons to match surrounding text size
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:13:06 +02:00
7f2940f0f2 feat(topbar): increase all font sizes and bar height by another 25%
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:10:36 +02:00
37d728b006 feat(topbar): increase all font sizes and bar height by 25% for legibility
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 09:04:31 +02:00
965087b787 Revert "feat(topbar): double all font sizes and increase bar height for legibility"
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 08:53:02 +02:00
1d2e6d7b86 feat(topbar): double all font sizes and increase bar height for legibility
marcel created pull request marcel/familienarchiv#174 2026-04-01 08:46:09 +02:00
feat(topbar): responsive DocumentTopBar — issue #173
marcel pushed to feat/issue-173-document-topbar at marcel/familienarchiv 2026-04-01 08:44:47 +02:00
0c40e10743 fix(topbar): add role=group to OverflowPillButton outer div — a11y warning
358131ca34 feat(ui): replace DocumentTopBar with responsive orchestrator (issue #173)
c7af33b998 feat(ui): add OverflowPillButton — tooltip, Escape focus return, use:clickOutside
eafb566170 feat(ui): add PersonChipRow — sender→receivers chips, 2nd receiver hidden md:contents
624eb9e5d6 feat(ui): add OverflowPillDisplay — non-interactive aria-hidden +N span
Compare 10 commits »
marcel created branch feat/issue-173-document-topbar in marcel/familienarchiv 2026-04-01 08:44:44 +02:00