fix(ocr): handle empty-string HTRMOPO_DIR env var with or-fallback

os.environ.get(key, default) returns "" when the key exists but is blank —
the default is only used when the key is absent. The or-fallback treats both
absence and blank values as "use the default".

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-17 18:53:26 +02:00
parent 7769dbc9f4
commit bead6f1811
2 changed files with 10 additions and 1 deletions

View File

@@ -24,7 +24,7 @@ log = logging.getLogger(__name__)
BLLA_MODEL_PATH = os.environ.get("BLLA_MODEL_PATH", "/app/models/blla.mlmodel")
# DOI for "General segmentation model for print and handwriting" — ketos 7 compatible.
BLLA_MODEL_DOI = "10.5281/zenodo.14602569"
HTRMOPO_DIR = os.environ.get("HTRMOPO_DIR", "/app/models/.htrmopo")
HTRMOPO_DIR = os.environ.get("HTRMOPO_DIR") or "/app/models/.htrmopo"
def _model_is_loadable(path: str) -> bool:

View File

@@ -29,6 +29,15 @@ def test_htrmopo_dir_default_is_fixed_path():
assert result == "/app/models/.htrmopo"
def test_htrmopo_dir_falls_back_to_default_when_set_to_empty_string():
"""HTRMOPO_DIR='' must not produce an empty path — get() returns '' for blank env vars."""
with patch.dict(os.environ, {"HTRMOPO_DIR": ""}):
importlib.reload(ensure_blla_model)
result = ensure_blla_model.HTRMOPO_DIR
importlib.reload(ensure_blla_model)
assert result != ""
# ─── Model already loadable ───────────────────────────────────────────────────