marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(e2e+i18n): add missing DE translation, fix E2E test selectors
Some checks failed
CI / Unit & Component Tests (push) Has been cancelled
Details
CI / Backend Unit Tests (push) Has been cancelled
Details
CI / E2E Tests (push) Has been cancelled
Details

Browse Source 
- Add missing person_btn_conversations translation to de.json
- Fix birth/death year test: exclude /persons/new link + wait for hydration
- Fix lang test switching back to DE: wait for hydration + clear locale cookie
  (headless Chromium doesn't reliably delete cookies via document.cookie)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-03-19 22:45:56 +01:00
parent 6e6663376d
commit c3f487f16c
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/e2e/lang.spec.ts
View File

@@ -28,7 +28,13 @@ test.describe('Language selector', () => {
await page.goto('/'); await page.goto('/');
await page.waitForSelector('[data-hydrated]'); await page.waitForSelector('[data-hydrated]');
await page.getByRole('banner').getByRole('button', { name: 'EN', exact: true }).click(); await page.getByRole('banner').getByRole('button', { name: 'EN', exact: true }).click();
await expect(page.getByRole('navigation').getByRole('link', { name: 'Documents' })).toBeVisible();
await page.getByRole('banner').getByRole('button', { name: 'DE', exact: true }).click(); await page.getByRole('banner').getByRole('button', { name: 'DE', exact: true }).click();
// In headless Chromium, cookie deletion via document.cookie can be unreliable.
// Delete the PARAGLIDE_LOCALE cookie directly so the next navigation defaults to DE.
await page.context().clearCookies({ name: 'PARAGLIDE_LOCALE' });
await page.goto('/');
await page.waitForSelector('[data-hydrated]');
await expect(page.getByRole('navigation').getByRole('link', { name: 'Dokumente' })).toBeVisible(); await expect(page.getByRole('navigation').getByRole('link', { name: 'Dokumente' })).toBeVisible();
}); });

3
frontend/e2e/persons.spec.ts
View File

@@ -55,8 +55,9 @@ test.describe('Person detail', () => {
test('birth and death year fields appear in edit mode and save correctly', async ({ page }) => { test('birth and death year fields appear in edit mode and save correctly', async ({ page }) => {
await page.goto('/persons'); await page.goto('/persons');
const firstPerson = page.locator('a[href^="/persons/"]').first(); const firstPerson = page.locator('a[href^="/persons/"]:not([href="/persons/new"])').first();
await firstPerson.click(); await firstPerson.click();
await page.waitForSelector('[data-hydrated]');
const editBtn = page.getByRole('button', { name: /Bearbeiten/i }); const editBtn = page.getByRole('button', { name: /Bearbeiten/i });
await editBtn.click(); await editBtn.click();

3
frontend/messages/de.json
View File

@@ -182,5 +182,6 @@
"comp_taginput_placeholder_create": "Schlagworte hinzufügen...", "comp_taginput_placeholder_create": "Schlagworte hinzufügen...",
"comp_taginput_placeholder_filter": "Nach Schlagworten filtern...", "comp_taginput_placeholder_filter": "Nach Schlagworten filtern...",
"comp_taginput_remove": "Schlagwort entfernen", "comp_taginput_remove": "Schlagwort entfernen",
"comp_taginput_create_hint": "Enter drücken um Schlagwort zu erstellen." "comp_taginput_create_hint": "Enter drücken um Schlagwort zu erstellen.",
"person_btn_conversations": "Konversationen anzeigen"
} }