refactor(#240): remove needsExpert feature completely

Drops the needsExpert / needs_expert flag end-to-end: DB migration (V37, never applied), Document entity field, PATCH endpoint, service method, DTO field, all three queue queries, ExpertBadge component, i18n key, generated API types, and test fixture. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-16 10:52:14 +02:00
parent 9fb1821db5
commit ca0cf4903c
17 changed files with 13 additions and 91 deletions
--- a/backend/src/main/java/org/raddatz/familienarchiv/controller/DocumentController.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/controller/DocumentController.java
@@ -211,14 +211,6 @@ public class DocumentController {
        return ResponseEntity.ok(documentService.searchDocuments(q, from, to, senderId, receiverId, tags, tagQ, status, sort, dir));
    }

-    // --- EXPERT FLAG ---
-
-    @PatchMapping("/{id}/needs-expert")
-    @RequirePermission(Permission.WRITE_ALL)
-    public Document toggleNeedsExpert(@PathVariable UUID id) {
-        return documentService.toggleNeedsExpert(id);
-    }
-
    // --- TRAINING LABELS ---

    public record TrainingLabelRequest(String label, boolean enrolled) {}
--- a/backend/src/main/java/org/raddatz/familienarchiv/dto/TranscriptionQueueItemDTO.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/dto/TranscriptionQueueItemDTO.java
@@ -12,7 +12,6 @@ public record TranscriptionQueueItemDTO(
        UUID id,
        String title,
        LocalDate documentDate,
-        boolean needsExpert,
        int annotationCount,
        int textedBlockCount,
        int reviewedBlockCount
--- a/backend/src/main/java/org/raddatz/familienarchiv/model/Document.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/model/Document.java
@@ -97,11 +97,6 @@ public class Document {
    @Builder.Default
    private ScriptType scriptType = ScriptType.UNKNOWN;

-    @Column(name = "needs_expert", nullable = false)
-    @Schema(requiredMode = Schema.RequiredMode.REQUIRED)
-    @Builder.Default
-    private boolean needsExpert = false;
-
    @ManyToMany(fetch = FetchType.EAGER)
    @JoinTable(name = "document_receivers", joinColumns = @JoinColumn(name = "document_id"), inverseJoinColumns = @JoinColumn(name = "person_id"))
    @Builder.Default
--- a/backend/src/main/java/org/raddatz/familienarchiv/repository/DocumentRepository.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/repository/DocumentRepository.java
@@ -171,27 +171,26 @@ public interface DocumentRepository extends JpaRepository<Document, UUID>, JpaSp

    /** Documents with no annotations — Segmentierung column. */
    @Query(nativeQuery = true, value = """
-            SELECT d.id, d.title, d.meta_date AS documentDate, d.needs_expert AS needsExpert,
+            SELECT d.id, d.title, d.meta_date AS documentDate,
                   0 AS annotationCount, 0 AS textedBlockCount, 0 AS reviewedBlockCount
            FROM documents d
            WHERE d.status NOT IN ('PLACEHOLDER')
              AND NOT EXISTS (SELECT 1 FROM document_annotations da WHERE da.document_id = d.id)
-            ORDER BY d.needs_expert ASC,
-                     HASHTEXT(d.id::text || EXTRACT(WEEK FROM NOW())::int::text)
+            ORDER BY HASHTEXT(d.id::text || EXTRACT(WEEK FROM NOW())::int::text)
            LIMIT :limit
            """)
    List<Object[]> findSegmentationQueue(@Param("limit") int limit);

    /** Documents with annotations but not yet fully reviewed — Transkription column. */
    @Query(nativeQuery = true, value = """
-            SELECT d.id, d.title, d.meta_date AS documentDate, d.needs_expert AS needsExpert,
+            SELECT d.id, d.title, d.meta_date AS documentDate,
                   COUNT(DISTINCT da.id)                                                             AS annotationCount,
                   COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END)   AS textedBlockCount,
                   COUNT(DISTINCT CASE WHEN tb.reviewed = true THEN tb.id END)                      AS reviewedBlockCount
            FROM documents d
            JOIN document_annotations da ON da.document_id = d.id
            LEFT JOIN transcription_blocks tb ON tb.document_id = d.id
-            GROUP BY d.id, d.title, d.meta_date, d.needs_expert
+            GROUP BY d.id, d.title, d.meta_date
            HAVING COUNT(DISTINCT da.id) > 0
               AND (
                 COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END) = 0
@@ -200,8 +199,7 @@ public interface DocumentRepository extends JpaRepository<Document, UUID>, JpaSp
                   NULLIF(COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END), 0)
                 ) < 0.90
               )
-            ORDER BY d.needs_expert ASC,
-                     COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END) DESC,
+            ORDER BY COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END) DESC,
                     HASHTEXT(d.id::text || EXTRACT(WEEK FROM NOW())::int::text)
            LIMIT :limit
            """)
@@ -209,14 +207,14 @@ public interface DocumentRepository extends JpaRepository<Document, UUID>, JpaSp

    /** Documents with reviewed_pct >= 90 % — Lesefertig column. */
    @Query(nativeQuery = true, value = """
-            SELECT d.id, d.title, d.meta_date AS documentDate, d.needs_expert AS needsExpert,
+            SELECT d.id, d.title, d.meta_date AS documentDate,
                   COUNT(DISTINCT da.id)                                                             AS annotationCount,
                   COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END)   AS textedBlockCount,
                   COUNT(DISTINCT CASE WHEN tb.reviewed = true THEN tb.id END)                      AS reviewedBlockCount
            FROM documents d
            JOIN document_annotations da ON da.document_id = d.id
            LEFT JOIN transcription_blocks tb ON tb.document_id = d.id
-            GROUP BY d.id, d.title, d.meta_date, d.needs_expert
+            GROUP BY d.id, d.title, d.meta_date
            HAVING COUNT(DISTINCT da.id) > 0
               AND COUNT(DISTINCT CASE WHEN tb.text IS NOT NULL AND tb.text <> '' THEN tb.id END) > 0
               AND (
--- a/backend/src/main/java/org/raddatz/familienarchiv/service/DocumentService.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/service/DocumentService.java
@@ -577,13 +577,6 @@ public class DocumentService {
        return parsed != null ? parsed.title() : stripExtension(filename);
    }

-    @Transactional
-    public Document toggleNeedsExpert(UUID documentId) {
-        Document doc = getDocumentById(documentId);
-        doc.setNeedsExpert(!doc.isNeedsExpert());
-        return documentRepository.save(doc);
-    }
-
    private static String tryParseDate(String s) {
        if (s.matches("\\d{4}-\\d{2}-\\d{2}")) {
            int m = Integer.parseInt(s.substring(5, 7));
--- a/backend/src/main/java/org/raddatz/familienarchiv/service/TranscriptionQueueService.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/service/TranscriptionQueueService.java
@@ -59,11 +59,10 @@ public class TranscriptionQueueService {
        UUID id = toUUID(row[0]);
        String title = (String) row[1];
        LocalDate documentDate = toLocalDate(row[2]);
-        boolean needsExpert = toBoolean(row[3]);
-        int annotationCount = toInt(row[4]);
-        int textedBlockCount = toInt(row[5]);
-        int reviewedBlockCount = toInt(row[6]);
-        return new TranscriptionQueueItemDTO(id, title, documentDate, needsExpert,
+        int annotationCount = toInt(row[3]);
+        int textedBlockCount = toInt(row[4]);
+        int reviewedBlockCount = toInt(row[5]);
+        return new TranscriptionQueueItemDTO(id, title, documentDate,
                annotationCount, textedBlockCount, reviewedBlockCount);
    }

@@ -79,11 +78,6 @@ public class TranscriptionQueueService {
        return LocalDate.parse(o.toString());
    }

-    private boolean toBoolean(Object o) {
-        if (o instanceof Boolean b) return b;
-        return Boolean.parseBoolean(o.toString());
-    }
-
    private int toInt(Object o) {
        if (o == null) return 0;
        if (o instanceof Number n) return n.intValue();
--- a/backend/src/main/resources/db/migration/V37__add_needs_expert_to_documents.sql
+++ b/backend/src/main/resources/db/migration/V37__add_needs_expert_to_documents.sql
@@ -1 +0,0 @@
-ALTER TABLE documents ADD COLUMN needs_expert BOOLEAN NOT NULL DEFAULT FALSE;
--- a/frontend/messages/de.json
+++ b/frontend/messages/de.json
@@ -573,7 +573,6 @@
 	"mission_control_ready_empty": "Noch keine Dokumente vollständig transkribiert.",
 	"mission_control_ready_empty_cta": "Jetzt mitmachen",
 	"mission_control_weekly_pulse": "↑ +{count} diese Woche",
-	"mission_control_expert_badge": "Experten gesucht",
 	"mission_control_blocks_progress": "{texted} / {total} Blöcke",
 	"mission_control_reviewed_pct": "{pct}% geprüft"
 }
--- a/frontend/messages/en.json
+++ b/frontend/messages/en.json
@@ -573,7 +573,6 @@
 	"mission_control_ready_empty": "No documents fully transcribed yet.",
 	"mission_control_ready_empty_cta": "Start contributing",
 	"mission_control_weekly_pulse": "↑ +{count} this week",
-	"mission_control_expert_badge": "Expert needed",
 	"mission_control_blocks_progress": "{texted} / {total} blocks",
 	"mission_control_reviewed_pct": "{pct}% reviewed"
 }
--- a/frontend/messages/es.json
+++ b/frontend/messages/es.json
@@ -573,7 +573,6 @@
 	"mission_control_ready_empty": "Aún no hay documentos completamente transcritos.",
 	"mission_control_ready_empty_cta": "Empezar a colaborar",
 	"mission_control_weekly_pulse": "↑ +{count} esta semana",
-	"mission_control_expert_badge": "Se busca experto",
 	"mission_control_blocks_progress": "{texted} / {total} bloques",
 	"mission_control_reviewed_pct": "{pct}% revisado"
 }
--- a/frontend/src/lib/components/ExpertBadge.svelte
+++ b/frontend/src/lib/components/ExpertBadge.svelte
@@ -1,26 +0,0 @@
-<script lang="ts">
-import * as m from '$lib/paraglide/messages.js';
-</script>
-
-<span
-	class="inline-flex items-center gap-1 rounded border border-purple-200 bg-purple-50 px-2 py-0.5 text-xs font-semibold text-purple-700"
->
-	<svg
-		class="h-4 w-4 shrink-0"
-		viewBox="0 0 16 16"
-		fill="none"
-		aria-hidden="true"
-		xmlns="http://www.w3.org/2000/svg"
-	>
-		<path
-			d="M8 1.5L1.5 13.5h13L8 1.5z"
-			stroke="currentColor"
-			stroke-width="1.5"
-			stroke-linejoin="round"
-			fill="none"
-		/>
-		<path d="M8 6v3.5" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" />
-		<circle cx="8" cy="11.5" r="0.75" fill="currentColor" />
-	</svg>
-	{m.mission_control_expert_badge()}
-</span>
--- a/frontend/src/lib/components/MissionControlStrip.svelte
+++ b/frontend/src/lib/components/MissionControlStrip.svelte
@@ -8,7 +8,6 @@ type TranscriptionQueueItemDTO = {
 	id: string;
 	title: string;
 	documentDate?: string;
-	needsExpert: boolean;
 	annotationCount: number;
 	textedBlockCount: number;
 	reviewedBlockCount: number;
--- a/frontend/src/lib/components/ReadyColumn.svelte
+++ b/frontend/src/lib/components/ReadyColumn.svelte
@@ -6,7 +6,6 @@ type TranscriptionQueueItemDTO = {
 	id: string;
 	title: string;
 	documentDate?: string;
-	needsExpert: boolean;
 	annotationCount: number;
 	textedBlockCount: number;
 	reviewedBlockCount: number;
--- a/frontend/src/lib/components/SegmentationColumn.svelte
+++ b/frontend/src/lib/components/SegmentationColumn.svelte
@@ -1,13 +1,11 @@
 <script lang="ts">
 import * as m from '$lib/paraglide/messages.js';
 import { getLocale } from '$lib/paraglide/runtime.js';
-import ExpertBadge from './ExpertBadge.svelte';

 type TranscriptionQueueItemDTO = {
 	id: string;
 	title: string;
 	documentDate?: string;
-	needsExpert: boolean;
 	annotationCount: number;
 	textedBlockCount: number;
 	reviewedBlockCount: number;
@@ -53,12 +51,7 @@ function formatDate(dateStr: string): string {
 						href="/documents/{doc.id}"
 						class="flex min-h-[44px] flex-col justify-center rounded px-1 py-2 hover:bg-canvas focus-visible:ring-2 focus-visible:ring-focus-ring focus-visible:ring-offset-2 focus-visible:outline-none"
 					>
-						<div class="flex flex-wrap items-center gap-1.5">
-							<span class="font-serif text-sm text-ink">{doc.title}</span>
-							{#if doc.needsExpert}
-								<ExpertBadge />
-							{/if}
-						</div>
+						<span class="font-serif text-sm text-ink">{doc.title}</span>
 						{#if doc.documentDate}
 							<span class="mt-0.5 text-xs text-ink-3">{formatDate(doc.documentDate)}</span>
 						{/if}
--- a/frontend/src/lib/components/TranscriptionColumn.svelte
+++ b/frontend/src/lib/components/TranscriptionColumn.svelte
@@ -1,13 +1,11 @@
 <script lang="ts">
 import * as m from '$lib/paraglide/messages.js';
 import { getLocale } from '$lib/paraglide/runtime.js';
-import ExpertBadge from './ExpertBadge.svelte';

 type TranscriptionQueueItemDTO = {
 	id: string;
 	title: string;
 	documentDate?: string;
-	needsExpert: boolean;
 	annotationCount: number;
 	textedBlockCount: number;
 	reviewedBlockCount: number;
@@ -58,12 +56,7 @@ function blockProgress(doc: TranscriptionQueueItemDTO): number {
 						href="/documents/{doc.id}"
 						class="flex min-h-[44px] flex-col justify-center rounded px-1 py-2 hover:bg-canvas focus-visible:ring-2 focus-visible:ring-focus-ring focus-visible:ring-offset-2 focus-visible:outline-none"
 					>
-						<div class="flex flex-wrap items-center gap-1.5">
-							<span class="font-serif text-sm text-ink">{doc.title}</span>
-							{#if doc.needsExpert}
-								<ExpertBadge />
-							{/if}
-						</div>
+						<span class="font-serif text-sm text-ink">{doc.title}</span>
 						{#if doc.documentDate}
 							<span class="mt-0.5 text-xs text-ink-3">{formatDate(doc.documentDate)}</span>
 						{/if}
--- a/frontend/src/lib/generated/api.ts
+++ b/frontend/src/lib/generated/api.ts
@@ -1225,7 +1225,6 @@ export interface components {
            metadataComplete: boolean;
            /** @enum {string} */
            scriptType: "UNKNOWN" | "TYPEWRITER" | "HANDWRITING_LATIN" | "HANDWRITING_KURRENT";
-            needsExpert: boolean;
            receivers?: components["schemas"]["Person"][];
            sender?: components["schemas"]["Person"];
            tags?: components["schemas"]["Tag"][];
@@ -1489,7 +1488,6 @@ export interface components {
            title: string;
            /** Format: date */
            documentDate?: string;
-            needsExpert: boolean;
            /** Format: int32 */
            annotationCount: number;
            /** Format: int32 */
--- a/frontend/src/routes/briefwechsel/page.svelte.spec.ts
+++ b/frontend/src/routes/briefwechsel/page.svelte.spec.ts
@@ -39,7 +39,6 @@ const makeDoc = (overrides: Record<string, unknown> = {}) => ({
 	location: 'Berlin',
 	metadataComplete: false,
 	scriptType: 'UNKNOWN' as const,
-	needsExpert: false,
 	sender: { id: 'p1', firstName: 'Hans', lastName: 'Müller' },
 	receivers: [{ id: 'p2', firstName: 'Anna', lastName: 'Schmidt' }],
 	tags: [],
				`@@ -1 +0,0 @@`
				`ALTER TABLE documents ADD COLUMN needs_expert BOOLEAN NOT NULL DEFAULT FALSE;`