Compare commits

..

3 Commits

Author SHA1 Message Date
Marcel
9f887f12f5 feat(i18n): add person_meta_doc_count + person_meta_rel_count keys (de/en/es) (§7)
All checks were successful
CI / Unit & Component Tests (pull_request) Successful in 4m59s
CI / OCR Service Tests (pull_request) Successful in 25s
CI / Backend Unit Tests (pull_request) Successful in 5m52s
CI / fail2ban Regex (pull_request) Successful in 42s
CI / Semgrep Security Scan (pull_request) Successful in 23s
CI / Compose Bucket Idempotency (pull_request) Successful in 1m6s
SDD Gate / RTM Check (pull_request) Successful in 15s
SDD Gate / Contract Validate (pull_request) Successful in 23s
SDD Gate / Constitution Impact (pull_request) Successful in 17s
Refs #859
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-16 19:16:49 +02:00
Marcel
33a1db5d77 refactor(persons): adopt MetaLine primitive on PersonDetail (§7)
Refs #859
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-16 19:16:22 +02:00
Marcel
649b6b447c feat(shared): add MetaLine primitive — · -separated meta, optional icon (§7)
Refs #859
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-16 19:15:48 +02:00
16 changed files with 193 additions and 180 deletions

View File

@@ -193,6 +193,8 @@
"person_no_docs": "Diese Person ist noch nicht als Absender verknüpft.", "person_no_docs": "Diese Person ist noch nicht als Absender verknüpft.",
"person_received_docs_heading": "Empfangene Dokumente", "person_received_docs_heading": "Empfangene Dokumente",
"person_no_received_docs": "Diese Person ist noch nicht als Empfänger verknüpft.", "person_no_received_docs": "Diese Person ist noch nicht als Empfänger verknüpft.",
"person_meta_doc_count": "{count} Dokumente",
"person_meta_rel_count": "{count} Beziehungen",
"person_role_sender": "Gesendet", "person_role_sender": "Gesendet",
"person_role_receiver": "Empfangen", "person_role_receiver": "Empfangen",
"person_co_correspondents_heading": "Häufige Korrespondenten", "person_co_correspondents_heading": "Häufige Korrespondenten",

View File

@@ -193,6 +193,8 @@
"person_no_docs": "This person has not yet been linked as a sender.", "person_no_docs": "This person has not yet been linked as a sender.",
"person_received_docs_heading": "Received documents", "person_received_docs_heading": "Received documents",
"person_no_received_docs": "This person has not yet been linked as a receiver.", "person_no_received_docs": "This person has not yet been linked as a receiver.",
"person_meta_doc_count": "{count} documents",
"person_meta_rel_count": "{count} relationships",
"person_role_sender": "Sent", "person_role_sender": "Sent",
"person_role_receiver": "Received", "person_role_receiver": "Received",
"person_co_correspondents_heading": "Frequent correspondents", "person_co_correspondents_heading": "Frequent correspondents",

View File

@@ -193,6 +193,8 @@
"person_no_docs": "Esta persona aún no está vinculada como remitente.", "person_no_docs": "Esta persona aún no está vinculada como remitente.",
"person_received_docs_heading": "Documentos recibidos", "person_received_docs_heading": "Documentos recibidos",
"person_no_received_docs": "Esta persona aún no está vinculada como receptor.", "person_no_received_docs": "Esta persona aún no está vinculada como receptor.",
"person_meta_doc_count": "{count} documentos",
"person_meta_rel_count": "{count} relaciones",
"person_role_sender": "Enviado", "person_role_sender": "Enviado",
"person_role_receiver": "Recibido", "person_role_receiver": "Recibido",
"person_co_correspondents_heading": "Corresponsales frecuentes", "person_co_correspondents_heading": "Corresponsales frecuentes",

View File

@@ -1,12 +1,11 @@
<script lang="ts"> <script lang="ts">
import { m } from '$lib/paraglide/messages.js'; import { m } from '$lib/paraglide/messages.js';
import { formatDate } from '$lib/shared/utils/date'; import { formatDate } from '$lib/shared/utils/date';
import { formatDocumentStatus } from '$lib/document/documentStatusLabel';
import { getInitials, personAvatarColor } from '$lib/person/personFormat'; import { getInitials, personAvatarColor } from '$lib/person/personFormat';
import RelationshipPill from '$lib/person/relationship/RelationshipPill.svelte'; import RelationshipPill from '$lib/person/relationship/RelationshipPill.svelte';
import DocumentDate from './DocumentDate.svelte'; import DocumentDate from './DocumentDate.svelte';
import DocumentStatusChip from './DocumentStatusChip.svelte';
import type { DatePrecision } from '$lib/shared/utils/documentDate'; import type { DatePrecision } from '$lib/shared/utils/documentDate';
import type { DocumentStatus } from '$lib/document/documentStatusLabel';
type Person = { id: string; firstName?: string | null; lastName: string; displayName: string }; type Person = { id: string; firstName?: string | null; lastName: string; displayName: string };
type Tag = { id: string; name: string }; type Tag = { id: string; name: string };
@@ -23,7 +22,7 @@ type Props = {
metaDateEnd?: string | null; metaDateEnd?: string | null;
metaDateRaw?: string | null; metaDateRaw?: string | null;
location: string | null; location: string | null;
status: DocumentStatus; status: string;
sender: Person | null; sender: Person | null;
receivers: Person[]; receivers: Person[];
tags: Tag[]; tags: Tag[];
@@ -69,6 +68,7 @@ function formatGeschichteDate(g: GeschichteSummary): string {
} }
const displayLocation = $derived(location ?? '—'); const displayLocation = $derived(location ?? '—');
const statusLabel = $derived(formatDocumentStatus(status));
const visibleReceivers = $derived(receivers.slice(0, VISIBLE_RECEIVER_LIMIT)); const visibleReceivers = $derived(receivers.slice(0, VISIBLE_RECEIVER_LIMIT));
const hiddenReceiverCount = $derived(Math.max(0, receivers.length - VISIBLE_RECEIVER_LIMIT)); const hiddenReceiverCount = $derived(Math.max(0, receivers.length - VISIBLE_RECEIVER_LIMIT));
const hasPersons = $derived(sender !== null || receivers.length > 0); const hasPersons = $derived(sender !== null || receivers.length > 0);
@@ -131,7 +131,7 @@ function getFullName(person: Person): string {
</div> </div>
<div> <div>
<dt class="font-sans text-xs font-medium text-ink-3">{m.doc_details_field_status()}</dt> <dt class="font-sans text-xs font-medium text-ink-3">{m.doc_details_field_status()}</dt>
<dd class="text-ink"><DocumentStatusChip status={status} /></dd> <dd class="text-ink">{statusLabel}</dd>
</div> </div>
</dl> </dl>
</div> </div>

View File

@@ -1,8 +1,7 @@
<script lang="ts"> <script lang="ts">
import StatusDot from '$lib/shared/primitives/StatusDot.svelte';
import { import {
formatDocumentStatus, formatDocumentStatus,
statusDotColor, statusDotClass,
type DocumentStatus type DocumentStatus
} from '$lib/document/documentStatusLabel'; } from '$lib/document/documentStatusLabel';
@@ -12,10 +11,12 @@ type Props = {
let { status }: Props = $props(); let { status }: Props = $props();
const color = $derived(statusDotColor(status)); const dotClass = $derived(statusDotClass(status));
const label = $derived(formatDocumentStatus(status)); const label = $derived(formatDocumentStatus(status));
</script> </script>
<span data-testid="status-chip" class="inline-flex shrink-0 items-center"> <span
<StatusDot color={color} label={label} /> class="hidden shrink-0 md:block {dotClass} h-4 w-4 rounded-full"
</span> title={label}
aria-label={label}
></span>

View File

@@ -6,63 +6,45 @@ import DocumentStatusChip from './DocumentStatusChip.svelte';
afterEach(cleanup); afterEach(cleanup);
describe('DocumentStatusChip', () => { describe('DocumentStatusChip', () => {
it('renders the placeholder label for PLACEHOLDER status', async () => { it('renders the placeholder label and gray dot for PLACEHOLDER status', async () => {
render(DocumentStatusChip, { props: { status: 'PLACEHOLDER' } }); render(DocumentStatusChip, { props: { status: 'PLACEHOLDER' } });
// CSS uppercase is visual only; DOM textContent returns the Paraglide string.
await expect.element(page.getByText('Platzhalter')).toBeInTheDocument(); const dot = await page.getByTitle('Platzhalter').element();
expect(dot.classList.contains('bg-gray-400')).toBe(true);
}); });
it('renders the uploaded label for UPLOADED status', async () => { it('renders the uploaded label and emerald dot for UPLOADED status', async () => {
render(DocumentStatusChip, { props: { status: 'UPLOADED' } }); render(DocumentStatusChip, { props: { status: 'UPLOADED' } });
await expect.element(page.getByText('Hochgeladen')).toBeInTheDocument();
const dot = await page.getByTitle('Hochgeladen').element();
expect(dot.classList.contains('bg-emerald-500')).toBe(true);
}); });
it('renders the transcribed label for TRANSCRIBED status', async () => { it('renders the transcribed label and blue dot for TRANSCRIBED status', async () => {
render(DocumentStatusChip, { props: { status: 'TRANSCRIBED' } }); render(DocumentStatusChip, { props: { status: 'TRANSCRIBED' } });
await expect.element(page.getByText('Transkribiert')).toBeInTheDocument();
const dot = await page.getByTitle('Transkribiert').element();
expect(dot.classList.contains('bg-blue-400')).toBe(true);
}); });
it('renders the reviewed label for REVIEWED status', async () => { it('renders the reviewed label and amber dot for REVIEWED status', async () => {
render(DocumentStatusChip, { props: { status: 'REVIEWED' } }); render(DocumentStatusChip, { props: { status: 'REVIEWED' } });
await expect.element(page.getByText('Geprüft')).toBeInTheDocument();
const dot = await page.getByTitle('Geprüft').element();
expect(dot.classList.contains('bg-amber-400')).toBe(true);
}); });
it('renders the archived label for ARCHIVED status', async () => { it('renders the archived label and dark emerald dot for ARCHIVED status', async () => {
render(DocumentStatusChip, { props: { status: 'ARCHIVED' } }); render(DocumentStatusChip, { props: { status: 'ARCHIVED' } });
await expect.element(page.getByText('Archiviert')).toBeInTheDocument();
const dot = await page.getByTitle('Archiviert').element();
expect(dot.classList.contains('bg-emerald-600')).toBe(true);
}); });
it('renders the dot as an aria-hidden element (decorative)', async () => { it('exposes the status as both a title tooltip and an aria-label', async () => {
render(DocumentStatusChip, { props: { status: 'UPLOADED' } }); render(DocumentStatusChip, { props: { status: 'UPLOADED' } });
const dot = document.querySelector('[aria-hidden="true"]');
expect(dot).not.toBeNull();
});
it('label AND dot are visible at all breakpoints — no hidden class on chip root', async () => { const dot = await page.getByTitle('Hochgeladen').element();
render(DocumentStatusChip, { props: { status: 'PLACEHOLDER' } }); expect(dot.getAttribute('aria-label')).toBe('Hochgeladen');
const root = document.querySelector('[data-testid="status-chip"]');
expect(root).not.toBeNull();
// The chip root must NOT have "hidden" class
expect(root?.className).not.toContain('hidden');
// And must not have md:block (which would hide on mobile)
expect(root?.className).not.toContain('md:block');
});
it('uses sage token for ARCHIVED status', async () => {
render(DocumentStatusChip, { props: { status: 'ARCHIVED' } });
const dot = document.querySelector('[aria-hidden="true"]');
expect(dot?.getAttribute('style')).toContain('var(--c-tag-sage)');
});
it('uses amber token for UPLOADED status', async () => {
render(DocumentStatusChip, { props: { status: 'UPLOADED' } });
const dot = document.querySelector('[aria-hidden="true"]');
expect(dot?.getAttribute('style')).toContain('var(--c-tag-amber)');
});
it('uses slate token for PLACEHOLDER status', async () => {
render(DocumentStatusChip, { props: { status: 'PLACEHOLDER' } });
const dot = document.querySelector('[aria-hidden="true"]');
expect(dot?.getAttribute('style')).toContain('var(--c-tag-slate)');
}); });
}); });

View File

@@ -9,7 +9,6 @@ import DocumentTopBarActions from './DocumentTopBarActions.svelte';
import DocumentMobileMenu from './DocumentMobileMenu.svelte'; import DocumentMobileMenu from './DocumentMobileMenu.svelte';
import BackButton from '$lib/shared/primitives/BackButton.svelte'; import BackButton from '$lib/shared/primitives/BackButton.svelte';
import type { DatePrecision } from '$lib/shared/utils/documentDate'; import type { DatePrecision } from '$lib/shared/utils/documentDate';
import type { DocumentStatus } from '$lib/document/documentStatusLabel';
type Person = { id: string; firstName?: string | null; lastName: string; displayName: string }; type Person = { id: string; firstName?: string | null; lastName: string; displayName: string };
type Tag = { id: string; name: string }; type Tag = { id: string; name: string };
@@ -27,7 +26,7 @@ type Doc = {
filePath?: string | null; filePath?: string | null;
contentType?: string | null; contentType?: string | null;
location?: string | null; location?: string | null;
status?: DocumentStatus | null; status?: string | null;
tags?: Tag[] | null; tags?: Tag[] | null;
hasTranscription?: boolean; hasTranscription?: boolean;
}; };

View File

@@ -1,5 +1,5 @@
import { describe, it, expect } from 'vitest'; import { describe, it, expect } from 'vitest';
import { formatDocumentStatus, statusDotColor } from './documentStatusLabel'; import { formatDocumentStatus, statusDotClass } from './documentStatusLabel';
describe('formatDocumentStatus', () => { describe('formatDocumentStatus', () => {
it('maps PLACEHOLDER to correct label', () => { it('maps PLACEHOLDER to correct label', () => {
@@ -27,24 +27,24 @@ describe('formatDocumentStatus', () => {
}); });
}); });
describe('statusDotColor — 5→3 semantic token mapping', () => { describe('statusDotClass', () => {
it('PLACEHOLDER → --c-tag-slate (new/draft)', () => { it('PLACEHOLDER → bg-gray-400', () => {
expect(statusDotColor('PLACEHOLDER')).toBe('var(--c-tag-slate)'); expect(statusDotClass('PLACEHOLDER')).toBe('bg-gray-400');
}); });
it('UPLOADED → --c-tag-amber (in-progress)', () => { it('UPLOADED → bg-emerald-500', () => {
expect(statusDotColor('UPLOADED')).toBe('var(--c-tag-amber)'); expect(statusDotClass('UPLOADED')).toBe('bg-emerald-500');
}); });
it('TRANSCRIBED → --c-tag-sage (done/confirmed)', () => { it('TRANSCRIBED → bg-blue-400', () => {
expect(statusDotColor('TRANSCRIBED')).toBe('var(--c-tag-sage)'); expect(statusDotClass('TRANSCRIBED')).toBe('bg-blue-400');
}); });
it('REVIEWED → --c-tag-sage (done/confirmed)', () => { it('REVIEWED → bg-amber-400', () => {
expect(statusDotColor('REVIEWED')).toBe('var(--c-tag-sage)'); expect(statusDotClass('REVIEWED')).toBe('bg-amber-400');
}); });
it('ARCHIVED → --c-tag-sage (done/confirmed)', () => { it('ARCHIVED → bg-emerald-600', () => {
expect(statusDotColor('ARCHIVED')).toBe('var(--c-tag-sage)'); expect(statusDotClass('ARCHIVED')).toBe('bg-emerald-600');
}); });
}); });

View File

@@ -19,23 +19,17 @@ export function formatDocumentStatus(status: string): string {
} }
} }
/** export function statusDotClass(status: DocumentStatus): string {
* Maps a DocumentStatus to a semantic `--c-tag-*` CSS custom-property string.
*
* 5→3 mapping (decided in issue #861):
* ARCHIVED / TRANSCRIBED / REVIEWED → --c-tag-sage (done / confirmed)
* UPLOADED → --c-tag-amber (in-progress)
* PLACEHOLDER → --c-tag-slate (new / draft)
*/
export function statusDotColor(status: DocumentStatus): string {
switch (status) { switch (status) {
case 'ARCHIVED':
case 'TRANSCRIBED':
case 'REVIEWED':
return 'var(--c-tag-sage)';
case 'UPLOADED':
return 'var(--c-tag-amber)';
case 'PLACEHOLDER': case 'PLACEHOLDER':
return 'var(--c-tag-slate)'; return 'bg-gray-400';
case 'UPLOADED':
return 'bg-emerald-500';
case 'TRANSCRIBED':
return 'bg-blue-400';
case 'REVIEWED':
return 'bg-amber-400';
case 'ARCHIVED':
return 'bg-emerald-600';
} }
} }

View File

@@ -0,0 +1,26 @@
<script lang="ts">
let {
items,
iconSrc
}: {
items: string[];
iconSrc?: string;
} = $props();
</script>
{#if items.length > 0}
<div
data-testid="meta-line"
style="display:flex; align-items:center; flex-wrap:wrap; gap:8px; font-family:var(--font-sans); font-size:12px; color:var(--c-ink-2);"
>
{#if iconSrc}
<img src={iconSrc} alt="" style="width:14px; height:14px; opacity:0.5; flex-shrink:0;" />
{/if}
{#each items as item, i (i)}
{#if i > 0}
<span data-testid="meta-sep" aria-hidden="true">·</span>
{/if}
<span data-testid="meta-item">{item}</span>
{/each}
</div>
{/if}

View File

@@ -0,0 +1,74 @@
import { afterEach, describe, expect, it } from 'vitest';
import { cleanup, render } from 'vitest-browser-svelte';
import MetaLine from './MetaLine.svelte';
afterEach(() => cleanup());
describe('MetaLine', () => {
it('renders N item spans when given N items', async () => {
render(MetaLine, { items: ['14. März 1923', '14 Dokumente', '4 Personen'] });
const spans = document.querySelectorAll('[data-testid="meta-item"]');
expect(spans).toHaveLength(3);
expect(spans[0].textContent).toBe('14. März 1923');
expect(spans[1].textContent).toBe('14 Dokumente');
expect(spans[2].textContent).toBe('4 Personen');
});
it('renders separator spans between items', async () => {
render(MetaLine, { items: ['A', 'B', 'C'] });
const seps = document.querySelectorAll('[data-testid="meta-sep"]');
// N items → N-1 separators
expect(seps).toHaveLength(2);
expect(seps[0].textContent).toBe('·');
});
it('renders nothing when items is empty', async () => {
const { container } = render(MetaLine, { items: [] });
// No element children — Svelte may leave an empty comment node but no DOM elements
expect(container.querySelectorAll('[data-testid]')).toHaveLength(0);
expect(container.querySelectorAll('div, span, img')).toHaveLength(0);
});
it('renders nothing when items has one element (no separator)', async () => {
render(MetaLine, { items: ['Nur eines'] });
const seps = document.querySelectorAll('[data-testid="meta-sep"]');
expect(seps).toHaveLength(0);
const spans = document.querySelectorAll('[data-testid="meta-item"]');
expect(spans).toHaveLength(1);
});
it('shows the leading img when iconSrc is supplied', async () => {
render(MetaLine, {
items: ['Datum'],
iconSrc: '/degruyter-icons/Simple/Small-16px/SVG/Action/Calendar-Add-SM.svg'
});
const img = document.querySelector('img');
expect(img).not.toBeNull();
});
it('does NOT render an img when iconSrc is omitted', async () => {
render(MetaLine, { items: ['Datum'] });
const img = document.querySelector('img');
expect(img).toBeNull();
});
it('icon has width 14px, height 14px, opacity 0.5, and alt=""', async () => {
render(MetaLine, {
items: ['Datum'],
iconSrc: '/degruyter-icons/Simple/Small-16px/SVG/Action/Calendar-Add-SM.svg'
});
const img = document.querySelector('img') as HTMLImageElement;
expect(img.alt).toBe('');
// Inline style values (set directly on the element, not via getComputedStyle)
expect(img.style.width).toBe('14px');
expect(img.style.height).toBe('14px');
expect(img.style.opacity).toBe('0.5');
});
it('applies font-size 12px to the wrapper', async () => {
render(MetaLine, { items: ['Test'] });
const wrapper = document.querySelector('[data-testid="meta-line"]') as HTMLElement;
expect(wrapper).not.toBeNull();
expect(wrapper.style.fontSize).toBe('12px');
});
});

View File

@@ -1,31 +0,0 @@
<script lang="ts">
/**
* StatusDot — shared primitive (§7, issue #861).
*
* Dumb renderer: props only, no domain imports.
* - `color`: a CSS custom-property string, e.g. `var(--c-tag-sage)`
* - `label`: plain string (from Paraglide, never raw user input)
*
* The dot is aria-hidden (decorative once the visible text label is present).
* Label uses var(--c-ink-2) — NEVER the status hue (amber at 10px fails AA).
* No import from $lib/document/ — eslint-boundaries shared→document is forbidden.
*/
type Props = {
color: string;
label: string;
};
let { color, label }: Props = $props();
</script>
<span class="inline-flex items-center gap-1.5">
<span
aria-hidden="true"
style="background-color: {color}; width: 7px; height: 7px; border-radius: 9999px; flex-shrink: 0; display: inline-block;"
></span>
<span
data-testid="status-dot-label"
class="font-sans text-[10px] font-bold tracking-[.13em] text-ink-2 uppercase">{label}</span
>
</span>

View File

@@ -1,61 +0,0 @@
import { describe, it, expect, afterEach } from 'vitest';
import { cleanup, render } from 'vitest-browser-svelte';
import { page } from 'vitest/browser';
import StatusDot from './StatusDot.svelte';
afterEach(() => cleanup());
describe('StatusDot', () => {
it('renders the label text', async () => {
render(StatusDot, { color: 'var(--c-tag-sage)', label: 'Archiviert' });
await expect.element(page.getByText('Archiviert')).toBeInTheDocument();
});
it('renders the dot as aria-hidden decorative element', async () => {
render(StatusDot, { color: 'var(--c-tag-amber)', label: 'Hochgeladen' });
const dot = document.querySelector('[aria-hidden="true"]');
expect(dot).not.toBeNull();
});
it('applies the color token via background-color style on the dot', async () => {
render(StatusDot, { color: 'var(--c-tag-slate)', label: 'Platzhalter' });
const dot = document.querySelector('[aria-hidden="true"]');
expect(dot?.getAttribute('style')).toContain('var(--c-tag-slate)');
});
it('renders label text via text node — never via innerHTML', async () => {
render(StatusDot, { color: 'var(--c-tag-sage)', label: 'Transkribiert' });
// CSS uppercase is visual only; textContent returns the original string.
// We verify the DOM text is present via the normal text node (no XSS risk).
const textEl = document.querySelector('[data-testid="status-dot-label"]');
expect(textEl).not.toBeNull();
expect(textEl?.textContent?.trim()).toBe('Transkribiert');
});
it('dot is 7px wide and tall (circle)', async () => {
render(StatusDot, { color: 'var(--c-tag-sage)', label: 'Archiviert' });
const dot = document.querySelector('[aria-hidden="true"]');
// Size is set via inline style — verify dot has no text content (it is a pure visual circle)
expect(dot?.textContent?.trim()).toBe('');
});
it('label uses ink-2 color class, not status hue', async () => {
render(StatusDot, { color: 'var(--c-tag-amber)', label: 'Hochgeladen' });
const label = document.querySelector('[data-testid="status-dot-label"]');
// Should carry text-ink-2 class for color
expect(label?.className).toContain('text-ink-2');
});
it('label is uppercase Montserrat', async () => {
render(StatusDot, { color: 'var(--c-tag-sage)', label: 'Geprüft' });
const label = document.querySelector('[data-testid="status-dot-label"]');
expect(label?.className).toContain('font-sans');
expect(label?.className).toContain('uppercase');
});
it('does not import from $lib/document — is truly shared', () => {
// This is a structural/lint test. The fact it compiles without error when
// imported here (from shared/) is the proof. Eslint-boundaries enforces this.
expect(true).toBe(true);
});
});

View File

@@ -3,6 +3,7 @@ import { m } from '$lib/paraglide/messages.js';
import { SvelteMap } from 'svelte/reactivity'; import { SvelteMap } from 'svelte/reactivity';
import BackButton from '$lib/shared/primitives/BackButton.svelte'; import BackButton from '$lib/shared/primitives/BackButton.svelte';
import PersonCard from './PersonCard.svelte'; import PersonCard from './PersonCard.svelte';
import MetaLine from '$lib/shared/primitives/MetaLine.svelte';
import NameHistoryCard from './NameHistoryCard.svelte'; import NameHistoryCard from './NameHistoryCard.svelte';
import CoCorrespondentsList from './CoCorrespondentsList.svelte'; import CoCorrespondentsList from './CoCorrespondentsList.svelte';
import PersonDocumentList from './PersonDocumentList.svelte'; import PersonDocumentList from './PersonDocumentList.svelte';
@@ -15,6 +16,16 @@ const person = $derived(data.person);
const sentDocuments = $derived(data.sentDocuments); const sentDocuments = $derived(data.sentDocuments);
const receivedDocuments = $derived(data.receivedDocuments); const receivedDocuments = $derived(data.receivedDocuments);
const totalDocCount = $derived(sentDocuments.length + receivedDocuments.length);
const relCount = $derived(data.relationships.length + data.inferredRelationships.length);
const personMetaItems = $derived.by(() => {
const items: string[] = [];
if (totalDocCount > 0) items.push(m.person_meta_doc_count({ count: totalDocCount }));
if (relCount > 0) items.push(m.person_meta_rel_count({ count: relCount }));
return items;
});
const coCorrespondents = $derived.by(() => { const coCorrespondents = $derived.by(() => {
const freq = new SvelteMap<string, { id: string; name: string; count: number }>(); const freq = new SvelteMap<string, { id: string; name: string; count: number }>();
@@ -61,6 +72,11 @@ const coCorrespondents = $derived.by(() => {
<!-- Left column: Person card + name history --> <!-- Left column: Person card + name history -->
<div> <div>
<PersonCard person={person} canWrite={data.canWrite} /> <PersonCard person={person} canWrite={data.canWrite} />
{#if personMetaItems.length > 0}
<div class="mt-3">
<MetaLine items={personMetaItems} />
</div>
{/if}
<div class="mt-6"> <div class="mt-6">
<NameHistoryCard aliases={data.aliases} personFirstName={person.firstName} /> <NameHistoryCard aliases={data.aliases} personFirstName={person.firstName} />
</div> </div>

View File

@@ -1,10 +1,9 @@
<script lang="ts"> <script lang="ts">
import { m } from '$lib/paraglide/messages.js'; import { m } from '$lib/paraglide/messages.js';
import { formatDate } from '$lib/shared/utils/date'; import { formatDate } from '$lib/shared/utils/date';
import { formatDocumentStatus } from '$lib/document/documentStatusLabel';
import { sortDocumentsByDate, type SortDir } from '$lib/shared/utils/sort'; import { sortDocumentsByDate, type SortDir } from '$lib/shared/utils/sort';
import DocumentThumbnail from '$lib/document/DocumentThumbnail.svelte'; import DocumentThumbnail from '$lib/document/DocumentThumbnail.svelte';
import DocumentStatusChip from '$lib/document/DocumentStatusChip.svelte';
import type { DocumentStatus } from '$lib/document/documentStatusLabel';
const DOCS_PREVIEW_LIMIT = 5; const DOCS_PREVIEW_LIMIT = 5;
@@ -19,7 +18,7 @@ let {
originalFilename: string; originalFilename: string;
documentDate?: string | null; documentDate?: string | null;
location?: string | null; location?: string | null;
status: DocumentStatus; status: string;
contentType?: string; contentType?: string;
thumbnailUrl?: string; thumbnailUrl?: string;
}[]; }[];
@@ -95,8 +94,17 @@ const visibleDocuments = $derived(
</div> </div>
</div> </div>
<!-- Status chip — always visible at all breakpoints --> <!-- Status chip -->
<DocumentStatusChip status={doc.status} /> <span
class="hidden flex-shrink-0 rounded-full border px-2 py-0.5 font-sans text-[10px] font-bold sm:inline-block
{doc.status === 'UPLOADED'
? 'border-accent/50 bg-accent/20 text-ink'
: doc.status === 'ARCHIVED'
? 'border-green-200 bg-green-50 text-green-800'
: 'border-yellow-200 bg-yellow-50 text-yellow-800'}"
>
{formatDocumentStatus(doc.status)}
</span>
<img <img
src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Arrow/Arrow-Right-MD.svg" src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Arrow/Arrow-Right-MD.svg"

View File

@@ -2,7 +2,6 @@ import { describe, it, expect, afterEach } from 'vitest';
import { cleanup, render } from 'vitest-browser-svelte'; import { cleanup, render } from 'vitest-browser-svelte';
import { page } from 'vitest/browser'; import { page } from 'vitest/browser';
import PersonDocumentList from './PersonDocumentList.svelte'; import PersonDocumentList from './PersonDocumentList.svelte';
import type { DocumentStatus } from '$lib/document/documentStatusLabel';
afterEach(cleanup); afterEach(cleanup);
@@ -12,7 +11,7 @@ const makeDoc = (overrides: Record<string, unknown> = {}) => ({
originalFilename: 'brief.pdf', originalFilename: 'brief.pdf',
documentDate: '1923-04-15', documentDate: '1923-04-15',
location: 'Berlin', location: 'Berlin',
status: 'UPLOADED' as DocumentStatus, status: 'UPLOADED' as string,
contentType: 'application/pdf', contentType: 'application/pdf',
thumbnailUrl: '', thumbnailUrl: '',
...overrides ...overrides