marcel/familienarchiv
1
0
Fork 0
Code Issues 117 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

fix(search): prevent stale navigation from clobbering focused search input #41

Merged
marcel merged 1 commits from fix/34-url-synced-input-keystroke-loss into main 2026-03-20 21:06:28 +01:00
Conversation 0 Commits 1 Files Changed 2 +27 -2
marcel commented 2026-03-20 20:58:35 +01:00
Owner
Copy Link

Closes #34

Summary

  • Add qFocused flag (set via onfocus/onblur) to the full-text search input on /
  • Guard the q assignment in the sync $effect so it only runs while the input is not focused
  • Add a regression test that rerenders the component with stale data.filters.q while the input is focused and asserts the typed value is preserved

Root cause

The $effect that syncs URL params → local state ran unconditionally on every navigation. Fast typing triggered a goto() debounce; when the first navigation completed, the effect immediately overwrote the still-focused input with the stale URL value — dropping every character typed during the in-flight request.

Test plan

  • npm run test — all 5 client test files pass, including the new keystroke-preservation test
  • npm run lint && npm run check — no errors
  • Manual: type quickly in the document search on / — no dropped characters or flicker
Closes #34 ## Summary - Add `qFocused` flag (set via `onfocus`/`onblur`) to the full-text search input on `/` - Guard the `q` assignment in the sync `$effect` so it only runs while the input is **not** focused - Add a regression test that rerenders the component with stale `data.filters.q` while the input is focused and asserts the typed value is preserved ## Root cause The `$effect` that syncs URL params → local state ran unconditionally on every navigation. Fast typing triggered a `goto()` debounce; when the first navigation completed, the effect immediately overwrote the still-focused input with the stale URL value — dropping every character typed during the in-flight request. ## Test plan - [ ] `npm run test` — all 5 client test files pass, including the new keystroke-preservation test - [ ] `npm run lint && npm run check` — no errors - [ ] Manual: type quickly in the document search on `/` — no dropped characters or flicker
marcel added 1 commit 2026-03-20 20:58:38 +01:00
fix(search): prevent stale navigation from clobbering focused search input
Some checks failed
CI / E2E Tests (push) Waiting to run
Details
CI / Unit & Component Tests (push) Successful in 10m14s
Details
CI / Backend Unit Tests (push) Has been cancelled
Details
CI / E2E Tests (pull_request) Failing after 13m49s
Details
CI / Backend Unit Tests (pull_request) Failing after 13m59s
Details
CI / Unit & Component Tests (pull_request) Failing after 14m9s
Details
acf6fc05ad 
The sync $effect on the home page unconditionally overwrote the local `q`
state with the URL value after every navigation. When users typed faster
than a navigation round-trip (debounce fires → goto() → data reloads),
the completed navigation wrote the stale URL value back into the input,
dropping the characters typed in the interim.

Guard the `q` assignment in the effect with a `qFocused` flag (set via
onfocus/onblur on the text input). Covers issue #34.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit acf6fc05ad into main 2026-03-20 21:06:28 +01:00
marcel deleted branch fix/34-url-synced-input-keystroke-loss 2026-03-20 21:06:33 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#41
Delete Branch "fix/34-url-synced-input-keystroke-loss"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?