marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(persons): prevent stale navigation from clobbering focused search input #44

Merged
marcel merged 1 commits from fix/34-persons-search-keystroke-loss into main 2026-03-20 22:00:27 +01:00
Conversation 0 Commits 1 Files Changed 2 +84 -4
marcel commented 2026-03-20 21:59:55 +01:00
Owner
Copy Link

Closes #34 (persons page follow-up to PR #41)

Summary

The persons list search input used value={data.q || ''} bound directly to server data — no local state at all — so every navigation completion reset the input to the stale URL value mid-typing. Same root cause as the home page fix in #41, different implementation pattern.

Fix: introduce local q state + qFocused flag, guard the sync $effect so it only writes q when the input is not focused, and add onfocus/onblur handlers.

Test plan

  • npm run test — all tests pass including the new regression test
  • npm run lint && npm run check — no errors in changed files
  • Manual: type quickly in the persons search field — no dropped characters
Closes #34 (persons page follow-up to PR #41) ## Summary The persons list search input used `value={data.q || ''}` bound directly to server data — no local state at all — so every navigation completion reset the input to the stale URL value mid-typing. Same root cause as the home page fix in #41, different implementation pattern. **Fix:** introduce local `q` state + `qFocused` flag, guard the sync `$effect` so it only writes `q` when the input is not focused, and add `onfocus`/`onblur` handlers. ## Test plan - [ ] `npm run test` — all tests pass including the new regression test - [ ] `npm run lint && npm run check` — no errors in changed files - [ ] Manual: type quickly in the persons search field — no dropped characters
marcel added 1 commit 2026-03-20 21:59:56 +01:00
fix(persons): prevent stale navigation from clobbering focused search input
All checks were successful
CI / Unit & Component Tests (pull_request) Successful in 2m12s
Details
CI / Backend Unit Tests (pull_request) Successful in 1m58s
Details
CI / E2E Tests (pull_request) Successful in 17m40s
Details
CI / Unit & Component Tests (push) Successful in 1m58s
Details
CI / Backend Unit Tests (push) Successful in 1m59s
Details
CI / E2E Tests (push) Successful in 14m56s
Details
da0d5495d0 
The persons list search input used value={data.q || ''} bound directly to
server data, so every navigation completion would reset it to the URL value
mid-typing, dropping keystrokes just like issue #34 on the home page.

Apply the same focus-guard fix: introduce local `q` state, a `qFocused`
flag, and a guarded $effect that only syncs URL → state when the input is
not focused. Adds a regression test matching the home-page pattern.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit da0d5495d0 into main 2026-03-20 22:00:27 +01:00
marcel deleted branch fix/34-persons-search-keystroke-loss 2026-03-20 22:00:28 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#44
Delete Branch "fix/34-persons-search-keystroke-loss"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?