marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(#93): migrate hardcoded text-gray-400/500 to semantic ink tokens in enrich pages #108

Merged
marcel merged 1 commits from feature/93-fix-label-contrast into main 2026-03-27 16:06:58 +01:00
Conversation 0 Commits 1 Files Changed 2 +5 -5
marcel commented 2026-03-27 15:55:56 +01:00
Owner
Copy Link

Closes #93

Summary

The section label contrast issue (text-ink-3 uppercase used for "FILE", "MORE DETAILS", "OPTIONAL", etc.) is fixed at the token level in PR #107 (ink-3: #9ca3af → #6b7280).

This PR fixes the 3 hardcoded gray values in the enrich pages that bypass the token system entirely — and would have retained failing contrast even after #107 merges:

File Before After Contrast before
enrich/+page.svelte back link text-gray-500 text-ink-2 hover:text-ink ~4.2:1 on canvas ✗
enrich/done/+page.svelte body text-gray-500 text-ink-2 ~4.2:1 on canvas ✗
enrich/done/+page.svelte link text-gray-400 text-ink-2 hover:text-ink 2.6:1 ✗

Test plan

  • Enrich page: back link text is readable (not washed out) in light mode
  • Enrich done page: body text below heading is readable
  • Enrich done page: "back to list" link is readable at ≥ 4.5:1
  • Both pages still work correctly in dark mode (semantic tokens theme correctly)
Closes #93 ## Summary The section label contrast issue (`text-ink-3 uppercase` used for "FILE", "MORE DETAILS", "OPTIONAL", etc.) is fixed at the token level in PR #107 (`ink-3: #9ca3af → #6b7280`). This PR fixes the 3 hardcoded gray values in the enrich pages that bypass the token system entirely — and would have retained failing contrast even after #107 merges: | File | Before | After | Contrast before | |---|---|---|---| | `enrich/+page.svelte` back link | `text-gray-500` | `text-ink-2 hover:text-ink` | ~4.2:1 on canvas ✗ | | `enrich/done/+page.svelte` body | `text-gray-500` | `text-ink-2` | ~4.2:1 on canvas ✗ | | `enrich/done/+page.svelte` link | `text-gray-400` | `text-ink-2 hover:text-ink` | **2.6:1** ✗ | ## Test plan - [ ] Enrich page: back link text is readable (not washed out) in light mode - [ ] Enrich done page: body text below heading is readable - [ ] Enrich done page: "back to list" link is readable at ≥ 4.5:1 - [ ] Both pages still work correctly in dark mode (semantic tokens theme correctly)
marcel added 1 commit 2026-03-27 15:55:57 +01:00
fix(#93): migrate hardcoded text-gray-400/500 to semantic ink tokens
Some checks failed
CI / Unit & Component Tests (push) Successful in 2m33s
Details
CI / Backend Unit Tests (push) Successful in 2m19s
Details
CI / E2E Tests (push) Failing after 28m5s
Details
CI / Unit & Component Tests (pull_request) Successful in 2m34s
Details
CI / Backend Unit Tests (pull_request) Successful in 2m9s
Details
CI / E2E Tests (pull_request) Failing after 30m11s
Details
df89732f79 
enrich/+page.svelte back link: text-gray-500 → text-ink-2 / hover:text-ink
enrich/done/+page.svelte body text: text-gray-500 → text-ink-2
enrich/done/+page.svelte list link: text-gray-400 (2.6:1, fails AA) → text-ink-2

Root fix for section label contrast (text-ink-3 uppercase pattern used
app-wide) is in PR #107 via the ink-3 token value change.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit 5cf6947040 into main 2026-03-27 16:06:58 +01:00
marcel deleted branch feature/93-fix-label-contrast 2026-03-27 16:07:02 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#108
Delete Branch "feature/93-fix-label-contrast"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?