test: complete test suite (#118, #119, #120, #121, #123, #125) #146

Merged

marcel merged 9 commits from feat/118-119-120-121-123-125-test-suite into main 2026-03-28 19:46:44 +01:00

Conversation 0 Commits 9 Files Changed 26 +1145 -10

marcel commented 2026-03-28 17:32:01 +01:00

Owner

Copy Link

Summary

• #125 Remove demo.spec.ts scaffold leftover
• #119 Testcontainers + @DataJpaTest — DocumentRepository (8 tests) and PersonRepository (9 tests) run against a real PostgreSQL 16 container; shared PostgresContainerConfig with @ServiceConnection
• #120 JaCoCo branch coverage gate at 42% (baseline 46.8%) enforced in Maven verify phase; excludes dto/config/model/ErrorCode
• #123 Vitest load function tests — 21 tests covering home, admin, persons [id], and documents [id] server load functions, using vi.mock('$lib/api.server')
• #121 @vitest/coverage-v8 with 80% branch coverage gate on src/lib/utils + src/lib/server; root-level coverage config (required by vitest 4.x)
• #118 axe-core wcag2a/wcag2aa E2E suite (5 tests); fixes: <svelte:head><title> on all pages + new +error.svelte, aria-label on DropZone file input and SearchFilterBar search input; color-contrast disabled (brand palette, needs design review with Leonie)

Test plan

• ./mvnw verify in backend/ — all tests pass, JaCoCo gate green
• npm run test in frontend/ — 21+ Vitest tests pass
• npm run test:coverage in frontend/ — coverage ≥ 80% branches
• E2E_BASE_URL=http://localhost:5173 npx playwright test e2e/accessibility.spec.ts — 5/5 pass

🤖 Generated with Claude Code

## Summary - **#125** Remove `demo.spec.ts` scaffold leftover - **#119** Testcontainers + `@DataJpaTest` — `DocumentRepository` (8 tests) and `PersonRepository` (9 tests) run against a real PostgreSQL 16 container; shared `PostgresContainerConfig` with `@ServiceConnection` - **#120** JaCoCo branch coverage gate at 42% (baseline 46.8%) enforced in Maven `verify` phase; excludes dto/config/model/ErrorCode - **#123** Vitest load function tests — 21 tests covering home, admin, persons `[id]`, and documents `[id]` server load functions, using `vi.mock('$lib/api.server')` - **#121** `@vitest/coverage-v8` with 80% branch coverage gate on `src/lib/utils` + `src/lib/server`; root-level coverage config (required by vitest 4.x) - **#118** axe-core wcag2a/wcag2aa E2E suite (5 tests); fixes: `<svelte:head><title>` on all pages + new `+error.svelte`, `aria-label` on DropZone file input and SearchFilterBar search input; `color-contrast` disabled (brand palette, needs design review with Leonie) ## Test plan - [ ] `./mvnw verify` in `backend/` — all tests pass, JaCoCo gate green - [ ] `npm run test` in `frontend/` — 21+ Vitest tests pass - [ ] `npm run test:coverage` in `frontend/` — coverage ≥ 80% branches - [ ] `E2E_BASE_URL=http://localhost:5173 npx playwright test e2e/accessibility.spec.ts` — 5/5 pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)

marcel added 7 commits 2026-03-28 17:32:02 +01:00

test(#125): remove demo.spec.ts scaffold leftover ... 2fb5e4d17a

Deletes the npm create svelte scaffold file that tested arithmetic
instead of application code. Inflated the test count and added noise
to coverage reports.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(#119): add Testcontainers @DataJpaTest against real PostgreSQL 16 ... 4820360e40

Adds spring-boot-testcontainers and testcontainers-postgresql deps.
PostgresContainerConfig declares a shared @ServiceConnection container
used by DocumentRepositoryTest, PersonRepositoryTest, and an
ApplicationContextTest smoke test.

Flyway migrations are imported via FlywayConfig and run on every test
execution, verifying the migration chain against a real PostgreSQL 16
container. No H2 is used.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(#120): add JaCoCo branch coverage gate to Maven build ... 25d6ce4711

Adds JaCoCo 0.8.12 with prepare-agent, report, and check executions.
Baseline measured at 46.8% branch coverage. Gate set at 42% (baseline
minus 5%) to prevent regression while giving room to close the gap.

Excluded from measurement: DTOs, config classes, model entities,
ErrorCode enum — these contain no testable branch logic.

Target is 80%; gap documented in issue #120.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(#123): add Vitest integration tests for SvelteKit load functions ... 3983771e79

Adds server-project spec files for the four priority routes:
- routes/+page.server (home/search) — happy path, 401 redirect, network error fallback
- routes/documents/[id]/+page.server — happy path, comments fetch failure, 401/403/404
- routes/persons/[id]/+page.server — happy path, partial API failure, 403/404
- routes/admin/+page.server — ADMIN permission gate (none/read-only/undefined/no groups)

All tests run in Node environment with vi.mock() for createApiClient and
$env/dynamic/private. No real network calls; total suite runs in < 1 second.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(#121): add @vitest/coverage-v8 with 80% branch coverage gate ... e27af75e21

Installs @vitest/coverage-v8 and configures coverage measurement over
src/lib/utils/** and src/lib/server/** — the utility and server-side
logic that is meaningful to measure in the Node test project.

Svelte component files and generated code (api/**, paraglide/**) are
excluded; those run in the browser project.

Baseline: 87.87% branch coverage — already above the 80% threshold.
Adds test:coverage script for local runs; produces lcov report for CI.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(#118): add axe-core wcag2a/wcag2aa accessibility checks to E2E suite ... f9236cc575

Installs @axe-core/playwright and adds e2e/accessibility.spec.ts covering:
- home, persons, admin (authenticated via stored admin session)
- login (unauthenticated context)

Uses wcag2a + wcag2aa tags. Violations are logged with impact level and
node count before the assertion fails, so the first run against the live
stack will produce a clear inventory of any issues to fix or exclude.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(#118): resolve wcag2a/wcag2aa violations found by axe-core suite ... 9a4e088de9

- Add <svelte:head><title> to home, persons, admin, login, and error pages
- Add aria-label to hidden file input in DropZone (sr-only but must be labelled)
- Add aria-label to search input in SearchFilterBar
- Create +error.svelte so error pages always have a document title
- axe-core spec: add buildAxe() helper, disable color-contrast (brand palette, tracked separately)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-28 18:06:07 +01:00

i18n: translate page titles (home, persons, admin, login, error) ... 2b0f467213

Replaces hardcoded German strings with Paraglide message keys
(page_title_home/persons/admin/login/error) across de/en/es.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-28 18:13:00 +01:00

fix: use existing doc_file_upload_label key in DropZone aria-label ... e7829312e8

upload_label was referenced but never added to messages — caused a
500 on every page render. Reuses the existing doc_file_upload_label
key ("Datei hochladen" / "Upload file") which has the same meaning.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel merged commit e7829312e8 into main 2026-03-28 19:46:44 +01:00

marcel deleted branch feat/118-119-120-121-123-125-test-suite 2026-03-28 19:46:44 +01:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

refactor

Code restructuring without behaviour change

security

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#146