feat: Persons section redesign — Concept A (Enriched Directory) #159

Merged

marcel merged 19 commits from feat/persons-redesign-concept-a into main 2026-03-29 21:36:30 +02:00

Conversation 0 Commits 19 Files Changed 41 +1490 -540

marcel commented 2026-03-29 20:14:30 +02:00

Owner

Copy Link

Closes #157

Summary

Implements the full Persons section redesign per Concept A (Enriched Directory), covering 10 of 11 planned phases (Phase 11 — visual regression — requires designer review gate).

Backend

• Security hardening: @RequirePermission(WRITE_ALL) on all write endpoints (POST, PUT, DELETE /api/persons/*); unauthenticated/read-only users receive 403
• Input validation: @Size constraints on all PersonUpdateDTO fields; @Valid on controller; year bounds validated (must be > 0, birth ≤ death)
• PersonSummaryDTO: Interface projection returned by GET /api/persons, includes documentCount (sender + receiver combined via native SQL)
• POST /api/persons: Now accepts all 6 fields (firstName, lastName, alias, birthYear, deathYear, notes) via PersonUpdateDTO
• DomainException: Replaced all ResponseStatusException usages in PersonService with DomainException.notFound(PERSON_NOT_FOUND, ...)
• GET /api/stats: New endpoint returning { totalPersons, totalDocuments } for the stats bar widget
• Test coverage: 575 backend tests pass; PersonController 100%, StatsController 100%, PersonService 93.6%

Frontend

• Persons list (/persons): Stats bar ("N Personen · M Dokumente"), person cards enriched with alias (italic), life date range (* YYYY – † YYYY), and document count chip; PersonsStatsBar and PersonsEmptyState extracted as components
• New person (/persons/new): Form extended with birthYear, deathYear, and notes fields
• Person detail (/persons/[id]): 2-column layout (35% / 65%); edit mode removed (Edit button navigates to /persons/[id]/edit); inline merge panel removed
• Edit route (/persons/[id]/edit): New route with PersonEditForm (6 fields), sticky save bar, and collapsible Danger Zone accordion containing the merge panel; guarded by WRITE_ALL in the load function
• Utilities: formatLifeDateRange() and formatDocumentStatus() extracted to src/lib/utils/
• i18n: New keys added to de.json, en.json, es.json for all new UI strings and error codes
• 285 frontend tests pass; 90.26% statement coverage, 90% branch coverage

Test plan

• ./mvnw test — all 575 backend tests pass
• npx vitest run — all 285 frontend tests pass, coverage ≥ 90%
• npm run lint — prettier + eslint clean (0 errors)
• npm run check — svelte-check: 95 errors (93 were pre-existing on main; 2 new are unavoidable ServerLoadEvent type noise in test files matching the existing pattern)
• Manual: /persons list shows stats bar, alias, life dates, doc count chip
• Manual: /persons/new form has all 6 fields
• Manual: /persons/[id] detail shows 2-column layout, Edit button navigates to edit route
• Manual: /persons/[id]/edit loads form pre-filled, Save updates and redirects, Discard returns to detail
• Manual: Danger Zone accordion (collapsed) → expand → merge panel visible
• Manual: READ-only user cannot access /persons/[id]/edit (gets 403)

🤖 Generated with Claude Code

Closes #157 ## Summary Implements the full Persons section redesign per Concept A (Enriched Directory), covering 10 of 11 planned phases (Phase 11 — visual regression — requires designer review gate). ### Backend - **Security hardening**: `@RequirePermission(WRITE_ALL)` on all write endpoints (`POST`, `PUT`, `DELETE /api/persons/*`); unauthenticated/read-only users receive 403 - **Input validation**: `@Size` constraints on all `PersonUpdateDTO` fields; `@Valid` on controller; year bounds validated (must be > 0, birth ≤ death) - **PersonSummaryDTO**: Interface projection returned by `GET /api/persons`, includes `documentCount` (sender + receiver combined via native SQL) - **POST /api/persons**: Now accepts all 6 fields (`firstName`, `lastName`, `alias`, `birthYear`, `deathYear`, `notes`) via `PersonUpdateDTO` - **DomainException**: Replaced all `ResponseStatusException` usages in `PersonService` with `DomainException.notFound(PERSON_NOT_FOUND, ...)` - **GET /api/stats**: New endpoint returning `{ totalPersons, totalDocuments }` for the stats bar widget - **Test coverage**: 575 backend tests pass; `PersonController` 100%, `StatsController` 100%, `PersonService` 93.6% ### Frontend - **Persons list** (`/persons`): Stats bar ("N Personen · M Dokumente"), person cards enriched with alias (italic), life date range (`* YYYY – † YYYY`), and document count chip; `PersonsStatsBar` and `PersonsEmptyState` extracted as components - **New person** (`/persons/new`): Form extended with `birthYear`, `deathYear`, and `notes` fields - **Person detail** (`/persons/[id]`): 2-column layout (`35% / 65%`); edit mode removed (Edit button navigates to `/persons/[id]/edit`); inline merge panel removed - **Edit route** (`/persons/[id]/edit`): New route with `PersonEditForm` (6 fields), sticky save bar, and collapsible Danger Zone accordion containing the merge panel; guarded by `WRITE_ALL` in the load function - **Utilities**: `formatLifeDateRange()` and `formatDocumentStatus()` extracted to `src/lib/utils/` - **i18n**: New keys added to `de.json`, `en.json`, `es.json` for all new UI strings and error codes - **285 frontend tests pass**; 90.26% statement coverage, 90% branch coverage ## Test plan - [ ] `./mvnw test` — all 575 backend tests pass - [ ] `npx vitest run` — all 285 frontend tests pass, coverage ≥ 90% - [ ] `npm run lint` — prettier + eslint clean (0 errors) - [ ] `npm run check` — svelte-check: 95 errors (93 were pre-existing on main; 2 new are unavoidable `ServerLoadEvent` type noise in test files matching the existing pattern) - [ ] Manual: `/persons` list shows stats bar, alias, life dates, doc count chip - [ ] Manual: `/persons/new` form has all 6 fields - [ ] Manual: `/persons/[id]` detail shows 2-column layout, Edit button navigates to edit route - [ ] Manual: `/persons/[id]/edit` loads form pre-filled, Save updates and redirects, Discard returns to detail - [ ] Manual: Danger Zone accordion (collapsed) → expand → merge panel visible - [ ] Manual: READ-only user cannot access `/persons/[id]/edit` (gets 403) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

marcel added 14 commits 2026-03-29 20:14:31 +02:00

feat(persons): add @RequirePermission(WRITE_ALL) to write endpoints ... 93107e7c59

POST /api/persons, PUT /api/persons/{id}, POST /api/persons/{id}/merge
now return 403 for READ_ALL-only users.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): add @Size constraints to PersonUpdateDTO + @Valid to controller ... ef9a85eee8

firstName/lastName max 100, alias max 200, notes max 5000 chars.
PUT /api/persons/{id} returns 400 for oversized fields.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): add year range bounds validation (> 0) to PersonService ... d1e506135b

birthYear and deathYear must be positive integers; extracted shared
validateYears() method for reuse in createPerson.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(persons): replace ResponseStatusException with DomainException in PersonService ... 3987bbc1f9

Added PERSON_NOT_FOUND to ErrorCode; getById, updatePerson, mergePersons
now throw DomainException.notFound for missing persons.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): accept PersonUpdateDTO for POST /api/persons (all 6 fields) ... a3d750822c

createPerson now takes PersonUpdateDTO, persisting birthYear, deathYear,
notes in addition to firstName, lastName, alias.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): add PersonSummaryDTO with document count to GET /api/persons ... 593638482d

Native queries compute sender + receiver document count in one SQL call,
eliminating N+1. GET /api/persons now returns PersonSummaryDTO list.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(stats): add GET /api/stats endpoint returning totalPersons + totalDocuments ... 707a7610f8

New StatsController + StatsDTO; no WRITE_ALL required (read-only aggregates).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore(api): regenerate TypeScript API types from updated OpenAPI spec ... 7b03aada3b

Includes PersonSummaryDTO with documentCount, StatsDTO, and new
/api/stats endpoint.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): add formatLifeDateRange + formatDocumentStatus utility functions ... 3abdf9bb68

Unit tests for both; i18n keys for doc status and person stats bar;
PERSON_NOT_FOUND added to frontend ErrorCode type.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): enrich /persons list with stats bar, life dates, doc count chip ... f4c99cabd5

Load /api/stats in parallel; PersonsStatsBar shows totals; person cards
show alias, life date range, and document count badge.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): add birthYear, deathYear, notes fields to /persons/new form ... 7141ae1e1f

Server action passes all 6 fields to POST /api/persons.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): redesign /persons/[id] detail page (Concept A layout) ... 44e8891ca9

PersonCard: remove edit toggle, add Edit→/edit link; 2-column layout on lg;
CoCorrespondentsList: add chat icon + title tooltip; remove update/merge actions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(persons): add /persons/[id]/edit route with PersonEditForm, PersonDangerZone ... 272073f186

New edit route with WRITE_ALL guard; PersonEditForm (6 fields), sticky
PersonEditSaveBar, collapsed PersonDangerZone with PersonMergePanel.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: resolve lint and type-check issues introduced by persons redesign ... 241e4874ad

- Cast PersonSummaryDTO array to concrete type in +page.server.ts (all
  fields are optional in the generated type but always populated at runtime)
- Cast mockLocals/mockLocalsWriter to `any` in persons detail spec to
  match the pre-existing test pattern used throughout the codebase
- Add .svelte-kit-backup/ to .gitignore and .prettierignore to prevent
  lint failures from Docker-owned leftover .svelte-kit directory

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-29 20:27:42 +02:00

fix(persons): align pages with Concept A spec — card layout, stats bar, status labels, save button ... 27d7225330

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-29 20:38:26 +02:00

fix(persons): replace hardcoded 'docs'/'Persons'/'Documents' strings with i18n keys ... f5645d6c32

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-29 20:50:39 +02:00

feat(persons): redesign detail page sections to match Concept A spec ... fffecb5bf6

- CoCorrespondentsList: white card wrapper with navy initials circles in chips
- PersonDocumentList: flat row-divider pattern with variant-tinted icons (sent=navy, received=teal)
- Add variant prop (sent/received) to PersonDocumentList and wire up in page
- Add person_correspondents_hint i18n key to all three message files

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-29 20:52:48 +02:00

fix(persons): invert plus icon on New Person button for theme contrast ... a3e8a5e15e

SVG icons are black by default; on the navy primary button they need
invert in light theme (white icon) and invert-0 in dark theme (dark
icon on lighter button background).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-29 21:31:29 +02:00

chore: merge main into feat/persons-redesign-concept-a ... 169e6dc578

Resolved conflicts in messages/de.json, en.json, es.json by keeping
both the persons-redesign keys (feature branch) and the notification
keys (main) in all three locale files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel merged commit 169e6dc578 into main 2026-03-29 21:36:30 +02:00

marcel deleted branch feat/persons-redesign-concept-a 2026-03-29 21:36:32 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

refactor

Code restructuring without behaviour change

security

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#159