fix(admin): delete user button now works reliably #279

Merged

marcel merged 1 commits from fix/delete-user into main 2026-04-20 08:43:16 +02:00

Conversation 0 Commits 1 Files Changed 2 +37 -24

marcel commented 2026-04-19 18:12:02 +02:00

Owner

Copy Link

Summary

• Replaces the type=button + requestSubmit() pattern on the delete form with a type=submit button and an async use:enhance callback — the pattern the confirm service was designed for and documents in its JSDoc
• The enhance callback awaits the confirm dialog, calls cancel() if the user rejects, and calls unsaved.clearOnSuccess() before proceeding so that beforeNavigate can't silently block the post-delete redirect
• Removes the now-unnecessary deleteFormEl state variable and handleDelete function
• Updates the spec's enhance mock to support async callbacks and rewrites the three delete-confirmation tests to assert on cancel() calls instead of requestSubmit() spies

Closes #277

Test plan

• Open a user's detail page in the admin panel
• Click "Löschen…" — confirm dialog should appear
• Cancel → no deletion, page unchanged
• Click again, confirm → user is deleted and page navigates to /admin/users, deleted user gone from list
• Repeat with the edit form dirty (type something) before clicking delete — redirect should still happen after confirming
• npx vitest run src/routes/admin/users — all 49 tests pass

🤖 Generated with Claude Code

## Summary - Replaces the `type=button` + `requestSubmit()` pattern on the delete form with a `type=submit` button and an async `use:enhance` callback — the pattern the confirm service was designed for and documents in its JSDoc - The enhance callback awaits the confirm dialog, calls `cancel()` if the user rejects, and calls `unsaved.clearOnSuccess()` before proceeding so that `beforeNavigate` can't silently block the post-delete redirect - Removes the now-unnecessary `deleteFormEl` state variable and `handleDelete` function - Updates the spec's enhance mock to support async callbacks and rewrites the three delete-confirmation tests to assert on `cancel()` calls instead of `requestSubmit()` spies Closes #277 ## Test plan - [ ] Open a user's detail page in the admin panel - [ ] Click "Löschen…" — confirm dialog should appear - [ ] Cancel → no deletion, page unchanged - [ ] Click again, confirm → user is deleted and page navigates to `/admin/users`, deleted user gone from list - [ ] Repeat with the edit form dirty (type something) before clicking delete — redirect should still happen after confirming - [ ] `npx vitest run src/routes/admin/users` — all 49 tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)

marcel changed target branch from main to feat/issue-271-dashboard-redesign 2026-04-19 19:11:31 +02:00

marcel changed target branch from feat/issue-271-dashboard-redesign to main 2026-04-20 07:45:22 +02:00

marcel added 1 commit 2026-04-20 07:52:36 +02:00

fix(admin): wire delete-user button via enhance callback instead of requestSubmit() ... b6466fcd95

The delete button used type=button + requestSubmit() to trigger the form,
which did not reliably fire SvelteKit's enhance submit listener. Replaced
with a type=submit button and an async enhance callback that guards with
the confirm dialog and calls cancel() on rejection.

Also clears the unsaved-changes dirty flag before the redirect so
beforeNavigate doesn't silently block the post-delete navigation.

Closes #277

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel force-pushed fix/delete-user from 5b15991cf3 to b6466fcd95 2026-04-20 07:52:36 +02:00 Compare

marcel merged commit b6466fcd95 into main 2026-04-20 08:43:16 +02:00

marcel deleted branch fix/delete-user 2026-04-20 08:43:17 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

refactor

Code restructuring without behaviour change

security

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#279