marcel/familienarchiv
1
0
Fork 0
Code Issues 120 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

feat(person-mention): add @mention discoverability hint to transcription block placeholder #379

Merged
marcel merged 3 commits from feat/issue-370-at-mention-placeholder-hint into main 2026-05-04 15:35:08 +02:00
Conversation 7 Commits 3 Files Changed 6 +26 -9

3 Commits

Author SHA1 Message Date
Marcel
d4f666e981 test(person-mention): move i18n test to its own describe block
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 3m38s
Details
CI / Backend Unit Tests (pull_request) Failing after 3m16s
Details
CI / OCR Service Tests (pull_request) Successful in 41s
Details
CI / Unit & Component Tests (push) Failing after 3m38s
Details
CI / OCR Service Tests (push) Successful in 39s
Details
CI / Backend Unit Tests (push) Failing after 3m11s
Details 
Move `transcription_block_placeholder contains @ mention trigger` out of
`describe('PersonMentionEditor — placeholder behavior')` into a new
`describe('PersonMentionEditor — i18n message content')` block so each
describe group has a single, clear responsibility.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-04 15:30:11 +02:00
Marcel
678d9dab38 refactor(training): extract kurrentLabels helper + clarify query comments 
Extract repeated `new java.util.HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION))`
into a `kurrentLabels()` helper in TrainingBlockQueryTest and add `import java.util.HashSet`.

Add clarifying comments on the two person-scoped queries in TranscriptionBlockRepository
explaining that they use `MEMBER OF d.trainingLabels` — aligned with the pre-existing
`findEligibleKurrentBlocks()` pattern.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-04 15:30:11 +02:00
Marcel
42cf078bb6 feat(person-mention): update transcription placeholder with @mention discoverability hint 
Replaces the generic "Type text here..." placeholder in TranscriptionBlock
with copy that teaches the @Name trigger inline (Leonie Voss design review,
issue #370). No new DOM, no new i18n keys — just the three existing
`transcription_block_placeholder` strings.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-04 15:29:33 +02:00