marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat(conversations): filter person typeahead to correspondents of selected person #42

Merged
marcel merged 1 commits from feat/29-correspondent-typeahead into main 2026-03-20 21:26:35 +01:00
Conversation 0 Commits 1 Files Changed 7 +203 -7
marcel commented 2026-03-20 21:23:59 +01:00
Owner
Copy Link

Closes #29

Summary

  • New GET /api/persons/{id}/correspondents?q= endpoint returns the persons who share at least one document with the given person, ordered by number of shared documents descending, limited to 10
  • PersonTypeahead gains an optional restrictToCorrespondentsOf prop — when set, it fetches correspondents immediately on focus (no typing required) and uses the new endpoint for filtering while typing
  • Both person fields on /conversations pass each other's selected ID as restrictToCorrespondentsOf, so selecting Person A immediately restricts Person B's suggestions (and vice versa)

Test plan

  • ./mvnw test — 76 backend tests pass (3 new PersonServiceTest cases)
  • npm run test — 111 frontend tests pass (4 new PersonTypeahead correspondent-mode cases)
  • npm run lint && npm run check — no errors
  • Manual: select a person in the first field on /conversations, click the second field → dropdown opens immediately with their top correspondents
Closes #29 ## Summary - New `GET /api/persons/{id}/correspondents?q=` endpoint returns the persons who share at least one document with the given person, ordered by number of shared documents descending, limited to 10 - `PersonTypeahead` gains an optional `restrictToCorrespondentsOf` prop — when set, it fetches correspondents immediately on focus (no typing required) and uses the new endpoint for filtering while typing - Both person fields on `/conversations` pass each other's selected ID as `restrictToCorrespondentsOf`, so selecting Person A immediately restricts Person B's suggestions (and vice versa) ## Test plan - [ ] `./mvnw test` — 76 backend tests pass (3 new `PersonServiceTest` cases) - [ ] `npm run test` — 111 frontend tests pass (4 new `PersonTypeahead` correspondent-mode cases) - [ ] `npm run lint && npm run check` — no errors - [ ] Manual: select a person in the first field on `/conversations`, click the second field → dropdown opens immediately with their top correspondents
marcel added 1 commit 2026-03-20 21:24:00 +01:00
feat(conversations): filter person typeahead to correspondents of selected person
All checks were successful
CI / E2E Tests (push) Successful in 18m17s
Details
CI / Unit & Component Tests (push) Successful in 3m37s
Details
CI / Backend Unit Tests (push) Successful in 2m15s
Details
CI / Unit & Component Tests (pull_request) Successful in 2m12s
Details
CI / Backend Unit Tests (pull_request) Successful in 2m1s
Details
CI / E2E Tests (pull_request) Successful in 15m17s
Details
0525e66d55 
Closes #29

Backend:
- Add PersonRepository.findCorrespondents / findCorrespondentsWithFilter
  (native SQL, orders by shared document count DESC, limit 10)
- Add PersonService.findCorrespondents(personId, q) delegating to the
  correct repository method based on whether a query string is present
- Expose GET /api/persons/{id}/correspondents?q= in PersonController

Frontend:
- Add optional restrictToCorrespondentsOf prop to PersonTypeahead
- On focus with the prop set, fetch correspondents immediately (no typing
  required) — opens the dropdown showing top correspondents
- On input with the prop set, hit the correspondents endpoint with q= param
- Without the prop, keep existing /api/persons?q= behaviour unchanged
- Wire the prop bidirectionally in /conversations: sender restricts receiver
  and vice versa

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit 0525e66d55 into main 2026-03-20 21:26:35 +01:00
marcel deleted branch feat/29-correspondent-typeahead 2026-03-20 21:26:37 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#42
Delete Branch "feat/29-correspondent-typeahead"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?