fix(build): unbreak production build — /hilfe/transkription prerender unreachable behind /login [SUPERSEDED by #486] #485

Closed

marcel wants to merge 2 commits from fix/issue-472-prerender-entries into main

pull from: fix/issue-472-prerender-entries

merge into: marcel:main

marcel:main

marcel:feat/issue-533-mass-import-ux

marcel:feat/issue-527-unsaved-warning-new-pages

marcel:worktree-feat+issue-557-upload-artifact-v3-pin

marcel:worktree-chore+issue-556-drop-client-branches-coverage-gate

marcel:fix/issue-514-prerender-crawl-bakes-redirects

marcel:feat/issue-395-readme

marcel:feat/issue-345-bulk-mark-reviewed

marcel:feat/issue-344-bell-tooltip

marcel:feat/issue-341-annotieren-contrast

marcel:feat/issue-225-bulk-metadata-edit

marcel:feat/issue-317-bulk-upload

marcel:feat/issue-271-dashboard-redesign

marcel:docs/issue-240-mission-control-spec

marcel:refactor/issues-193-200

marcel:feat/issue-162-korrespondenz-redesign

marcel:feature/68-new-document-file-first

marcel:feat/81-discussion-discoverability

marcel:feat/62-document-bottom-panel

marcel:feature/56-backfill-file-hashes

marcel:feat/38-document-edit-history

marcel:fix/svelte5-test-delegation-and-login-auth

Conversation 0 Commits 2 Files Changed 3 +573 -204

marcel commented 2026-05-09 08:53:15 +02:00

Owner

Copy Link

Closes #472

Problem

npm run build exits non-zero because /hilfe/transkription is declared prerender = true but the SvelteKit prerender crawler is intercepted by hooks.server.ts before it can reach the route. The build logs:

Error: The following routes were marked as prerenderable, but were not prerendered because they were not found while crawling your app:
  - /hilfe/transkription

Fix

Option A from the issue — add an explicit prerender.entries declaration in svelte.config.js so SvelteKit renders the route directly without needing to crawl to it:

kit: {
    adapter: adapter(),
    prerender: { entries: ['/hilfe/transkription'] }
}

Also removes the misleading comment in +page.ts that claimed hooks.server.ts guards prerendered static files. It does not — the auth hook only runs for SSR requests; prerendered HTML is served as a static file by the reverse proxy.

CI gate

Adds npm run build after the test step in the unit-tests CI job. Without this gate, the fix has no regression protection — a future prerender = true route that becomes unreachable behind auth would fail silently again.

Test plan

• 1835 frontend unit tests pass (npm test)
• Build step added to CI — will validate prerender on every PR from now on
• CI run on this PR confirms npm run build exits 0 and /hilfe/transkription.html is produced

🤖 Generated with Claude Code

Closes #472 ## Problem `npm run build` exits non-zero because `/hilfe/transkription` is declared `prerender = true` but the SvelteKit prerender crawler is intercepted by `hooks.server.ts` before it can reach the route. The build logs: ``` Error: The following routes were marked as prerenderable, but were not prerendered because they were not found while crawling your app: - /hilfe/transkription ``` ## Fix **Option A** from the issue — add an explicit `prerender.entries` declaration in `svelte.config.js` so SvelteKit renders the route directly without needing to crawl to it: ```js kit: { adapter: adapter(), prerender: { entries: ['/hilfe/transkription'] } } ``` Also removes the misleading comment in `+page.ts` that claimed `hooks.server.ts` guards prerendered static files. It does not — the auth hook only runs for SSR requests; prerendered HTML is served as a static file by the reverse proxy. ## CI gate Adds `npm run build` after the test step in the `unit-tests` CI job. Without this gate, the fix has no regression protection — a future `prerender = true` route that becomes unreachable behind auth would fail silently again. ## Test plan - [x] 1835 frontend unit tests pass (`npm test`) - [x] Build step added to CI — will validate prerender on every PR from now on - [ ] CI run on this PR confirms `npm run build` exits 0 and `/hilfe/transkription.html` is produced 🤖 Generated with [Claude Code](https://claude.com/claude-code)

marcel added 17 commits 2026-05-09 08:53:16 +02:00

style: add mint-soft, line-soft, link-quiet, ink-4 tokens (#483) ... 495210052f

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

i18n: add reader header-bar keys, remove dashboard_badge_updated (#483) ... 2f48dfabd1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(dashboard): add ReaderHeaderBar with greeting + stat columns (TDD, #483) ... b5f9fcfdfd

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(dashboard): ReaderPersonChips → grid layout with mint-pill doc count (TDD, #483) ... ae6355d206

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(dashboard): ReaderRecentDocs compact card-head, mint-pill badge (TDD, #483) ... e1c78e3fbe

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(dashboard): ReaderRecentStories card-head link, touch targets (TDD, #483) ... e598f5a506

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(dashboard): ReaderDraftsModule mint left-border, card-head, row structure (TDD, #483) ... 60326cfb0a

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(dashboard): wire ReaderHeaderBar, grid content row, delete ReaderStatsStrip (#483) ... 43d36c898c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

style(dashboard): widen stat columns from px-3 to px-5 in ReaderHeaderBar ... 1c515a3145

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(dashboard): add dark:text-brand-mint to ReaderHeaderBar greeting and stat numbers ... a98ca0e5d3

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(dashboard): use bg-surface instead of bg-white in ReaderHeaderBar for dark mode ... 86d75d91be

bg-white is hardcoded #fff and only flips via the Tailwind dark: media-query variant.
bg-surface uses a CSS variable (--c-surface) that responds to both the media query
and the [data-theme='dark'] attribute, matching how all other cards on the page work.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(dashboard): replace text-brand-navy dark:text-brand-mint with text-ink ... cc20583ae6

text-ink uses --c-ink which is #012851 in light and #f0efe9 in dark, responding
to both @media and [data-theme='dark'] via CSS variable — no extra token needed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(dashboard): align ReaderPersonChips cards with /persons overview style ... 2283f733cc

- rounded, px-4 py-6, shadow-sm, gap-4 — matches overview card sizing
- hover: left accent border + shadow-md (matches overview hover)
- avatar: h-12 w-12, font-bold (djb2 palette colors kept)
- name: font-bold, group-hover:underline
- doc count: neutral bg-muted chip instead of mint pill

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

style(dashboard): increase doc row padding py-1.5 → py-3 in ReaderRecentDocs ... d464bca9f3

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(dashboard): replace new CSS tokens with existing equivalents ... 7c2c4741ab

mint-soft → accent-bg, line-soft → line-2, link-quiet → ink-2,
ink-4 removed (was never applied to any element).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(build): add prerender entry for /hilfe/transkription ... a7bbf2424f

The SvelteKit prerender crawler cannot reach this route because
hooks.server.ts redirects all non-public paths to /login before the
crawler follows links. Explicitly listing the route in kit.prerender.entries
tells SvelteKit to render it directly without crawling.

Also removes a misleading comment that claimed the auth hook guards
prerendered static files — it does not. Prerendered HTML is served as a
static file by the reverse proxy; hooks.server.ts only runs for SSR requests.

Closes #472

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ci: add npm run build step to unit-tests job ... 1ec4815e24

The prerender fix only prevents regression if the build is actually run in
CI. Without this gate, a future prerendered route that becomes unreachable
behind auth would fail silently until someone runs the build manually.

Fits after the test step in the existing unit-tests job — no new job needed
since node_modules is already cached for the Playwright container.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel referenced this pull request 2026-05-09 08:53:30 +02:00

fix(build): unbreak production build — /hilfe/transkription prerender unreachable behind /login #472

marcel changed title from fix(build): unbreak production build — /hilfe/transkription prerender unreachable behind /login to fix(build): unbreak production build — /hilfe/transkription prerender unreachable behind /login [SUPERSEDED by #486] 2026-05-09 08:54:48 +02:00

marcel closed this pull request 2026-05-09 08:54:49 +02:00

marcel referenced this pull request 2026-05-09 08:56:56 +02:00

fix(build): unbreak production build — /hilfe/transkription prerender unreachable behind /login #486

Some checks failed

Hide all checks

CI / Unit & Component Tests (push) Failing after 5m20s

Details

CI / OCR Service Tests (push) Successful in 51s

Details

CI / Backend Unit Tests (push) Failing after 3m28s

Details

CI / Unit & Component Tests (pull_request) Failing after 4m20s

Details

CI / OCR Service Tests (pull_request) Successful in 52s

Details

CI / Backend Unit Tests (pull_request) Failing after 3m17s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

refactor

Code restructuring without behaviour change

security

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#485