marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(build): unbreak production build — /hilfe/transkription prerender unreachable behind /login #486

Merged
marcel merged 2 commits from fix/issue-472-prerender-entries-v2 into main 2026-05-09 14:25:55 +02:00
Conversation 7 Commits 2 Files Changed 3 +8 -3

2 Commits

Author SHA1 Message Date
Marcel
997fd5b991 ci: add npm run build step to unit-tests job
Some checks failed
CI / Unit & Component Tests (push) Failing after 4m17s
Details
CI / OCR Service Tests (push) Successful in 47s
Details
CI / Backend Unit Tests (push) Failing after 3m17s
Details
CI / Unit & Component Tests (pull_request) Failing after 4m5s
Details
CI / OCR Service Tests (pull_request) Successful in 39s
Details
CI / Backend Unit Tests (pull_request) Failing after 3m21s
Details 
The prerender fix only prevents regression if the build is actually run in
CI. Without this gate, a future prerendered route that becomes unreachable
behind auth would fail silently until someone runs the build manually.

Fits after the test step in the existing unit-tests job — no new job needed
since node_modules is already cached for the Playwright container.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-09 08:54:31 +02:00
Marcel
ad1c8ab947 fix(build): add prerender entry for /hilfe/transkription 
The SvelteKit prerender crawler cannot reach this route because
hooks.server.ts redirects all non-public paths to /login before the
crawler follows links. Explicitly listing the route in kit.prerender.entries
tells SvelteKit to render it directly without crawling.

Also removes a misleading comment that claimed the auth hook guards
prerendered static files — it does not. Prerendered HTML is served as a
static file by the reverse proxy; hooks.server.ts only runs for SSR requests.

Closes #472

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-05-09 08:54:31 +02:00