fix(pdf-viewer): remove banned vi.mock('pdfjs-dist') — ADR 012 enforcement (issue #546) #549

Merged

marcel merged 4 commits from worktree-feat+issue-546-pdf-viewer-test-fix into main 2026-05-12 12:32:24 +02:00

Conversation 7 Commits 4 Files Changed 5 +85 -89

4 Commits

Author	SHA1	Message	Date
Marcel	f938971292	ci(unit-tests): add early grep check for banned vi.mock pdfjs-dist pattern ... Adds a static grep step that runs after Lint and before the test suite. Fails in ~1 s if any file under frontend/src/ contains the banned vi.mock('pdfjs-dist' pattern, catching the regression before Playwright spins up. Belt-and-suspenders with the ESLint rule (ADR 012). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 12:19:01 +02:00
Marcel	c1e5732fad	refactor(eslint): ban vi.mock('pdfjs-dist', ...) in spec/test files — ADR 012 ... Adds a no-restricted-syntax rule scoped to *.spec.ts / *.test.ts that flags any vi.mock call whose first argument starts with 'pdfjs-dist'. Turns the ~2-min CI wait into an immediate lint error on save. Updates ADR 012 Enforcement section to document the rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 12:18:28 +02:00
Marcel	32d02b79f7	test(pdf-viewer): consolidate spec.ts into test.ts — absorb page-counter test, delete spec ... Absorbs the three tests from PdfViewer.svelte.spec.ts (nav buttons, zoom controls, page counter) into the loaded-state describe in test.ts, then deletes the now-empty spec file. One spec file per component. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 12:17:56 +02:00
Marcel	1f7f6bde15	test(pdf-viewer): port PdfViewer.svelte.test.ts to libLoader prop injection — remove vi.mock ... Removes both vi.mock('pdfjs-dist', …) calls that caused the birpc teardown race (ADR 012). Replaces with static import + makeFakeLibLoader() helper injected via the libLoader prop on every render() call. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 12:17:25 +02:00