marcel/familienarchiv
1
0
Fork 0
Code Issues 118 Pull Requests 2 Actions 4 Packages Projects Releases Wiki Activity

fix(tests): use native element clicks in layout dropdown spec #562

Closed
marcel wants to merge 1 commits from worktree-feat+issue-557-upload-artifact-v3-pin into main
pull from: worktree-feat+issue-557-upload-artifact-v3-pin
merge into: marcel:main
Conversation 0 Commits 1 Files Changed 1 +7 -7
marcel commented 2026-05-14 10:59:57 +02:00
Owner
Copy Link

Summary

  • CDP-based Playwright locator.click() calls don't reliably trigger Svelte 5 onclick handlers — this was documented and fixed in commit 0c765d81 across 13 other specs, but the layout dropdown tests were missed in that pass
  • Replaces all 4 await page.getByRole('button', { name: /MM/ }).click() calls with ((await locator.element()) as HTMLElement).click() (native DOM click)
  • Replaces userEvent.keyboard('{Escape}') with btnEl.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true })) dispatched on the button element so it bubbles to the parent div's onkeydown handler
  • Removes now-unused userEvent import

Test Plan

  • CI browser test Layout – user dropdown > profile link points to /profile no longer fails intermittently
  • All 5 dropdown tests in layout.svelte.spec.ts pass consistently
## Summary - CDP-based Playwright `locator.click()` calls don't reliably trigger Svelte 5 `onclick` handlers — this was documented and fixed in commit `0c765d81` across 13 other specs, but the layout dropdown tests were missed in that pass - Replaces all 4 `await page.getByRole('button', { name: /MM/ }).click()` calls with `((await locator.element()) as HTMLElement).click()` (native DOM click) - Replaces `userEvent.keyboard('{Escape}')` with `btnEl.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }))` dispatched on the button element so it bubbles to the parent div's `onkeydown` handler - Removes now-unused `userEvent` import ## Test Plan - [ ] CI browser test `Layout – user dropdown > profile link points to /profile` no longer fails intermittently - [ ] All 5 dropdown tests in `layout.svelte.spec.ts` pass consistently
marcel added 1 commit 2026-05-14 11:02:16 +02:00
fix(tests): use native element clicks in layout dropdown spec
Some checks failed
CI / Unit & Component Tests (pull_request) Has been cancelled
Details
CI / OCR Service Tests (pull_request) Has been cancelled
Details
CI / Backend Unit Tests (pull_request) Has been cancelled
Details
CI / fail2ban Regex (pull_request) Has been cancelled
Details
CI / Compose Bucket Idempotency (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (push) Has been cancelled
Details
CI / OCR Service Tests (push) Has been cancelled
Details
CI / Backend Unit Tests (push) Has been cancelled
Details
CI / fail2ban Regex (push) Has been cancelled
Details
CI / Compose Bucket Idempotency (push) Has been cancelled
Details
76db26d68b 
CDP-based Playwright clicks (locator.click()) do not reliably trigger
Svelte 5 onclick handlers — documented in commit 0c765d81 which fixed
13 other specs. The layout dropdown tests were missed in that pass.

Applies the same pattern: ((await locator.element()) as HTMLElement).click()
for button interactions, and native KeyboardEvent dispatch for the Escape
test (dispatched on the button so it bubbles to the parent div's onkeydown).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel force-pushed worktree-feat+issue-557-upload-artifact-v3-pin from 948a68c280 to 76db26d68b 2026-05-14 11:02:16 +02:00 Compare
marcel closed this pull request 2026-05-14 11:04:32 +02:00
Some checks failed
CI / Unit & Component Tests (pull_request) Has been cancelled
Details
CI / OCR Service Tests (pull_request) Has been cancelled
Details
CI / Backend Unit Tests (pull_request) Has been cancelled
Details
CI / fail2ban Regex (pull_request) Has been cancelled
Details
CI / Compose Bucket Idempotency (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (push) Has been cancelled
Details
CI / OCR Service Tests (push) Has been cancelled
Details
CI / Backend Unit Tests (push) Has been cancelled
Details
CI / fail2ban Regex (push) Has been cancelled
Details
CI / Compose Bucket Idempotency (push) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#562
Delete Branch "worktree-feat+issue-557-upload-artifact-v3-pin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?