marcel/familienarchiv
1
0
Fork 0
Code Issues 118 Pull Requests 2 Actions 4 Packages Projects Releases Wiki Activity

fix(ci): run client coverage even when server coverage fails #564

Merged
marcel merged 1 commits from fix/test-coverage-client-skipped-on-server-failure into main 2026-05-14 11:07:35 +02:00
Conversation 0 Commits 1 Files Changed 2 +2 -2
marcel commented 2026-05-14 11:05:54 +02:00
Owner
Copy Link

Summary

  • Replaces && with ; in the test:coverage npm script so the client vitest run is never short-circuited by a server run failure (test failure or threshold violation)
  • Without this fix, the CI upload-artifact step only ever sees coverage/server when the server run exits non-zero
  • Updates the stale frontend/CLAUDE.md comment that described test:coverage as "server project only"

Test plan

  • CI unit-tests job passes: both coverage/server and coverage/client appear in the uploaded artifact
  • Verify that a deliberate server threshold failure no longer prevents coverage/client from being generated

🤖 Generated with Claude Code

## Summary - Replaces `&&` with `;` in the `test:coverage` npm script so the client vitest run is never short-circuited by a server run failure (test failure or threshold violation) - Without this fix, the CI upload-artifact step only ever sees `coverage/server` when the server run exits non-zero - Updates the stale `frontend/CLAUDE.md` comment that described `test:coverage` as "server project only" ## Test plan - [ ] CI `unit-tests` job passes: both `coverage/server` and `coverage/client` appear in the uploaded artifact - [ ] Verify that a deliberate server threshold failure no longer prevents `coverage/client` from being generated 🤖 Generated with [Claude Code](https://claude.com/claude-code)
marcel added 1 commit 2026-05-14 11:05:54 +02:00
fix(ci): run client coverage even when server coverage fails
Some checks failed
CI / Unit & Component Tests (push) Has been cancelled
Details
CI / OCR Service Tests (push) Has been cancelled
Details
CI / Backend Unit Tests (push) Has been cancelled
Details
CI / fail2ban Regex (push) Has been cancelled
Details
CI / Compose Bucket Idempotency (push) Has been cancelled
Details
CI / Unit & Component Tests (pull_request) Has been cancelled
Details
CI / OCR Service Tests (pull_request) Has been cancelled
Details
CI / Backend Unit Tests (pull_request) Has been cancelled
Details
CI / fail2ban Regex (pull_request) Has been cancelled
Details
CI / Compose Bucket Idempotency (pull_request) Has been cancelled
Details
16b500ae3d 
Replace && with ; in test:coverage so the client vitest run is not
short-circuited when the server run exits non-zero (e.g. threshold
violation or test failure). Without this the upload-artifact step
only ever sees coverage/server.

Also updates the stale CLAUDE.md comment that said server-only.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit f727429699 into main 2026-05-14 11:07:35 +02:00
marcel deleted branch fix/test-coverage-client-skipped-on-server-failure 2026-05-14 11:07:35 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#564
Delete Branch "fix/test-coverage-client-skipped-on-server-failure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?