marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(ci): run svelte-kit sync before lint to fix cache-hit tsconfig miss #568

Merged
marcel merged 1 commits from worktree-fix+ci-svelte-kit-sync-before-lint into main 2026-05-14 12:09:04 +02:00
Conversation 0 Commits 1 Files Changed 1 +4
marcel commented 2026-05-14 12:08:05 +02:00
Owner
Copy Link

Problem

CI lint fails on main (and all branches sharing the same package-lock.json hash) with:

1:1  error  Resolve error: Tsconfig not found .../frontend/.svelte-kit/tsconfig.json

frontend/tsconfig.json extends .svelte-kit/tsconfig.json, which is generated by svelte-kit sync. In CI, svelte-kit sync only runs as a side-effect of npm ci (via the prepare lifecycle script). But npm ci is gated:

if: steps.node-modules-cache.outputs.cache-hit != 'true'

On a cache miss (first run for a given package-lock.json hash): npm ci runs → prepare → svelte-kit sync → .svelte-kit/tsconfig.json exists → lint passes.

On a cache hit (every subsequent run across all branches): npm ci is skipped → svelte-kit sync never runs → .svelte-kit/tsconfig.json missing → ESLint fails at tsconfig resolution.

This explains why the previous PR was green (cache-miss run) but main and all other branches are now broken (cache-warm runs).

Fix

Add an unconditional svelte-kit sync step after Paraglide compile and before Lint. It always runs regardless of cache state, takes ~1 second, and is idempotent.

Test plan

  • CI on this PR passes the Lint step with a warm node_modules cache
## Problem CI lint fails on main (and all branches sharing the same `package-lock.json` hash) with: ``` 1:1 error Resolve error: Tsconfig not found .../frontend/.svelte-kit/tsconfig.json ``` `frontend/tsconfig.json` extends `.svelte-kit/tsconfig.json`, which is generated by `svelte-kit sync`. In CI, `svelte-kit sync` only runs as a side-effect of `npm ci` (via the `prepare` lifecycle script). But `npm ci` is gated: ```yaml if: steps.node-modules-cache.outputs.cache-hit != 'true' ``` **On a cache miss** (first run for a given `package-lock.json` hash): `npm ci` runs → `prepare` → `svelte-kit sync` → `.svelte-kit/tsconfig.json` exists → lint passes. **On a cache hit** (every subsequent run across all branches): `npm ci` is skipped → `svelte-kit sync` never runs → `.svelte-kit/tsconfig.json` missing → ESLint fails at tsconfig resolution. This explains why the previous PR was green (cache-miss run) but main and all other branches are now broken (cache-warm runs). ## Fix Add an unconditional `svelte-kit sync` step after Paraglide compile and before Lint. It always runs regardless of cache state, takes ~1 second, and is idempotent. ## Test plan - [ ] CI on this PR passes the Lint step with a warm node_modules cache
marcel added 1 commit 2026-05-14 12:08:05 +02:00
fix(ci): run svelte-kit sync before lint to fix cache-hit tsconfig miss
All checks were successful
CI / Unit & Component Tests (pull_request) Successful in 3m8s
Details
CI / OCR Service Tests (pull_request) Successful in 17s
Details
CI / Backend Unit Tests (pull_request) Successful in 4m25s
Details
CI / fail2ban Regex (pull_request) Successful in 38s
Details
CI / Compose Bucket Idempotency (pull_request) Successful in 57s
Details
CI / Unit & Component Tests (push) Successful in 3m7s
Details
CI / OCR Service Tests (push) Successful in 17s
Details
CI / Backend Unit Tests (push) Successful in 4m15s
Details
CI / fail2ban Regex (push) Successful in 39s
Details
CI / Compose Bucket Idempotency (push) Successful in 58s
Details
5646e739c2 
When the node_modules cache hits, npm ci is skipped and the prepare
lifecycle (svelte-kit sync) never runs. frontend/tsconfig.json extends
.svelte-kit/tsconfig.json which only exists after svelte-kit sync —
so ESLint fails at tsconfig resolution on every cache-warm run.

Adding an unconditional svelte-kit sync step after Paraglide compile
and before Lint ensures .svelte-kit/tsconfig.json is always present
regardless of cache state.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit 5646e739c2 into main 2026-05-14 12:09:04 +02:00
marcel deleted branch worktree-fix+ci-svelte-kit-sync-before-lint 2026-05-14 12:09:04 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#568
Delete Branch "worktree-fix+ci-svelte-kit-sync-before-lint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?