marcel/familienarchiv
1
0
Fork 0
Code Issues 115 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(eslint): remove projectService from Svelte parser — restores fast lint #600

Merged
marcel merged 1 commits from fix/eslint-projectservice-slow-lint into main 2026-05-15 20:10:09 +02:00
Conversation 0 Commits 1 Files Changed 1 -1
marcel commented 2026-05-15 20:10:03 +02:00
Owner
Copy Link

Summary

  • Removes projectService: true from the Svelte-files ESLint parser config, restoring fast CI lint (~30s vs 7+ min).

Root cause

5646e739 added an unconditional svelte-kit sync step before linting so .svelte-kit/tsconfig.json always exists (correct fix). This inadvertently activated projectService: true on every run — ESLint now builds the full TypeScript language service for all .svelte files.

Before that commit, cache-hit runs had no tsconfig.json, so projectService fell back silently to AST-only parsing — fast. Now it always resolves the project and does full type-aware compilation — slow.

Why projectService is not needed

All rules in the Svelte-specific config block are AST-selector-based no-restricted-syntax checks. None of them require type information. parser: ts.parser is still present and sufficient for correct <script lang="ts"> parsing.

Test plan

  • npm run lint passes locally after the change
  • CI lint step completes in under 2 minutes

🤖 Generated with Claude Code

## Summary - Removes `projectService: true` from the Svelte-files ESLint parser config, restoring fast CI lint (~30s vs 7+ min). ## Root cause `5646e739` added an unconditional `svelte-kit sync` step before linting so `.svelte-kit/tsconfig.json` always exists (correct fix). This inadvertently activated `projectService: true` on every run — ESLint now builds the full TypeScript language service for all `.svelte` files. Before that commit, cache-hit runs had no `tsconfig.json`, so `projectService` fell back silently to AST-only parsing — fast. Now it always resolves the project and does full type-aware compilation — slow. ## Why projectService is not needed All rules in the Svelte-specific config block are AST-selector-based `no-restricted-syntax` checks. None of them require type information. `parser: ts.parser` is still present and sufficient for correct `<script lang="ts">` parsing. ## Test plan - [x] `npm run lint` passes locally after the change - [ ] CI lint step completes in under 2 minutes 🤖 Generated with [Claude Code](https://claude.com/claude-code)
marcel added 1 commit 2026-05-15 20:10:03 +02:00
fix(eslint): remove projectService from Svelte parser — restores fast lint
Some checks failed
CI / OCR Service Tests (pull_request) Has been cancelled
Details
CI / Backend Unit Tests (pull_request) Has been cancelled
Details
CI / fail2ban Regex (pull_request) Has been cancelled
Details
CI / Compose Bucket Idempotency (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (push) Successful in 3m23s
Details
CI / OCR Service Tests (push) Successful in 17s
Details
CI / Backend Unit Tests (push) Successful in 2m37s
Details
CI / fail2ban Regex (push) Successful in 44s
Details
CI / Compose Bucket Idempotency (push) Successful in 1m1s
Details
nightly / deploy-staging (push) Failing after 2m33s
Details
23515b8542 
5646e739 added svelte-kit sync before lint so .svelte-kit/tsconfig.json
always exists. This activated projectService: true for every run, which
builds the full TypeScript language service for all .svelte files and
caused CI lint to take 7+ minutes.

None of the rules in the Svelte-specific block need type information —
they are all AST-selector-based no-restricted-syntax checks. Removing
projectService restores the previous fast path without losing any lint
coverage.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marcel merged commit 23515b8542 into main 2026-05-15 20:10:09 +02:00
marcel deleted branch fix/eslint-projectservice-slow-lint 2026-05-15 20:10:09 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#600
Delete Branch "fix/eslint-projectservice-slow-lint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?