feat: discussion sub-tab navigation for annotation threads (#60) #63

Merged

marcel merged 17 commits from feat/60-discussion-panel-tabs into main 2026-03-25 12:38:45 +01:00

Conversation 0 Commits 17 Files Changed 14 +1704 -916

marcel commented 2026-03-24 22:48:03 +01:00

Owner

Copy Link

Summary

• Adds two sub-tabs inside the Diskussion panel: Diskussion (document thread, with comment-count badge) and Annotation · Seite N (annotation thread, only when an annotation is active)
• Clicking an annotation auto-switches to the Annotation sub-tab; clicking Diskussion sub-tab deselects the annotation
• Escape key clears the active annotation, or collapses the panel if no annotation is active
• activeAnnotationPage lifted from PdfViewer → DocumentViewer → page → DocumentBottomPanel → PanelDiscussion so the tab label shows the correct page number

Test plan

• Open a document with PDF and existing annotations
• Click an annotation → panel opens to Diskussion tab, Annotation sub-tab is active with correct "Annotation · Seite N" label
• Click the Diskussion sub-tab → annotation is deselected, document thread is shown, annotation highlights clear on PDF
• Click annotation again → Annotation sub-tab re-activates
• Press Escape → annotation is deselected (first Escape); press again → panel collapses
• Comment count badge on Diskussion sub-tab matches actual thread count

🤖 Generated with Claude Code

## Summary - Adds two sub-tabs inside the Diskussion panel: **Diskussion** (document thread, with comment-count badge) and **Annotation · Seite N** (annotation thread, only when an annotation is active) - Clicking an annotation auto-switches to the Annotation sub-tab; clicking Diskussion sub-tab deselects the annotation - Escape key clears the active annotation, or collapses the panel if no annotation is active - `activeAnnotationPage` lifted from PdfViewer → DocumentViewer → page → DocumentBottomPanel → PanelDiscussion so the tab label shows the correct page number ## Test plan - [ ] Open a document with PDF and existing annotations - [ ] Click an annotation → panel opens to Diskussion tab, Annotation sub-tab is active with correct "Annotation · Seite N" label - [ ] Click the Diskussion sub-tab → annotation is deselected, document thread is shown, annotation highlights clear on PDF - [ ] Click annotation again → Annotation sub-tab re-activates - [ ] Press Escape → annotation is deselected (first Escape); press again → panel collapses - [ ] Comment count badge on Diskussion sub-tab matches actual thread count 🤖 Generated with [Claude Code](https://claude.com/claude-code)

marcel changed target branch from feat/62-document-bottom-panel to main 2026-03-25 11:16:42 +01:00

marcel added 16 commits 2026-03-25 11:16:42 +01:00

feat(frontend): add floating bottom panel to document detail page ... 8c2bdbd777

Replaces the left sidebar layout with:
- Full-viewport PDF/image viewer (never resizes, position: absolute)
- Fixed floating bottom panel with tabs: Metadaten, Transkription,
  Diskussion, Verlauf
- Compact top bar with title, date · sender → receivers row, and
  Annotieren / Edit / Download actions
- Drag-to-resize panel with localStorage persistence of open/height/tab
- Panel opens automatically to Diskussion when an annotation is clicked
- Documents without a file default to showing the Metadaten tab

New components: DocumentTopBar, DocumentViewer, DocumentBottomPanel,
PanelMetadata, PanelTranscription, PanelDiscussion, PanelHistory

PdfViewer: annotateMode and activeAnnotationId lifted to bindable props;
AnnotationCommentPanel removed (discussion moves to the Diskussion tab).

Closes #62
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): add discussion sub-tab navigation for annotation threads ... ecfd80bf9a

Within the Diskussion panel tab, show two sub-tabs when an annotation is
active: «Diskussion» (document-level thread, with comment-count badge) and
«Annotation · Seite N» (annotation-specific thread).

Behaviour:
- Clicking an annotation auto-switches to the Annotation sub-tab
- Clicking the Diskussion sub-tab deselects the annotation and returns to
  the document thread
- Escape clears the active annotation (or collapses the panel if none)
- activeAnnotationPage is now lifted from PdfViewer → DocumentViewer →
  page → DocumentBottomPanel → PanelDiscussion so the tab label shows the
  correct page number

Closes #60
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): keep annotation tab after switching to document discussion ... ee85ce4668

Clicking the Diskussion sub-tab no longer deselects the active annotation,
so the Annotation tab stays visible and accessible for easy toggling back.

The annotation is cleared only via Escape or clicking elsewhere on the PDF.
Removes the now-unused onClearAnnotation callback chain.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): lock document page to viewport with position: fixed ... 8519fbb48a

The global layout wraps pages in min-h-screen + main.py-6, which pushed
the h-screen document container below the sticky nav and caused page-level
scrolling. Switching to fixed inset-0 z-50 fully escapes the layout flow:

- DocumentTopBar always visible (no scrolling it away)
- PDF controls always visible
- Only the PDF canvas area scrolls
- DocumentBottomPanel moved inside the fixed container (logically grouped)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): add annotation visibility toggle to PDF toolbar ... c9b4e6dad4

Eye/eye-slash button in the PDF controls bar lets the user hide all
annotation highlights to read the document unobstructed and show them again
with one click.

- Button only renders when at least one annotation exists
- Active state (hidden) highlighted with brand-mint/bg-white/10 so the
  current state is always clear
- i18n keys added for de/en/es

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): move annotation toggle into PDF toolbar and add text label ... a392e85f43

Button was rendered outside the controls bar (below the toolbar). Moved it
inside so it stays in the same row as zoom and page controls. Added a text
label next to the eye icon so the action is self-descriptive.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): open bottom panel at full height (80vh) by default ... f18649fb79

Panel now opens to 80 % of the viewport height so the user can immediately
read comments and metadata without having to drag it up first.
The user can drag the top handle down to make it smaller; that size is
persisted to localStorage and restored on the next visit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): open bottom panel to full height below the document header ... 1eb2659ba0

Instead of an arbitrary 80 % cap, the panel now measures the actual
DocumentTopBar height at open time and fills the remaining viewport
exactly — so the PDF is fully covered and the drawer reaches right up
to the header. Drag-to-shrink still works as before.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): show history diff inline below the selected version ... 65457a5650

Instead of rendering the diff at the bottom of the list (requiring the user
to scroll down), it now appears directly below whichever version item was
clicked. Compare-mode diff stays at the bottom of the compare form where it
makes sense, since it is not tied to a specific list item.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): add Note-Add-MD icon to the Annotieren button ... db9d8ed457

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): correct path for Note-Add-MD icon on Annotieren button ... c19f7b3b1a

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): close bottom panel when entering annotate mode ... 142f296255

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): restore global nav bar on document detail page ... 5ea5590c89

The document viewer container was using fixed inset-0 z-50 which
covered the sticky global nav bar. Now measures nav height at mount
and offsets the container top accordingly, dropping z-index to z-40.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): always start with panel closed on document open ... 10783fdb55

Removed localStorage persistence for the open/closed state so the PDF
is always visible first when navigating to a document. Height and active
tab are still remembered across visits.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(frontend): move annotation comments to right-side panel ... f71712ab4b

Annotation threads now open in a slide-in side panel (320 px, right
edge of the PDF viewer) instead of expanding the bottom drawer.
The PDF stays visible while the user reads and writes annotation
comments.

- Add AnnotationSidePanel component (absolute-positioned, CSS slide
  transition, keyed CommentThread, close via X or Escape)
- Remove the $effect that opened the bottom drawer on annotation click
- Simplify PanelDiscussion back to document-level thread only (no
  annotation sub-tabs)
- Remove annotation-related props from DocumentBottomPanel and
  PanelDiscussion

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(frontend): fix side panel X button click falling through to PDF toolbar ... dd360ade8b

pointer-events-none and pointer-events-auto were both present as static
and conditional Tailwind classes simultaneously. CSS specificity meant
pointer-events-none always won, so clicks passed through to the
annotation toggle button behind the panel. Now pointer-events-none is
only applied when the panel is hidden (translated off-screen).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel added 1 commit 2026-03-25 12:33:03 +01:00

merge(frontend): resolve conflicts with main — integrate fileHash feature into panel architecture ... 9aa98b4fb6

Keep the new bottom-panel / AnnotationSidePanel architecture from this branch
while pulling in the documentFileHash / visibleAnnotations filter that was added
on main. Thread documentFileHash through DocumentViewer so outdated-annotation
filtering works end-to-end.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel merged commit 9aa98b4fb6 into main 2026-03-25 12:38:45 +01:00

marcel deleted branch feat/60-discussion-panel-tabs 2026-03-25 12:38:47 +01:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

refactor

Code restructuring without behaviour change

security

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#63