feat: discussion sub-tab navigation for annotation threads (#60) #63
@@ -50,7 +50,6 @@ type Props = {
|
||||
activeTab: Tab;
|
||||
activeAnnotationId: string | null;
|
||||
activeAnnotationPage: number | null;
|
||||
onClearAnnotation?: () => void;
|
||||
onAnnotationCommentCountChange?: (annotationId: string, count: number) => void;
|
||||
};
|
||||
|
||||
@@ -65,7 +64,6 @@ let {
|
||||
activeTab = $bindable(),
|
||||
activeAnnotationId,
|
||||
activeAnnotationPage,
|
||||
onClearAnnotation,
|
||||
onAnnotationCommentCountChange
|
||||
}: Props = $props();
|
||||
|
||||
@@ -191,7 +189,6 @@ const panelHeight = $derived(open ? height : MIN_HEIGHT);
|
||||
canComment={canComment}
|
||||
currentUserId={currentUserId}
|
||||
canAdmin={canAdmin}
|
||||
onClearAnnotation={onClearAnnotation}
|
||||
onAnnotationCommentCountChange={onAnnotationCommentCountChange}
|
||||
/>
|
||||
{:else if activeTab === 'history'}
|
||||
|
||||
@@ -29,7 +29,6 @@ type Props = {
|
||||
canComment: boolean;
|
||||
currentUserId: string | null;
|
||||
canAdmin: boolean;
|
||||
onClearAnnotation?: () => void;
|
||||
onAnnotationCommentCountChange?: (annotationId: string, count: number) => void;
|
||||
};
|
||||
|
||||
@@ -41,7 +40,6 @@ let {
|
||||
canComment,
|
||||
currentUserId,
|
||||
canAdmin,
|
||||
onClearAnnotation,
|
||||
onAnnotationCommentCountChange
|
||||
}: Props = $props();
|
||||
|
||||
@@ -64,7 +62,6 @@ $effect(() => {
|
||||
|
||||
function selectDocumentTab() {
|
||||
activeSubTab = 'document';
|
||||
onClearAnnotation?.();
|
||||
}
|
||||
|
||||
function selectAnnotationTab() {
|
||||
|
||||
@@ -162,8 +162,4 @@ $effect(() => {
|
||||
bind:activeTab={activeTab}
|
||||
activeAnnotationId={activeAnnotationId}
|
||||
activeAnnotationPage={activeAnnotationPage}
|
||||
onClearAnnotation={() => {
|
||||
activeAnnotationId = null;
|
||||
activeAnnotationPage = null;
|
||||
}}
|
||||
/>
|
||||
|
||||
Reference in New Issue
Block a user