marcel/familienarchiv
1
0
Fork 0
Code Issues 103 Pull Requests 2 Actions 1 Packages Projects Releases Wiki Activity

feat: discussion sub-tab navigation for annotation threads (#60) #63

Merged
marcel merged 17 commits from feat/60-discussion-panel-tabs into main 2026-03-25 12:38:45 +01:00
Conversation 0 Commits 17 Files Changed 14 -10
3 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ee85ce4668 - Show all commits

3
frontend/src/lib/components/DocumentBottomPanel.svelte
View File

@@ -50,7 +50,6 @@ type Props = {
activeTab: Tab; activeTab: Tab;
activeAnnotationId: string | null; activeAnnotationId: string | null;
activeAnnotationPage: number | null; activeAnnotationPage: number | null;
onClearAnnotation?: () => void;
onAnnotationCommentCountChange?: (annotationId: string, count: number) => void; onAnnotationCommentCountChange?: (annotationId: string, count: number) => void;
}; };
@@ -65,7 +64,6 @@ let {
activeTab = $bindable(), activeTab = $bindable(),
activeAnnotationId, activeAnnotationId,
activeAnnotationPage, activeAnnotationPage,
onClearAnnotation,
onAnnotationCommentCountChange onAnnotationCommentCountChange
}: Props = $props(); }: Props = $props();
@@ -191,7 +189,6 @@ const panelHeight = $derived(open ? height : MIN_HEIGHT);
canComment={canComment} canComment={canComment}
currentUserId={currentUserId} currentUserId={currentUserId}
canAdmin={canAdmin} canAdmin={canAdmin}
onClearAnnotation={onClearAnnotation}
onAnnotationCommentCountChange={onAnnotationCommentCountChange} onAnnotationCommentCountChange={onAnnotationCommentCountChange}
/> />
{:else if activeTab === 'history'} {:else if activeTab === 'history'}

3
frontend/src/lib/components/PanelDiscussion.svelte
View File

@@ -29,7 +29,6 @@ type Props = {
canComment: boolean; canComment: boolean;
currentUserId: string | null; currentUserId: string | null;
canAdmin: boolean; canAdmin: boolean;
onClearAnnotation?: () => void;
onAnnotationCommentCountChange?: (annotationId: string, count: number) => void; onAnnotationCommentCountChange?: (annotationId: string, count: number) => void;
}; };
@@ -41,7 +40,6 @@ let {
canComment, canComment,
currentUserId, currentUserId,
canAdmin, canAdmin,
onClearAnnotation,
onAnnotationCommentCountChange onAnnotationCommentCountChange
}: Props = $props(); }: Props = $props();
@@ -64,7 +62,6 @@ $effect(() => {
function selectDocumentTab() { function selectDocumentTab() {
activeSubTab = 'document'; activeSubTab = 'document';
onClearAnnotation?.();
} }
function selectAnnotationTab() { function selectAnnotationTab() {

4
frontend/src/routes/documents/[id]/+page.svelte
View File

@@ -162,8 +162,4 @@ $effect(() => {
bind:activeTab={activeTab} bind:activeTab={activeTab}
activeAnnotationId={activeAnnotationId} activeAnnotationId={activeAnnotationId}
activeAnnotationPage={activeAnnotationPage} activeAnnotationPage={activeAnnotationPage}
onClearAnnotation={() => {
activeAnnotationId = null;
activeAnnotationPage = null;
}}
/> />