feat(geschichten): document filter chip — visible UI for ?documentId= filter #811

Merged

marcel merged 8 commits from feat/issue-803-geschichten-document-filter-chip into feat/issue-750-lesereisen-data-model 2026-06-12 10:45:50 +02:00

Conversation 0 Commits 8 Files Changed 15 +2579 -59

marcel commented 2026-06-12 09:55:51 +02:00

Owner

Copy Link

Closes #803

Summary

• Loader — UUID-validates ?documentId=, fetches document title from GET /api/documents/{id} in parallel with person resolution; returns { id, title } | null. 403/404 fail-closed to { id, title: null } (no throw, no logging). Invalid UUIDs pass through to the list API unchanged (option B → backend 400).
• DocumentFilterChip.svelte — new two-zone chip: Gefiltert nach Brief: prefix + font-serif italic title, line-clamp-2 sm:truncate sm:max-w-[16rem], separate ≥44 px touch-target remove button, aria-live="polite".
• +page.svelte — chip wired into filter bar; emptyMessage extracted as $derived.by() with person-wins precedence; removeDocument navigation helper strips ?documentId= and preserves active person filters.
• i18n — 3 new keys added to de/en/es: geschichten_filter_document_chip, geschichten_filter_remove_document_chip, geschichten_empty_for_document.

Test plan

• 34 tests across 3 spec files all pass (npx vitest run --project=client src/routes/geschichten/... + --project=server)
• npm run lint clean
• Verify chip renders when navigating from a document detail page with ?documentId= in the URL
• Verify removing the chip clears documentId but preserves active personId params
• Verify empty-state shows "Noch keine Geschichten zu diesem Brief" when no results and document filter is active

🤖 Generated with Claude Code

Closes #803 ## Summary - **Loader** — UUID-validates `?documentId=`, fetches document title from `GET /api/documents/{id}` in parallel with person resolution; returns `{ id, title } | null`. 403/404 fail-closed to `{ id, title: null }` (no throw, no logging). Invalid UUIDs pass through to the list API unchanged (option B → backend 400). - **DocumentFilterChip.svelte** — new two-zone chip: `Gefiltert nach Brief:` prefix + `font-serif italic` title, `line-clamp-2 sm:truncate sm:max-w-[16rem]`, separate ≥44 px touch-target remove button, `aria-live="polite"`. - **+page.svelte** — chip wired into filter bar; `emptyMessage` extracted as `$derived.by()` with person-wins precedence; `removeDocument` navigation helper strips `?documentId=` and preserves active person filters. - **i18n** — 3 new keys added to de/en/es: `geschichten_filter_document_chip`, `geschichten_filter_remove_document_chip`, `geschichten_empty_for_document`. ## Test plan - [ ] 34 tests across 3 spec files all pass (`npx vitest run --project=client src/routes/geschichten/...` + `--project=server`) - [ ] `npm run lint` clean - [ ] Verify chip renders when navigating from a document detail page with `?documentId=` in the URL - [ ] Verify removing the chip clears `documentId` but preserves active `personId` params - [ ] Verify empty-state shows "Noch keine Geschichten zu diesem Brief" when no results and document filter is active 🤖 Generated with [Claude Code](https://claude.ai/claude-code)

marcel added 7 commits 2026-06-12 10:07:04 +02:00

docs(timeline): add family timeline (Zeitstrahl) design spec ... 57aeb1ec7b

Hand-curated, year-banded vertical timeline weaving derived person
life-events, curated personal/historical events, and date-placed
letters. Includes proposed sub-issue breakdown for a milestone.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

docs(timeline): add Person date+precision migration as foundational issue ... ebe4198be9

Replace Person birthYear/deathYear integers with birthDate/deathDate +
DatePrecision so known exact birthdays render precisely. Migration,
re-import preservation rule, and bounded blast radius captured; becomes
issue 1 the timeline's derived events depend on.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

docs(timeline): add Zeitstrahl visual specs (global Concept A, event editor) ... db081b0488

Visual design specs for Milestone #14:
- zeitstrahl-global-concepts.html — A/B/C exploration of the global timeline
- zeitstrahl-final-spec.html — canonical Concept A (global + per-person Lebensweg)
- zeitstrahl-event-editor-spec.html — curator event editor + document quick-action

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

feat(geschichten): add i18n keys for document filter chip and empty state ... 7b858e5afd

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(geschichten): resolve document title in loader, return documentFilter object ... 03e0dae5aa

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(geschichten): add DocumentFilterChip component with spec ... dcc9a25fdc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(geschichten): integrate DocumentFilterChip into list page ... 1de10986c3

Add DocumentFilterChip to the filter bar, extract emptyMessage as $derived.by() with person-wins precedence, and add removeDocument navigation helper. Update tests: add document-filter chip and empty-state-precedence suites, fix person-chip click test to use native element.click() + vi.waitFor() for reliable Svelte 5 onclick triggering.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel force-pushed feat/issue-803-geschichten-document-filter-chip from b2b3eb0b1c to 1de10986c3 2026-06-12 10:07:04 +02:00 Compare

marcel added 1 commit 2026-06-12 10:32:11 +02:00

fix(geschichten): correct three bugs found in PR review ... 8eb4a0ffde

- Pass validated documentId (not raw) to /api/geschichten — Spring backend
  declares @RequestParam UUID documentId; invalid strings cause HTTP 400
- rebuildUrl no longer deletes documentId unconditionally; clearAll and
  removeDocument handle their own documentId deletion explicitly, so
  removePerson/addPerson now preserve an active document filter
- Use ?? instead of || when falling back from doc.title to originalFilename,
  preserving an intentionally-empty title rather than overwriting it

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

marcel merged commit 8eb4a0ffde into feat/issue-750-lesereisen-data-model 2026-06-12 10:45:50 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

P0-critical

Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.

P1-high

Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.

P2-medium

Noticeable improvement; doesn't block anything; schedule opportunistically.

P3-later

Cosmetic or parking-lot work; fine to stay open indefinitely.

audit

Read-only audit / assessment work; produces a report rather than changing code

bug

Something isn't working

cleanup

Removal of dead code, vague comments, naming violations, and scratch artifacts

collaboration

We want to extend the family archive to have more collaboration tools

conversation

descoped

We will do that later

devops

documentation

README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs

epic

Marker for epic-level issues that group multiple child issues

feature

file-upload

legibility

Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction

needs-discussion

Has an open decision or design question that must be resolved before implementation can start.

notification

person

phase-1: security

Security hygiene — must be done first

phase-2: container-images

Production-ready multi-stage Docker images

phase-3: prod-compose

Production compose overlay + Caddy reverse proxy

phase-4: spring-prod-profile

Spring Boot production configuration profile

phase-5: backups

Database and object storage backup strategy

phase-6: deployment-docs

.env.example, DEPLOYMENT.md, runbook

phase-7: monitoring

Prometheus, Loki, Grafana, Alertmanager

refactor

Code restructuring without behaviour change

security

test

ui

UI/UX and accessibility issues

user

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Jens marcel

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: marcel/familienarchiv#811