marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(geschichten): add drafts to the overview page test mock data #815

Merged
marcel merged 1 commits from fix/814-geschichten-drafts-test-mock into main 2026-06-12 22:11:04 +02:00
Conversation 0 Commits 1 Files Changed 1 +1
marcel commented 2026-06-12 22:06:27 +02:00
Owner
Copy Link

Fixes the red CI on main: all 15 tests in frontend/src/routes/geschichten/page.svelte.test.ts crashed with TypeError: Cannot read properties of undefined (reading 'length') at +page.svelte:137.

PR #813 added the Entwürfe section reading data.drafts, which +page.server.ts always returns — but the pre-existing page.svelte.test.ts mock (baseData()) predates the field, and the #813 branch diverged before those coverage tests landed, so the combination was only exercised on main after merge.

One-line fix: add drafts: [] to baseData() so the mock matches the load contract. Drafts rendering itself is already covered by page.svelte.spec.ts from #813.

Verified locally: npx vitest run --project=client src/routes/geschichten/page.svelte.test.ts → 15 passed.

Closes #814

🤖 Generated with Claude Code

Fixes the red CI on `main`: all 15 tests in `frontend/src/routes/geschichten/page.svelte.test.ts` crashed with `TypeError: Cannot read properties of undefined (reading 'length')` at `+page.svelte:137`. PR #813 added the Entwürfe section reading `data.drafts`, which `+page.server.ts` always returns — but the pre-existing `page.svelte.test.ts` mock (`baseData()`) predates the field, and the #813 branch diverged before those coverage tests landed, so the combination was only exercised on main after merge. One-line fix: add `drafts: []` to `baseData()` so the mock matches the load contract. Drafts rendering itself is already covered by `page.svelte.spec.ts` from #813. Verified locally: `npx vitest run --project=client src/routes/geschichten/page.svelte.test.ts` → 15 passed. Closes #814 🤖 Generated with [Claude Code](https://claude.com/claude-code)
marcel added 1 commit 2026-06-12 22:06:27 +02:00
test(geschichten): add drafts to the overview page test mock data
Some checks failed
CI / Compose Bucket Idempotency (pull_request) Waiting to run
Details
CI / OCR Service Tests (pull_request) Has been cancelled
Details
CI / Backend Unit Tests (pull_request) Has been cancelled
Details
CI / fail2ban Regex (pull_request) Has been cancelled
Details
CI / Semgrep Security Scan (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (pull_request) Has been cancelled
Details
CI / Unit & Component Tests (push) Successful in 4m37s
Details
CI / OCR Service Tests (push) Successful in 26s
Details
CI / Backend Unit Tests (push) Successful in 5m25s
Details
CI / fail2ban Regex (push) Successful in 47s
Details
CI / Semgrep Security Scan (push) Successful in 27s
Details
CI / Compose Bucket Idempotency (push) Successful in 1m7s
Details
f64acbc697 
PR #813 made +page.svelte read data.drafts, which the load function
always returns, but the pre-existing page.svelte.test.ts mock predates
the field — all 15 tests crashed with TypeError on main after merge.

Closes #814
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
marcel merged commit f64acbc697 into main 2026-06-12 22:11:04 +02:00
marcel deleted branch fix/814-geschichten-drafts-test-mock 2026-06-12 22:11:04 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 needs-discussion
Has an open decision or design question that must be resolved before implementation can start.
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#815
Delete Branch "fix/814-geschichten-drafts-test-mock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?